)]}'
{"id":"openocd~master~I1234737b3e65bd10df5e938d1c36f9abaf02d348","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-10-05 15:49:04.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I1234737b3e65bd10df5e938d1c36f9abaf02d348","subject":"OpenOCD: drop comparison with true/false","status":"MERGED","created":"2024-09-16 11:59:37.000000000","updated":"2024-10-05 15:49:04.000000000","submitted":"2024-10-05 15:49:04.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8496","meta_rev_id":"b3c17923bdb944c386d0535317e1dee1fec1ab76","_number":8496,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-10-05 15:49:04.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-10-05 15:49:04.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-10-05 15:49:04.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-09-16 13:58:33.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-09-21 09:50:41.000000000","updated_by":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"reviewer":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"REVIEWER"}],"messages":[{"id":"1d52a3e30033402ffe9af7cda7c5884aeff07604","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-09-16 11:59:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"99227d5b805dcad47a08215991de010bb2935da8","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-09-16 13:58:33.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20015/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19170/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"5c8a17747633c95c2e3549953fad30cc5720f5d8","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-09-16 22:34:36.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"5f697a724568558ae03fe4012ef499388fce7063","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2024-09-21 09:50:41.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"b3c17923bdb944c386d0535317e1dee1fec1ab76","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-10-05 15:49:04.000000000","message":"Change has been successfully cherry-picked as 3ccf68cd0a8aa740565456317bae9d43618ef662","accounts_in_message":[],"_revision_number":2}],"current_revision":"3ccf68cd0a8aa740565456317bae9d43618ef662","revisions":{"3ccf68cd0a8aa740565456317bae9d43618ef662":{"kind":"REWORK","_number":2,"created":"2024-10-05 15:49:04.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/96/8496/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/96/8496/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/96/8496/2 \u0026\u0026 git checkout -b change-8496 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/96/8496/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/96/8496/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/96/8496/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/96/8496/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/96/8496/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"66006d83b99843ab7c6ec19125e2fc20855a4c7c","subject":"target: drop comparison to NULL"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-09-16 09:55:20.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-10-05 15:49:04.000000000","tz":0},"subject":"OpenOCD: drop comparison with true/false","message":"OpenOCD: drop comparison with true/false\n\nFix checkpatch errors:\n\n\tERROR:BOOL_COMPARISON: Using comparison to true/false is\n\terror prone\n\nWhile there,\n- drop useless parenthesis,\n- drop unnecessary else after a return.\n\nChange-Id: I1234737b3e65bd10df5e938d1c36f9abaf02d348\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8496\nReviewed-by: zapb \u003cdev@zapb.de\u003e\nTested-by: jenkins\n"}},"cb720df6ca0b056573256e31aa8502f78972179f":{"kind":"REWORK","_number":1,"created":"2024-09-16 11:59:37.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/96/8496/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/96/8496/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/96/8496/1 \u0026\u0026 git checkout -b change-8496 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/96/8496/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/96/8496/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/96/8496/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/96/8496/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/96/8496/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9735277a8e2c7d2f0ca2a8535740c4a3b397f481","subject":"target: drop comparison to NULL"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-09-16 09:55:20.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-09-16 11:57:19.000000000","tz":120},"subject":"OpenOCD: drop comparison with true/false","message":"OpenOCD: drop comparison with true/false\n\nFix checkpatch errors:\n\n\tERROR:BOOL_COMPARISON: Using comparison to true/false is\n\terror prone\n\nWhile there,\n- drop useless parenthesis,\n- drop unnecessary else after a return.\n\nChange-Id: I1234737b3e65bd10df5e938d1c36f9abaf02d348\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}