)]}'
{"id":"openocd~master~I0690b68b511ed7f45a7e0909a0addd2822ba9fe8","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-10-05 15:50:18.000000000","reason":"removed on reply"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2024-09-18 19:08:40.000000000","reason":"\u003cGERRIT_ACCOUNT_1000687\u003e replied on the change","reason_account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}},"hashtags":[],"change_id":"I0690b68b511ed7f45a7e0909a0addd2822ba9fe8","subject":"jtag: bcm2835gpio: fix macro definition","status":"MERGED","created":"2024-09-16 11:59:37.000000000","updated":"2024-10-05 15:50:23.000000000","submitted":"2024-10-05 15:50:23.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8499","meta_rev_id":"91bad261b9abd9bed4a3cd13f414428c7c21bf9e","_number":8499,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-10-05 15:50:23.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-10-05 15:50:23.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-10-05 15:50:23.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-09-16 14:40:34.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-09-16 22:34:18.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"d3214969b0a173abbf543e14e8f4aa8856405278","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-09-16 11:59:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0189dc8b616e766dc6d7b29f6e510135b1149fd0","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-09-16 14:40:34.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/19173/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit/20016/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"03bbfd219a53b07d2d3b4b53f7f224929a0be809","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-09-16 21:16:16.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"c7d7f1f46da5b18115a21b99d78aaaf372269ac1","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-09-16 21:17:30.000000000","message":"Patch Set 2: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/20021/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19176/ : FAILURE","accounts_in_message":[],"_revision_number":2},{"id":"e07570d3aa8e8cc73aeb7e5361ef7ac3f555383e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-09-16 21:45:56.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"a43169464cea89f9c6b9f6319cb54b395a905d9b","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-09-16 21:59:09.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20022/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19177/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"b797e70ee11b0cf1ff836c9e03ec9781f43c31e2","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-09-16 22:34:18.000000000","message":"Patch Set 3: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"5db1c18586bd47694982384826460f0a19139d93","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-09-18 19:08:40.000000000","message":"Patch Set 3: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"1fd9068fb8cef4e0969167f657f3ae588ac8b12b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-10-05 15:50:18.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"91bad261b9abd9bed4a3cd13f414428c7c21bf9e","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-10-05 15:50:23.000000000","message":"Change has been successfully cherry-picked as 595bb965b745371e07091c96ced478c8cd0b0d82","accounts_in_message":[],"_revision_number":4}],"current_revision":"595bb965b745371e07091c96ced478c8cd0b0d82","revisions":{"595bb965b745371e07091c96ced478c8cd0b0d82":{"kind":"REWORK","_number":4,"created":"2024-10-05 15:50:23.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/99/8499/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/99/8499/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/99/8499/4 \u0026\u0026 git checkout -b change-8499 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/99/8499/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/99/8499/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/99/8499/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/99/8499/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/99/8499/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8c23e6c1759be497c1328837fb49992d489b0719","subject":"target: arm: drop casts commented-out"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-09-16 08:58:37.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-10-05 15:50:23.000000000","tz":0},"subject":"jtag: bcm2835gpio: fix macro definition","message":"jtag: bcm2835gpio: fix macro definition\n\nThe macros trigger few errors with checkpatch:\n\n\tERROR:MACRO_ARG_REUSE: Macro argument reuse \u0027g\u0027 - possible\n\tside-effects?\n\n\tERROR:TRAILING_STATEMENTS: trailing statements should be\n\ton next line\n\n\tERROR:SPACING: spaces preferred around (several cases)\n\n\tERROR:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement\n\tmacros should not use a do {} while (0) loop\n\nplus an empty line triggers\n\n\tERROR:BRACES: Blank lines aren\u0027t necessary before a close\n\tbrace \u0027}\u0027\n\nFix them!\n\nChange-Id: I0690b68b511ed7f45a7e0909a0addd2822ba9fe8\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8499\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"920cdd251b1bc7e8dc4857f5ad1e9cd3d13829d0":{"kind":"REWORK","_number":1,"created":"2024-09-16 11:59:37.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/99/8499/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/99/8499/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/99/8499/1 \u0026\u0026 git checkout -b change-8499 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/99/8499/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/99/8499/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/99/8499/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/99/8499/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/99/8499/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4f2df0daf37cc3f8c2f8c37c0ea06772ec783fe8","subject":"target: arm: drop casts commented-out"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-09-16 08:58:37.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-09-16 11:57:19.000000000","tz":120},"subject":"jtag: bcm2835gpio: fix macro definition","message":"jtag: bcm2835gpio: fix macro definition\n\nThe macros trigger few errors with checkpatch:\n\n\tERROR:MACRO_ARG_REUSE: Macro argument reuse \u0027g\u0027 - possible\n\tside-effects?\n\n\tERROR:TRAILING_STATEMENTS: trailing statements should be\n\ton next line\n\n\tERROR:SPACING: spaces preferred around (several cases)\n\n\tERROR:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement\n\tmacros should not use a do {} while (0) loop\n\nplus an empty line triggers\n\n\tERROR:BRACES: Blank lines aren\u0027t necessary before a close\n\tbrace \u0027}\u0027\n\nFix them!\n\nChange-Id: I0690b68b511ed7f45a7e0909a0addd2822ba9fe8\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"9cb4ecd4efc8af3de008787988f559ebdc946b3c":{"kind":"REWORK","_number":3,"created":"2024-09-16 21:45:56.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/99/8499/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/99/8499/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/99/8499/3 \u0026\u0026 git checkout -b change-8499 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/99/8499/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/99/8499/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/99/8499/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/99/8499/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/99/8499/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4f2df0daf37cc3f8c2f8c37c0ea06772ec783fe8","subject":"target: arm: drop casts commented-out"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-09-16 08:58:37.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-09-16 21:44:59.000000000","tz":120},"subject":"jtag: bcm2835gpio: fix macro definition","message":"jtag: bcm2835gpio: fix macro definition\n\nThe macros trigger few errors with checkpatch:\n\n\tERROR:MACRO_ARG_REUSE: Macro argument reuse \u0027g\u0027 - possible\n\tside-effects?\n\n\tERROR:TRAILING_STATEMENTS: trailing statements should be\n\ton next line\n\n\tERROR:SPACING: spaces preferred around (several cases)\n\n\tERROR:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement\n\tmacros should not use a do {} while (0) loop\n\nplus an empty line triggers\n\n\tERROR:BRACES: Blank lines aren\u0027t necessary before a close\n\tbrace \u0027}\u0027\n\nFix them!\n\nChange-Id: I0690b68b511ed7f45a7e0909a0addd2822ba9fe8\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"8374a8c59830add3dd5faf98640ba2d77f8c1c9c":{"kind":"REWORK","_number":2,"created":"2024-09-16 21:16:16.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/99/8499/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/99/8499/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/99/8499/2 \u0026\u0026 git checkout -b change-8499 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/99/8499/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/99/8499/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/99/8499/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/99/8499/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/99/8499/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4f2df0daf37cc3f8c2f8c37c0ea06772ec783fe8","subject":"target: arm: drop casts commented-out"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-09-16 08:58:37.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-09-16 21:15:42.000000000","tz":120},"subject":"jtag: bcm2835gpio: fix macro definition","message":"jtag: bcm2835gpio: fix macro definition\n\nThe macros trigger few errors with checkpatch:\n\n\tERROR:MACRO_ARG_REUSE: Macro argument reuse \u0027g\u0027 - possible\n\tside-effects?\n\n\tERROR:TRAILING_STATEMENTS: trailing statements should be\n\ton next line\n\n\tERROR:SPACING: spaces preferred around (several cases)\n\n\tERROR:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement\n\tmacros should not use a do {} while (0) loop\n\nplus an empty line triggers\n\n\tERROR:BRACES: Blank lines aren\u0027t necessary before a close\n\tbrace \u0027}\u0027\n\nFix them!\n\nChange-Id: I0690b68b511ed7f45a7e0909a0addd2822ba9fe8\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}