)]}'
{"id":"openocd~master~I19c414c351f52aff72a60330d83c29db7bbca375","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002047":{"account":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"last_update":"2024-11-11 17:33:56.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I19c414c351f52aff72a60330d83c29db7bbca375","subject":"target/breakpoints: fix types in `watchpoint_add_internal()`","status":"MERGED","created":"2024-09-16 15:09:20.000000000","updated":"2024-11-11 17:33:56.000000000","submitted":"2024-11-11 17:33:56.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8500","meta_rev_id":"cbcfd89b9d853ff16aa8458c573af7c85528ff79","_number":8500,"owner":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"value":0,"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-11-11 17:33:56.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-11-11 17:33:56.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-11-11 17:33:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-11-11 17:33:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-11-11 17:33:56.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-09-16 15:10:12.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-09-17 05:35:03.000000000","updated_by":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"reviewer":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"state":"REVIEWER"},{"updated":"2024-09-27 12:03:39.000000000","updated_by":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"reviewer":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"state":"REVIEWER"},{"updated":"2024-09-28 09:48:09.000000000","updated_by":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"reviewer":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"REVIEWER"},{"updated":"2024-11-10 18:54:43.000000000","updated_by":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2024-11-11 17:33:51.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"9c43f080d2f6276e15c6a78e72453ba7c6b1a1ac","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2024-09-16 15:09:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"332f79916f7dcc9c6c689c755c2a41d45c877fbc","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-09-16 15:10:12.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/20019/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19174/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"3f6cd73a536470726095c21c5a8ffbec826723b2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2024-09-16 15:14:07.000000000","message":"Uploaded patch set 2: Commit message was updated.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"17b58bd96b6595be199256e7d7ae7e3b249a7f13","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-09-16 15:27:26.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20020/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19175/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"10d57e5e21e9a7caf324aa0f9ad4cf42c880325e","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2024-09-17 05:35:03.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"06dfdf464c1f62b5be860a93a8a3b6488408ce90","author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"real_author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"date":"2024-09-27 12:03:39.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"970328dcc4326e32c246e86787581eaa3796625c","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2024-09-28 09:48:09.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"094fc7d5c87df21c9e7bea44f958d59889402cce","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2024-11-10 18:54:27.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"9895dab777c00508b359ba3620541b94ece909e7","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-11-11 17:33:51.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"cbcfd89b9d853ff16aa8458c573af7c85528ff79","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-11-11 17:33:56.000000000","message":"Change has been successfully cherry-picked as fd62626dff25cf503a25040d3040b0a2bb9b2a76","accounts_in_message":[],"_revision_number":3}],"current_revision":"fd62626dff25cf503a25040d3040b0a2bb9b2a76","revisions":{"58dd7b8c51fd6c501d3e864e555fcd40455a9c77":{"kind":"REWORK","_number":1,"created":"2024-09-16 15:09:20.000000000","uploader":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"ref":"refs/changes/00/8500/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/00/8500/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/00/8500/1 \u0026\u0026 git checkout -b change-8500 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/00/8500/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/00/8500/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/00/8500/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/00/8500/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/00/8500/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"fd7b66c5eb038185b72953821204ec9bb8ce49d1","subject":"binarybuffer: Fix inverted return value in buf_cmp"}],"author":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2024-09-16 15:01:17.000000000","tz":180},"committer":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2024-09-16 15:09:13.000000000","tz":180},"subject":"target/breakpoints: fix types in `watchpoint_add_internal()`","message":"target/breakpoints: fix types in `watchpoint_add_internal()`\n\nThere was a conflict:\n1. 2cd8ebf44d1afd59b524b09561a8bd2f90f0c27a changed `mask`\u0027s and\n  `value`\u0027s type to `uint64_t`.\n2. 0bf3373e808a097fdf50fc04f987c26b35ddf09d changed `length`\u0027s type to\n   `unsigned int`.\nThe second commit was created erlier, but merged later so the types of\n`mask` and `value` became `uint32_t` in `watchpoint_add_internal()`.\n\nThis created a bug:\n`WATCHPOINT_IGNORE_DATA_VALUE_MASK` is defined as `(~(uint64_t)0)`.\nTruncation to uint32_t makes it so the comparisons with the constant\ndon\u0027t work.\n\nChange-Id: I19c414c351f52aff72a60330d83c29db7bbca375\nSigned-off-by: Evgeniy Naydanov \u003cevgeniy.naydanov@syntacore.com\u003e\n"}},"6cf55c699d6dfc7661e9a09db79493f642175bd9":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2024-09-16 15:14:07.000000000","uploader":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"ref":"refs/changes/00/8500/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/00/8500/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/00/8500/2 \u0026\u0026 git checkout -b change-8500 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/00/8500/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/00/8500/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/00/8500/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/00/8500/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/00/8500/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"fd7b66c5eb038185b72953821204ec9bb8ce49d1","subject":"binarybuffer: Fix inverted return value in buf_cmp"}],"author":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2024-09-16 15:01:17.000000000","tz":180},"committer":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2024-09-16 15:13:46.000000000","tz":180},"subject":"target/breakpoints: fix types in `watchpoint_add_internal()`","message":"target/breakpoints: fix types in `watchpoint_add_internal()`\n\nThere was a conflict:\n1. commit 2cd8ebf44d1a (\"breakpoints: use 64-bit type for watchpoint mask\n   and value\")\n2. commit 0bf3373e808a (\"target/breakpoints: Use \u0027unsigned int\u0027 for\n   length\")\n\nThe second commit was created erlier, but merged later so the types of\n`mask` and `value` became `uint32_t` in `watchpoint_add_internal()`.\n\nThis created a bug:\n`WATCHPOINT_IGNORE_DATA_VALUE_MASK` is defined as `(~(uint64_t)0)`.\nTruncation to uint32_t makes it so the comparisons with the constant\ndon\u0027t work.\n\nChange-Id: I19c414c351f52aff72a60330d83c29db7bbca375\nSigned-off-by: Evgeniy Naydanov \u003cevgeniy.naydanov@syntacore.com\u003e\n"}},"fd62626dff25cf503a25040d3040b0a2bb9b2a76":{"kind":"REWORK","_number":3,"created":"2024-11-11 17:33:56.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/00/8500/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/00/8500/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/00/8500/3 \u0026\u0026 git checkout -b change-8500 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/00/8500/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/00/8500/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/00/8500/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/00/8500/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/00/8500/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b68d23da3c3bc67cffc750fddd64a6be9c615fdb","subject":"tcl/target/bl702: implement full software reset"}],"author":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2024-09-16 15:01:17.000000000","tz":180},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-11-11 17:33:56.000000000","tz":0},"subject":"target/breakpoints: fix types in `watchpoint_add_internal()`","message":"target/breakpoints: fix types in `watchpoint_add_internal()`\n\nThere was a conflict:\n1. commit 2cd8ebf44d1a (\"breakpoints: use 64-bit type for watchpoint mask\n   and value\")\n2. commit 0bf3373e808a (\"target/breakpoints: Use \u0027unsigned int\u0027 for\n   length\")\n\nThe second commit was created erlier, but merged later so the types of\n`mask` and `value` became `uint32_t` in `watchpoint_add_internal()`.\n\nThis created a bug:\n`WATCHPOINT_IGNORE_DATA_VALUE_MASK` is defined as `(~(uint64_t)0)`.\nTruncation to uint32_t makes it so the comparisons with the constant\ndon\u0027t work.\n\nChange-Id: I19c414c351f52aff72a60330d83c29db7bbca375\nSigned-off-by: Evgeniy Naydanov \u003cevgeniy.naydanov@syntacore.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8500\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-by: Jan Matyas \u003cjan.matyas@codasip.com\u003e\nTested-by: jenkins\nReviewed-by: zapb \u003cdev@zapb.de\u003e\nReviewed-by: Karl Palsson \u003ckarlp@tweak.au\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}