)]}'
{"id":"openocd~master~Ie43a792ac11a5e63e0407b68e3f270efea0c87be","project":"openocd","branch":"master","hashtags":[],"change_id":"Ie43a792ac11a5e63e0407b68e3f270efea0c87be","subject":"openocd: build: allow more socket connections on Windows","status":"MERGED","created":"2024-09-23 10:04:12.000000000","updated":"2024-10-05 15:51:58.000000000","submitted":"2024-10-05 15:51:58.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8503","meta_rev_id":"290165029f940f8b6fb7a8887b62a8c1fd746411","_number":8503,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-10-05 15:51:58.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-10-05 15:51:58.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-09-23 10:35:47.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"a008e5439c73885e4647592bd4807ebaa0d1ebf4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-09-23 10:04:12.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"bea8f200a334d672410d198ead4ec666735222d6","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-09-23 10:35:47.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20029/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19184/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"440775e53bffe19029345714d4761c8bc6ee5380","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-09-23 11:49:47.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"37e06d62ddb480641b39fd523fff0af67127e8b8","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-10-05 15:51:54.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"290165029f940f8b6fb7a8887b62a8c1fd746411","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-10-05 15:51:58.000000000","message":"Change has been successfully cherry-picked as 116e9553d12193faa08e668b3d9504ef995bd21f","accounts_in_message":[],"_revision_number":2}],"current_revision":"116e9553d12193faa08e668b3d9504ef995bd21f","revisions":{"a8130fcb9322993f3b117086d57cfb1c3986cdc7":{"kind":"REWORK","_number":1,"created":"2024-09-23 10:04:12.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/03/8503/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/03/8503/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/03/8503/1 \u0026\u0026 git checkout -b change-8503 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/03/8503/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/03/8503/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/03/8503/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/03/8503/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/03/8503/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ad216136180e0cd482f414eb072c9dd25dd1c559","subject":"server/telnet: Restructure commands"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-09-22 16:32:21.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-09-23 10:00:18.000000000","tz":120},"subject":"openocd: build: allow more socket connections on Windows","message":"openocd: build: allow more socket connections on Windows\n\nCross compiling OpenOCD for Windows forces the maximum number of\nopen files (including sockets) to 64. See in include file\npsdk_inc/_fd_types.h:\n\t#ifndef FD_SETSIZE\n\t#define FD_SETSIZE 64\n\t#endif\n\nThis limit is far lower than the default value 1024 used by Linux.\n\nIn pull request #644 [1] in risc-v fork it\u0027s reported that:\n- each socket server of OpenOCD (GDB, telnet, ...) uses one FD;\n- each active connection to a socket server uses another FD;\n- multi-core devices with 32 or more cores, each having a GDB\n  connection, already saturates the 64 available FD at the 26th\n  GDB connection.\n\nThe patch [2] proposed and merged in risc-v fork adds the compile\nflag\n\t-DFD_SETSIZE\u003d128\nto all the host types. While this looks fine for Windows, it\nreduces the default value for Linux and other OS.\n\nAdd the compile flag FD_SETSIZE only to cross compile for Windows.\n\nLink: [1] https://github.com/riscv-collab/riscv-openocd/pull/644\nLink: [2] https://github.com/riscv-collab/riscv-openocd/pull/644/commits/1bab4cfbc4f4\nChange-Id: Ie43a792ac11a5e63e0407b68e3f270efea0c87be\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"116e9553d12193faa08e668b3d9504ef995bd21f":{"kind":"REWORK","_number":2,"created":"2024-10-05 15:51:58.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/03/8503/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/03/8503/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/03/8503/2 \u0026\u0026 git checkout -b change-8503 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/03/8503/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/03/8503/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/03/8503/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/03/8503/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/03/8503/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"595bb965b745371e07091c96ced478c8cd0b0d82","subject":"jtag: bcm2835gpio: fix macro definition"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-09-22 16:32:21.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-10-05 15:51:58.000000000","tz":0},"subject":"openocd: build: allow more socket connections on Windows","message":"openocd: build: allow more socket connections on Windows\n\nCross compiling OpenOCD for Windows forces the maximum number of\nopen files (including sockets) to 64. See in include file\npsdk_inc/_fd_types.h:\n\t#ifndef FD_SETSIZE\n\t#define FD_SETSIZE 64\n\t#endif\n\nThis limit is far lower than the default value 1024 used by Linux.\n\nIn pull request #644 [1] in risc-v fork it\u0027s reported that:\n- each socket server of OpenOCD (GDB, telnet, ...) uses one FD;\n- each active connection to a socket server uses another FD;\n- multi-core devices with 32 or more cores, each having a GDB\n  connection, already saturates the 64 available FD at the 26th\n  GDB connection.\n\nThe patch [2] proposed and merged in risc-v fork adds the compile\nflag\n\t-DFD_SETSIZE\u003d128\nto all the host types. While this looks fine for Windows, it\nreduces the default value for Linux and other OS.\n\nAdd the compile flag FD_SETSIZE only to cross compile for Windows.\n\nLink: [1] https://github.com/riscv-collab/riscv-openocd/pull/644\nLink: [2] https://github.com/riscv-collab/riscv-openocd/pull/644/commits/1bab4cfbc4f4\nChange-Id: Ie43a792ac11a5e63e0407b68e3f270efea0c87be\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8503\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}