)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"c77f4683a2c55b79c9501d7433620f4242b52d0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c5d948a8_05961005","updated":"2024-10-22 07:23:37.000000000","message":"Antonio (or anyone else from the OpenOCD maintainers),\n\nif you have a moment, could you please look at the new type of tests that Evgeniy has proposed in this patch? I believe they would be **very** useful for automated regression testing of OpenOCD. \n\nThank you.","commit_id":"6d34c49d7a2831df0d2836b9acff3f998b84fc7c"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"5deaaa46cac5cb98a0bc3be29dac310ec897ee5d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ff046299_a96bb8d6","updated":"2024-09-27 08:46:07.000000000","message":"I very much like this type of tests! Thank you for introducing them.\n\nOne suggestion: Could you please move the tests to a subdirectory of \"testing\", e.g. \"testing/tcl_commands\". The reason is that I\u0027d like to introduce a completely different type of tests -- unit tests. These could go to \"testing/unittests\", so that there is a very clear separation of them. \n\n(I will submit a draft of the unit tests shortly.)","commit_id":"6d34c49d7a2831df0d2836b9acff3f998b84fc7c"},{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"b950cd1b7458fe979d4f363f4d108ae59f340edf","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"22f497cc_83b274e4","in_reply_to":"ff046299_a96bb8d6","updated":"2024-12-11 13:31:02.000000000","message":"\u003e Could you please move the tests to a subdirectory of \"testing\", e.g. \"testing/tcl_commands\".\n\nAddressed.","commit_id":"6d34c49d7a2831df0d2836b9acff3f998b84fc7c"}],"testing/utils.tcl":[{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"5deaaa46cac5cb98a0bc3be29dac310ec897ee5d","unresolved":true,"context_lines":[{"line_number":24,"context_line":"\t\tset code [catch {uplevel 1 $script} msg]"},{"line_number":25,"context_line":"\t\tif {$code !\u003d $expected_code} {"},{"line_number":26,"context_line":"\t\t\ttest_failure \\"},{"line_number":27,"context_line":"\t\t\t\t\"Expecting error code $expected_code, not $code for \u0027$script\u0027. Error message: \u0027$msg\u0027\""},{"line_number":28,"context_line":"\t\t}"},{"line_number":29,"context_line":"\t}"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-tcl","patch_set":3,"id":"722a6d00_257fffc9","line":27,"updated":"2024-09-27 08:46:07.000000000","message":"Similarly to the previous comment, the error message can be simplified:\n\n```\n\"\u0027$script\u0027 ended with unexpected error code $code. Expected code was $expected_code. Error message: \u0027$msg\u0027\"\n```","commit_id":"6d34c49d7a2831df0d2836b9acff3f998b84fc7c"},{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"b950cd1b7458fe979d4f363f4d108ae59f340edf","unresolved":true,"context_lines":[{"line_number":24,"context_line":"\t\tset code [catch {uplevel 1 $script} msg]"},{"line_number":25,"context_line":"\t\tif {$code !\u003d $expected_code} {"},{"line_number":26,"context_line":"\t\t\ttest_failure \\"},{"line_number":27,"context_line":"\t\t\t\t\"Expecting error code $expected_code, not $code for \u0027$script\u0027. Error message: \u0027$msg\u0027\""},{"line_number":28,"context_line":"\t\t}"},{"line_number":29,"context_line":"\t}"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-tcl","patch_set":3,"id":"fd82cf15_a846e28d","line":27,"in_reply_to":"722a6d00_257fffc9","updated":"2024-12-11 13:31:02.000000000","message":"Addressed.","commit_id":"6d34c49d7a2831df0d2836b9acff3f998b84fc7c"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"5deaaa46cac5cb98a0bc3be29dac310ec897ee5d","unresolved":true,"context_lines":[{"line_number":48,"context_line":"\t\tset result [uplevel $script]"},{"line_number":49,"context_line":"\t\tif {[regexp $pattern $result]} {return}"},{"line_number":50,"context_line":"\t\ttest_failure \\"},{"line_number":51,"context_line":"\t\t\t\"Expecting the result of \u0027$script\u0027, which is \u0027$result\u0027, to match \u0027$pattern\u0027\""},{"line_number":52,"context_line":"\t}"},{"line_number":53,"context_line":"\tnamespace export check_invalid_arg check_syntax_err check_overflow_err \\"},{"line_number":54,"context_line":"\t\tcheck_underflow_err check_matches"}],"source_content_type":"text/x-tcl","patch_set":3,"id":"c06b78bd_fee201ec","line":51,"updated":"2024-09-27 08:46:07.000000000","message":"Detail - the message can be simplified:\n\n```\n\"\u0027$script\u0027 produced unexpected result \u0027$result\u0027. Expected was \u0027$pattern\u0027.\"\n```","commit_id":"6d34c49d7a2831df0d2836b9acff3f998b84fc7c"},{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"b950cd1b7458fe979d4f363f4d108ae59f340edf","unresolved":true,"context_lines":[{"line_number":48,"context_line":"\t\tset result [uplevel $script]"},{"line_number":49,"context_line":"\t\tif {[regexp $pattern $result]} {return}"},{"line_number":50,"context_line":"\t\ttest_failure \\"},{"line_number":51,"context_line":"\t\t\t\"Expecting the result of \u0027$script\u0027, which is \u0027$result\u0027, to match \u0027$pattern\u0027\""},{"line_number":52,"context_line":"\t}"},{"line_number":53,"context_line":"\tnamespace export check_invalid_arg check_syntax_err check_overflow_err \\"},{"line_number":54,"context_line":"\t\tcheck_underflow_err check_matches"}],"source_content_type":"text/x-tcl","patch_set":3,"id":"1540a925_f433f57e","line":51,"in_reply_to":"c06b78bd_fee201ec","updated":"2024-12-11 13:31:02.000000000","message":"Addressed.","commit_id":"6d34c49d7a2831df0d2836b9acff3f998b84fc7c"}]}