)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ad2416255bb44d6c6a4542e56580935b062ffd62","unresolved":true,"context_lines":[{"line_number":13,"context_line":"the fix is safe."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I84d9f9c64c9a7df452ca6e99c2ee4169ccb2b0be"},{"line_number":16,"context_line":"Signed-off-by: Jan Matyas \u003cjan.matyas@codasip.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9c2830fb_6f0eea32","line":16,"updated":"2024-09-27 08:17:53.000000000","message":"Please add\n`Fixes: 9544cd653df1 (\"helper: add align.h\")`","commit_id":"33dc4dbe7ab83d2ef613452be99860ff8148d6d5"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"d7c13dde23fb3c62400770d5c1541a8c175b07b1","unresolved":false,"context_lines":[{"line_number":13,"context_line":"the fix is safe."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I84d9f9c64c9a7df452ca6e99c2ee4169ccb2b0be"},{"line_number":16,"context_line":"Signed-off-by: Jan Matyas \u003cjan.matyas@codasip.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f4eceebe_8fa5db16","line":16,"in_reply_to":"9c2830fb_6f0eea32","updated":"2024-09-27 12:47:18.000000000","message":"Done","commit_id":"33dc4dbe7ab83d2ef613452be99860ff8148d6d5"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ad2416255bb44d6c6a4542e56580935b062ffd62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"03c1e189_242d1f25","updated":"2024-09-27 08:17:53.000000000","message":"Agree on dropping the value `0`.\nIt is also done in Linux kernel `is_power_of_2()` in `include/linux/log2.h`.\nActually I don\u0027t find from where I copied this in my commit https://review.openocd.org/c/openocd/+/6374","commit_id":"33dc4dbe7ab83d2ef613452be99860ff8148d6d5"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e43c0d4e09009208263a63c2429ea606b458a242","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5677d391_538c5add","updated":"2024-09-28 15:08:00.000000000","message":"thanks!","commit_id":"60a438b6a269e0b6f23318d3a061f8c37266a128"}],"src/helper/align.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ad2416255bb44d6c6a4542e56580935b062ffd62","unresolved":true,"context_lines":[{"line_number":24,"context_line":"#define IS_PWR_OF_2(x)                  \\"},{"line_number":25,"context_line":"({                                      \\"},{"line_number":26,"context_line":"\ttypeof(x) _x \u003d (x);                 \\"},{"line_number":27,"context_line":"\t_x !\u003d 0 || (_x \u0026 (_x - 1)) \u003d\u003d 0;    \\"},{"line_number":28,"context_line":"})"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"#endif /* OPENOCD_HELPER_ALIGN_H */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"6f8fb9d5_48c5fa42","line":27,"updated":"2024-09-27 08:17:53.000000000","message":"Shouldn\u0027t be `\u0026\u0026` instead of `||` ?\n```\n_x !\u003d 0 \u0026\u0026 (_x \u0026 (_x - 1)) \u003d\u003d 0;\n        ^^\n```","commit_id":"33dc4dbe7ab83d2ef613452be99860ff8148d6d5"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"d7c13dde23fb3c62400770d5c1541a8c175b07b1","unresolved":false,"context_lines":[{"line_number":24,"context_line":"#define IS_PWR_OF_2(x)                  \\"},{"line_number":25,"context_line":"({                                      \\"},{"line_number":26,"context_line":"\ttypeof(x) _x \u003d (x);                 \\"},{"line_number":27,"context_line":"\t_x !\u003d 0 || (_x \u0026 (_x - 1)) \u003d\u003d 0;    \\"},{"line_number":28,"context_line":"})"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"#endif /* OPENOCD_HELPER_ALIGN_H */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"b394c0a7_a672117c","line":27,"in_reply_to":"6f8fb9d5_48c5fa42","updated":"2024-09-27 12:47:18.000000000","message":"Done🤦. Thank you for the catch.","commit_id":"33dc4dbe7ab83d2ef613452be99860ff8148d6d5"}]}
