)]}'
{"id":"openocd~master~I84d9f9c64c9a7df452ca6e99c2ee4169ccb2b0be","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001667":{"account":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"last_update":"2024-10-05 15:53:43.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-09-28 15:08:00.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}},"hashtags":[],"change_id":"I84d9f9c64c9a7df452ca6e99c2ee4169ccb2b0be","subject":"helper/align.h: Fix macro IS_PWR_OF_2","status":"MERGED","created":"2024-09-27 07:53:28.000000000","updated":"2024-10-05 15:53:43.000000000","submitted":"2024-10-05 15:53:43.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8511","meta_rev_id":"ca8cf3e461a86bf37630f93d15eb68515110a292","_number":8511,"owner":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-10-05 15:53:43.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-10-05 15:53:43.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-09-27 08:09:47.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-09-27 08:17:53.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2024-09-28 15:08:00.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"84ad4872a32f1c83cc0897ebd086406778596490","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2024-09-27 07:53:28.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"00c2daa3e1f7723706c764dc7b0b2332e0017ea9","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-09-27 08:09:47.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20044/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19199/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"ad2416255bb44d6c6a4542e56580935b062ffd62","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-09-27 08:17:53.000000000","message":"Patch Set 1:\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"2e3f9c4f4cf3c77aa657dfa015d998e5876c4208","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2024-09-27 12:44:55.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"d7c13dde23fb3c62400770d5c1541a8c175b07b1","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2024-09-27 12:47:18.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"2f3e8d7f807054c1898c8f861e8e8170484f740e","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-09-27 12:59:13.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20046/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19201/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"e43c0d4e09009208263a63c2429ea606b458a242","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-09-28 15:08:00.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"3489e9fffcdb2ef26b3198e916e8b5b415202579","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-10-05 15:53:39.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"ca8cf3e461a86bf37630f93d15eb68515110a292","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-10-05 15:53:43.000000000","message":"Change has been successfully cherry-picked as edf2c82cf615af4926cc3536bbbafce2c55fe4e0","accounts_in_message":[],"_revision_number":3}],"current_revision":"edf2c82cf615af4926cc3536bbbafce2c55fe4e0","revisions":{"60a438b6a269e0b6f23318d3a061f8c37266a128":{"kind":"REWORK","_number":2,"created":"2024-09-27 12:44:55.000000000","uploader":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"ref":"refs/changes/11/8511/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/11/8511/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/11/8511/2 \u0026\u0026 git checkout -b change-8511 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/11/8511/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/11/8511/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/11/8511/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/11/8511/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/11/8511/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ad216136180e0cd482f414eb072c9dd25dd1c559","subject":"server/telnet: Restructure commands"}],"author":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2024-09-27 07:49:52.000000000","tz":120},"committer":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2024-09-27 12:44:01.000000000","tz":120},"subject":"helper/align.h: Fix macro IS_PWR_OF_2","message":"helper/align.h: Fix macro IS_PWR_OF_2\n\nZero is not a power of two.\n\nAll functions that use IS_PWR_OF_2 were checked and the edge case\nof IS_PWR_OF_2(0) does not occur anywhere at the moment. Therefore\nthe fix is safe.\n\nChange-Id: I84d9f9c64c9a7df452ca6e99c2ee4169ccb2b0be\nSigned-off-by: Jan Matyas \u003cjan.matyas@codasip.com\u003e\nFixes: 9544cd653df1 (\"helper: add align.h\")\n"}},"edf2c82cf615af4926cc3536bbbafce2c55fe4e0":{"kind":"REWORK","_number":3,"created":"2024-10-05 15:53:43.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/11/8511/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/11/8511/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/11/8511/3 \u0026\u0026 git checkout -b change-8511 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/11/8511/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/11/8511/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/11/8511/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/11/8511/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/11/8511/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"30c3d077f281876286a7aa37afbd411d4bd1667e","subject":"jimtcl: update to version 0.83"}],"author":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2024-09-27 07:49:52.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-10-05 15:53:43.000000000","tz":0},"subject":"helper/align.h: Fix macro IS_PWR_OF_2","message":"helper/align.h: Fix macro IS_PWR_OF_2\n\nZero is not a power of two.\n\nAll functions that use IS_PWR_OF_2 were checked and the edge case\nof IS_PWR_OF_2(0) does not occur anywhere at the moment. Therefore\nthe fix is safe.\n\nChange-Id: I84d9f9c64c9a7df452ca6e99c2ee4169ccb2b0be\nSigned-off-by: Jan Matyas \u003cjan.matyas@codasip.com\u003e\nFixes: 9544cd653df1 (\"helper: add align.h\")\nReviewed-on: https://review.openocd.org/c/openocd/+/8511\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\n"}},"33dc4dbe7ab83d2ef613452be99860ff8148d6d5":{"kind":"REWORK","_number":1,"created":"2024-09-27 07:53:28.000000000","uploader":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"ref":"refs/changes/11/8511/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/11/8511/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/11/8511/1 \u0026\u0026 git checkout -b change-8511 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/11/8511/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/11/8511/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/11/8511/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/11/8511/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/11/8511/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ad216136180e0cd482f414eb072c9dd25dd1c559","subject":"server/telnet: Restructure commands"}],"author":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2024-09-27 07:49:52.000000000","tz":120},"committer":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2024-09-27 07:49:52.000000000","tz":120},"subject":"helper/align.h: Fix macro IS_PWR_OF_2","message":"helper/align.h: Fix macro IS_PWR_OF_2\n\nZero is not a power of two.\n\nAll functions that use IS_PWR_OF_2 were checked and the edge case\nof IS_PWR_OF_2(0) does not occur anywhere at the moment. Therefore\nthe fix is safe.\n\nChange-Id: I84d9f9c64c9a7df452ca6e99c2ee4169ccb2b0be\nSigned-off-by: Jan Matyas \u003cjan.matyas@codasip.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}