)]}'
{"id":"openocd~master~Ic81c9b273d7520f4d2d8c32bc3e0a6bcfffb67ed","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001415":{"account":{"_account_id":1001415,"name":"Jonathan McDowell","email":"noodles-openocd@earth.li","username":"u1f35c"},"last_update":"2024-10-05 15:52:26.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-09-28 16:14:38.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}},"hashtags":[],"change_id":"Ic81c9b273d7520f4d2d8c32bc3e0a6bcfffb67ed","subject":"openocd: fix build with jimtcl 0.83","status":"MERGED","created":"2024-09-27 20:44:59.000000000","updated":"2024-10-05 15:52:26.000000000","submitted":"2024-10-05 15:52:26.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8512","meta_rev_id":"6d8d5fc7fc9526c22170a5c30c8be2775ec4e298","_number":8512,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001415,"name":"Jonathan McDowell","email":"noodles-openocd@earth.li","username":"u1f35c"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-10-05 15:52:26.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-10-05 15:52:26.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001415,"name":"Jonathan McDowell","email":"noodles-openocd@earth.li","username":"u1f35c"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-10-05 15:52:26.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001415,"name":"Jonathan McDowell","email":"noodles-openocd@earth.li","username":"u1f35c"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-09-27 21:01:17.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-09-28 10:17:30.000000000","updated_by":{"_account_id":1001415,"name":"Jonathan McDowell","email":"noodles-openocd@earth.li","username":"u1f35c"},"reviewer":{"_account_id":1001415,"name":"Jonathan McDowell","email":"noodles-openocd@earth.li","username":"u1f35c"},"state":"REVIEWER"}],"messages":[{"id":"a3ae812e2c05ad3abbd161d1db2a116a5a03ec0d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-09-27 20:44:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"573b165b0223fbfbc0ee700fd50c6b4ae48eb2f3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-09-27 21:01:06.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"6801d34e3d7b858df1b08d1a6e9d0e2a56278e32","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-09-27 21:01:17.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/19202/ : ABORTED\n\nhttps://build.openocd.org/job/openocd-gerrit/20047/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"60eb8497be841642c261fbcfd42481dd885e8be1","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-09-27 21:53:42.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20049/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19204/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"daaf19318e393b0818d135175477b8fdd43a463f","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-09-27 22:00:12.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"4ca45ae4748b3f07e09b059072fcb5056f5458aa","author":{"_account_id":1001415,"name":"Jonathan McDowell","email":"noodles-openocd@earth.li","username":"u1f35c"},"real_author":{"_account_id":1001415,"name":"Jonathan McDowell","email":"noodles-openocd@earth.li","username":"u1f35c"},"date":"2024-09-28 10:17:30.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"ad40c8d9293d1f91813c8efd4336128f44deed8c","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-09-28 16:05:27.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"4814dc166004360e872922c579f4b8518b9e9390","author":{"_account_id":1001415,"name":"Jonathan McDowell","email":"noodles-openocd@earth.li","username":"u1f35c"},"real_author":{"_account_id":1001415,"name":"Jonathan McDowell","email":"noodles-openocd@earth.li","username":"u1f35c"},"date":"2024-09-28 16:09:17.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"2b67864cdab37d81ddb2551018a160afefdd262a","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-09-28 16:14:38.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"5371a47bb990dfb4e0ca50d8a049e2fb6e8a5ce7","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-10-05 15:52:22.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"6d8d5fc7fc9526c22170a5c30c8be2775ec4e298","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-10-05 15:52:26.000000000","message":"Change has been successfully cherry-picked as 73390332d203f02aa5b9798a7550191d55650d97","accounts_in_message":[],"_revision_number":3}],"current_revision":"73390332d203f02aa5b9798a7550191d55650d97","revisions":{"73390332d203f02aa5b9798a7550191d55650d97":{"kind":"REWORK","_number":3,"created":"2024-10-05 15:52:26.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/12/8512/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/12/8512/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/12/8512/3 \u0026\u0026 git checkout -b change-8512 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/12/8512/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/12/8512/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/12/8512/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/12/8512/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/12/8512/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"116e9553d12193faa08e668b3d9504ef995bd21f","subject":"openocd: build: allow more socket connections on Windows"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-09-27 20:36:52.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-10-05 15:52:26.000000000","tz":0},"subject":"openocd: fix build with jimtcl 0.83","message":"openocd: fix build with jimtcl 0.83\n\nIn jimtcl 0.82, the include file jim.h included in turn stdio.h\nThis made redundant to include the former in openocd source files.\nSince jimtcl 0.83, jim.h drops the include of stdio.h, causing\nopenocd build to fail.\n\nInclude stdio.h in the files that need it.\n\nChange-Id: Ic81c9b273d7520f4d2d8c32bc3e0a6bcfffb67ed\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8512\nReviewed-by: Jonathan McDowell \u003cnoodles-openocd@earth.li\u003e\nTested-by: jenkins\n"}},"c26ae1e98e2b292743146ad0fb286c3511f7c952":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2024-09-27 21:01:06.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/12/8512/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/12/8512/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/12/8512/2 \u0026\u0026 git checkout -b change-8512 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/12/8512/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/12/8512/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/12/8512/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/12/8512/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/12/8512/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ad216136180e0cd482f414eb072c9dd25dd1c559","subject":"server/telnet: Restructure commands"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-09-27 20:36:52.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-09-27 21:01:05.000000000","tz":0},"subject":"openocd: fix build with jimtcl 0.83","message":"openocd: fix build with jimtcl 0.83\n\nIn jimtcl 0.82, the include file jim.h included in turn stdio.h\nThis made redundant to include the former in openocd source files.\nSince jimtcl 0.83, jim.h drops the include of stdio.h, causing\nopenocd build to fail.\n\nInclude stdio.h in the files that need it.\n\nChange-Id: Ic81c9b273d7520f4d2d8c32bc3e0a6bcfffb67ed\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"},"description":"Edit commit message"},"81fb84ec812a4aacc86d65adea73e14d95933529":{"kind":"REWORK","_number":1,"created":"2024-09-27 20:44:59.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/12/8512/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/12/8512/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/12/8512/1 \u0026\u0026 git checkout -b change-8512 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/12/8512/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/12/8512/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/12/8512/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/12/8512/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/12/8512/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ad216136180e0cd482f414eb072c9dd25dd1c559","subject":"server/telnet: Restructure commands"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-09-27 20:36:52.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-09-27 20:44:21.000000000","tz":120},"subject":"openocd: fix build with jimtcl 0.83","message":"openocd: fix build with jimtcl 0.83\n\nIn jimtcl 0.82, the include file jim.h included in turn stdio.h\nThis made redundant to include the former in openocd source files.\nSince jimtcl 0.83, jim.h drops the include of stdio.h, causing\nopenocd build to fail.\n\nInclude stdio.h in the files than need it.\n\nChange-Id: Ic81c9b273d7520f4d2d8c32bc3e0a6bcfffb67ed\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}