)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"ed67505fc89bb04dfd8a3e6df4b817a175d06e7d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6c0e787e_4bd3329f","updated":"2024-09-30 19:56:46.000000000","message":"Thanks! Yes, we should replace the \u0027int\u0027 data type for trst/srst.","commit_id":"f201310224de44b8b000ab5dfaad8e1e9c471590"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c7bd65f1c243cb3ca29c6ffee0491102226668b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b9dffb52_56edb468","updated":"2024-10-20 09:32:59.000000000","message":"In last Patchset 5 you reverted to the Patchset 2, including typos. Patchset 3 was ok","commit_id":"7f4b8a4a23d295eaaed25e156f84e31149b69dbe"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"df2a09c4dc515294337db23676a9f734719f8417","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a0a1808c_09c43284","updated":"2024-10-26 14:13:42.000000000","message":"Still not correct!\nCompare 3 and latest\nhttps://review.openocd.org/c/openocd/+/8516/3..6/src/jtag/drivers/parport.c","commit_id":"75ac31857ba7b41a1d7d6468d5cd7a1ba21198ff"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"fb6cd485a78f7121a77935154ff0d31cacecd291","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"144f0f7c_f03c144d","updated":"2024-10-26 12:01:08.000000000","message":"Ups, that happens when you work on different machines :D Thanks and sorry for the noise!","commit_id":"75ac31857ba7b41a1d7d6468d5cd7a1ba21198ff"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"4b7bd63627c5e75aa3f5f818cf1e61703eb90bf1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"26cb8de3_0bec8b16","updated":"2024-10-26 16:26:22.000000000","message":":facepalm: ... obviously a brain fart on my side. I wonder why checkpatch did not recognize it.","commit_id":"f5ddab5f25c5c740d634aa0f9f520e2893f52460"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"358382197e955e15e4e916632ee5c10a18fb09c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"bf3bbf3a_74a48177","in_reply_to":"26cb8de3_0bec8b16","updated":"2024-10-27 10:46:37.000000000","message":"I\u0027m also questioning checkpatch! Don\u0027t know.","commit_id":"f5ddab5f25c5c740d634aa0f9f520e2893f52460"}],"src/jtag/drivers/parport.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"53a7252b14d0645e37863087a02a12b0de8dfd24","unresolved":true,"context_lines":[{"line_number":97,"context_line":"\t{ NULL,\t\t\t\t0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 }"},{"line_number":98,"context_line":"};"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"// Configuration varuables."},{"line_number":101,"context_line":"static char *parport_cable;"},{"line_number":102,"context_line":"static uint16_t parport_port;"},{"line_number":103,"context_line":"static bool parport_exit;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"69ad854d_ff6e455f","line":100,"updated":"2024-09-30 13:36:42.000000000","message":"typo s/varuables/variables/","commit_id":"2b543a80ee27c2835364b903f2c68e572858c7c6"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"ed67505fc89bb04dfd8a3e6df4b817a175d06e7d","unresolved":false,"context_lines":[{"line_number":97,"context_line":"\t{ NULL,\t\t\t\t0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 }"},{"line_number":98,"context_line":"};"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"// Configuration varuables."},{"line_number":101,"context_line":"static char *parport_cable;"},{"line_number":102,"context_line":"static uint16_t parport_port;"},{"line_number":103,"context_line":"static bool parport_exit;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"df16fa4a_30c38ce2","line":100,"in_reply_to":"69ad854d_ff6e455f","updated":"2024-09-30 19:56:46.000000000","message":"Done","commit_id":"2b543a80ee27c2835364b903f2c68e572858c7c6"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"53a7252b14d0645e37863087a02a12b0de8dfd24","unresolved":true,"context_lines":[{"line_number":177,"context_line":"{"},{"line_number":178,"context_line":"\tLOG_DEBUG(\"trst: %i, srst: %i\", trst, srst);"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"\tif (!trst)"},{"line_number":181,"context_line":"\t\tdataport_value |\u003d cable-\u003etrst_mask;"},{"line_number":182,"context_line":"\telse if (trst \u003d\u003d 1)"},{"line_number":183,"context_line":"\t\tdataport_value \u0026\u003d ~cable-\u003etrst_mask;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"2a3b61b3_d5283628","line":180,"updated":"2024-09-30 13:36:42.000000000","message":"In this specific case where we test `0` here and `1` few lines below, I think it is more readable keeping the original code.\n\nAs a general future improvement, I think we should change this.\nI haven\u0027t fully checked if we pass values other than `0` and `1`.\nIn case, either use an `enum` or a `bool` and for readability create symbols (enum or macro) for the two-or-more states.","commit_id":"2b543a80ee27c2835364b903f2c68e572858c7c6"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"ed67505fc89bb04dfd8a3e6df4b817a175d06e7d","unresolved":false,"context_lines":[{"line_number":177,"context_line":"{"},{"line_number":178,"context_line":"\tLOG_DEBUG(\"trst: %i, srst: %i\", trst, srst);"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"\tif (!trst)"},{"line_number":181,"context_line":"\t\tdataport_value |\u003d cable-\u003etrst_mask;"},{"line_number":182,"context_line":"\telse if (trst \u003d\u003d 1)"},{"line_number":183,"context_line":"\t\tdataport_value \u0026\u003d ~cable-\u003etrst_mask;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"bb0791d2_c0d3a8a7","line":180,"in_reply_to":"2a3b61b3_d5283628","updated":"2024-09-30 19:56:46.000000000","message":"Done","commit_id":"2b543a80ee27c2835364b903f2c68e572858c7c6"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"53a7252b14d0645e37863087a02a12b0de8dfd24","unresolved":true,"context_lines":[{"line_number":182,"context_line":"\telse if (trst \u003d\u003d 1)"},{"line_number":183,"context_line":"\t\tdataport_value \u0026\u003d ~cable-\u003etrst_mask;"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"\tif (!srst)"},{"line_number":186,"context_line":"\t\tdataport_value |\u003d cable-\u003esrst_mask;"},{"line_number":187,"context_line":"\telse if (srst \u003d\u003d 1)"},{"line_number":188,"context_line":"\t\tdataport_value \u0026\u003d ~cable-\u003esrst_mask;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"676093dc_ae161e6f","line":185,"updated":"2024-09-30 13:36:42.000000000","message":"same here","commit_id":"2b543a80ee27c2835364b903f2c68e572858c7c6"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"ed67505fc89bb04dfd8a3e6df4b817a175d06e7d","unresolved":false,"context_lines":[{"line_number":182,"context_line":"\telse if (trst \u003d\u003d 1)"},{"line_number":183,"context_line":"\t\tdataport_value \u0026\u003d ~cable-\u003etrst_mask;"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"\tif (!srst)"},{"line_number":186,"context_line":"\t\tdataport_value |\u003d cable-\u003esrst_mask;"},{"line_number":187,"context_line":"\telse if (srst \u003d\u003d 1)"},{"line_number":188,"context_line":"\t\tdataport_value \u0026\u003d ~cable-\u003esrst_mask;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"5f21cda2_698005f8","line":185,"in_reply_to":"676093dc_ae161e6f","updated":"2024-09-30 19:56:46.000000000","message":"Done","commit_id":"2b543a80ee27c2835364b903f2c68e572858c7c6"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"53a7252b14d0645e37863087a02a12b0de8dfd24","unresolved":true,"context_lines":[{"line_number":400,"context_line":"{"},{"line_number":401,"context_line":"\tif (CMD_ARGC \u003d\u003d 1) {"},{"line_number":402,"context_line":"\t\t// Only if the port wasn\u0027t overwritten by cmdline."},{"line_number":403,"context_line":"\t\tif (!parport_port)"},{"line_number":404,"context_line":"\t\t\tCOMMAND_PARSE_NUMBER(u16, CMD_ARGV[0], parport_port);"},{"line_number":405,"context_line":"\t\telse {"},{"line_number":406,"context_line":"\t\t\tLOG_ERROR(\"The parport port was already configured!\");"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"99bb710e_4e500eb2","line":403,"updated":"2024-09-30 13:36:42.000000000","message":"please balance the `{}` in the if/then/else\nStrange that checkpatch didn\u0027t triggered this!","commit_id":"2b543a80ee27c2835364b903f2c68e572858c7c6"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"ed67505fc89bb04dfd8a3e6df4b817a175d06e7d","unresolved":false,"context_lines":[{"line_number":400,"context_line":"{"},{"line_number":401,"context_line":"\tif (CMD_ARGC \u003d\u003d 1) {"},{"line_number":402,"context_line":"\t\t// Only if the port wasn\u0027t overwritten by cmdline."},{"line_number":403,"context_line":"\t\tif (!parport_port)"},{"line_number":404,"context_line":"\t\t\tCOMMAND_PARSE_NUMBER(u16, CMD_ARGV[0], parport_port);"},{"line_number":405,"context_line":"\t\telse {"},{"line_number":406,"context_line":"\t\t\tLOG_ERROR(\"The parport port was already configured!\");"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"c38e2176_488d3f55","line":403,"in_reply_to":"99bb710e_4e500eb2","updated":"2024-09-30 19:56:46.000000000","message":"Done","commit_id":"2b543a80ee27c2835364b903f2c68e572858c7c6"}]}