)]}'
{"id":"openocd~master~Idb62f57d37ed323c39de38982e57afdd3882e280","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001667":{"account":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"last_update":"2024-10-20 09:25:25.000000000","reason":"Change was submitted"},"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2024-10-20 09:25:25.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-10-09 08:18:12.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2024-10-20 09:25:25.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Idb62f57d37ed323c39de38982e57afdd3882e280","subject":"gdb_server: Improve const correctness","status":"MERGED","created":"2024-09-30 12:57:54.000000000","updated":"2024-10-20 09:25:25.000000000","submitted":"2024-10-20 09:25:25.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8517","meta_rev_id":"9a4cbb3798632fc8cf642907ba1bd93f612cd36d","_number":8517,"owner":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-10-20 09:25:25.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"value":0,"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-10-20 09:25:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-09-30 12:59:16.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-09-30 20:32:33.000000000","updated_by":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"reviewer":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"REVIEWER"},{"updated":"2024-10-01 04:03:21.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2024-10-07 21:04:06.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2024-10-09 08:18:12.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"98bae98f9ab34fc409a3d7daae1120fb20cd1625","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2024-09-30 12:57:54.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0a8f26d9de4e2a842cf0236dd64742bf5c6d8dd5","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-09-30 12:59:16.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/20056/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19211/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"70a9b2769e3a6f631832b894e230158e2ba0883f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2024-09-30 13:02:31.000000000","message":"Uploaded patch set 2: Commit message was updated.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"79e26b144fad94d5b54aaf9311dda258ba5da08d","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-09-30 13:03:19.000000000","message":"Patch Set 2: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/20057/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19212/ : FAILURE","accounts_in_message":[],"_revision_number":2},{"id":"8fd07f4de65691a2401236e4ddebc04708154483","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2024-09-30 13:03:54.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"7aed0d193c5e96ed8f86cc5044400a3caaccc663","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-09-30 14:05:15.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20058/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19213/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"c01a95bc1228bdc282f3b6915e249a598ef2a695","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2024-09-30 20:32:33.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"1696e7c2b2332e28f1a2c391fb46da00852c6f29","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-10-01 04:03:21.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"e3ceb435232a004a9fb162abbd7aec5604e55485","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2024-10-07 05:17:21.000000000","message":"Uploaded patch set 4.\n\nOutdated Votes:\n* Code-Review+1, Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":4},{"id":"62b25389463f7944d504d8d2549067693a244ef2","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2024-10-07 05:18:40.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"f727ee61b46d9c3932791972f54cd86c309c0e7a","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-10-07 06:01:33.000000000","message":"Patch Set 4: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20067/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19222/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"f040dd00714203abe099c3922007e91530fd56eb","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-10-07 21:04:06.000000000","message":"Patch Set 4:\n\n(2 comments)","accounts_in_message":[],"_revision_number":4},{"id":"c4c5b6a2e7d55b40e2f11c144a7d91426bcf1ef8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2024-10-09 07:37:14.000000000","message":"Uploaded patch set 5: Commit message was updated.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":5},{"id":"c850e3f70a1f2ad548a676c1ab7960b89bc6cda1","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2024-10-09 07:37:48.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"dc449357acccdb8acc95e5c08a4b10025a1caac4","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-10-09 07:50:44.000000000","message":"Patch Set 5: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20075/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19230/ : SUCCESS","accounts_in_message":[],"_revision_number":5},{"id":"b3c72aa3a05073b2ff04a1fd05f06654e66a4881","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-10-09 08:18:12.000000000","message":"Patch Set 5: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"55b3266ac86ad6d193fc0b5c7c46866f4c6e8e89","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-10-20 09:25:20.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"9a4cbb3798632fc8cf642907ba1bd93f612cd36d","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-10-20 09:25:25.000000000","message":"Change has been successfully cherry-picked as d09ff476446a5403e556476b41a5a3c9bdf0a706","accounts_in_message":[],"_revision_number":6}],"current_revision":"d09ff476446a5403e556476b41a5a3c9bdf0a706","revisions":{"010b24af335d6bc872c4cf80dda880fb465aba6c":{"kind":"REWORK","_number":1,"created":"2024-09-30 12:57:54.000000000","uploader":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"ref":"refs/changes/17/8517/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/17/8517/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/17/8517/1 \u0026\u0026 git checkout -b change-8517 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/17/8517/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/17/8517/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/17/8517/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/17/8517/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/17/8517/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"33dc4dbe7ab83d2ef613452be99860ff8148d6d5","subject":"helper/align.h: Fix macro IS_PWR_OF_2"}],"author":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2024-09-30 12:55:58.000000000","tz":120},"committer":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2024-09-30 12:55:58.000000000","tz":120},"subject":"gdb_server: Improve const correctness","message":"gdb_server: Improve const correctness\n\nOn several packat-handling functions, add \"const\" to arguments\nthat represent read-only packet buffers.\n\nChange-Id: Idb62f57d37ed323c39de38982e57afdd3882e280\nSigned-off-by: Jan Matyas \u003cjan.matyas@codasip.com\u003e\n"}},"b50c45a494bcbc25af2dd5a814f09dfc5bb42b85":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2024-09-30 13:02:31.000000000","uploader":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"ref":"refs/changes/17/8517/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/17/8517/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/17/8517/2 \u0026\u0026 git checkout -b change-8517 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/17/8517/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/17/8517/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/17/8517/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/17/8517/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/17/8517/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"33dc4dbe7ab83d2ef613452be99860ff8148d6d5","subject":"helper/align.h: Fix macro IS_PWR_OF_2"}],"author":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2024-09-30 12:55:58.000000000","tz":120},"committer":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2024-09-30 12:58:07.000000000","tz":120},"subject":"gdb_server: Improve const correctness","message":"gdb_server: Improve const correctness\n\nOn several packat-handling functions, add \"const\" to arguments\nthat represent read-only packet buffers.\n\nFor instance on GCC 13.2.0, this code:\n\nconst char *some_packet \u003d \"...\";\ngdb_put_packet(conn, some_packet, strlen(some_packet));\n\nwould prior to the fix produce warning:\n\npassing argument 2 of ‘gdb_put_packet’ discards ‘const’\nqualifier from pointer target type [-Wdiscarded-qualifiers]\n\nChange-Id: Idb62f57d37ed323c39de38982e57afdd3882e280\nSigned-off-by: Jan Matyas \u003cjan.matyas@codasip.com\u003e\n"}},"35d428ace438df30fcead50f322da4f8bdb66f3a":{"kind":"REWORK","_number":3,"created":"2024-09-30 13:03:54.000000000","uploader":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"ref":"refs/changes/17/8517/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/17/8517/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/17/8517/3 \u0026\u0026 git checkout -b change-8517 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/17/8517/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/17/8517/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/17/8517/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/17/8517/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/17/8517/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"33dc4dbe7ab83d2ef613452be99860ff8148d6d5","subject":"helper/align.h: Fix macro IS_PWR_OF_2"}],"author":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2024-09-30 12:55:58.000000000","tz":120},"committer":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2024-09-30 13:03:49.000000000","tz":120},"subject":"gdb_server: Improve const correctness","message":"gdb_server: Improve const correctness\n\nOn several packat-handling functions, add \"const\" to arguments\nthat represent read-only packet buffers.\n\nFor instance on GCC 13.2.0, this code:\n\nconst char *some_packet \u003d \"...\";\ngdb_put_packet(conn, some_packet, strlen(some_packet));\n\nwould prior to the fix produce warning:\n\npassing argument 2 of ‘gdb_put_packet’ discards ‘const’\nqualifier from pointer target type [-Wdiscarded-qualifiers]\n\nChange-Id: Idb62f57d37ed323c39de38982e57afdd3882e280\nSigned-off-by: Jan Matyas \u003cjan.matyas@codasip.com\u003e\n"}},"bdba1a4a86f90feae50357987d3796dd1062ec17":{"kind":"REWORK","_number":4,"created":"2024-10-07 05:17:21.000000000","uploader":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"ref":"refs/changes/17/8517/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/17/8517/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/17/8517/4 \u0026\u0026 git checkout -b change-8517 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/17/8517/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/17/8517/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/17/8517/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/17/8517/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/17/8517/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"edf2c82cf615af4926cc3536bbbafce2c55fe4e0","subject":"helper/align.h: Fix macro IS_PWR_OF_2"}],"author":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2024-09-30 12:55:58.000000000","tz":120},"committer":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2024-10-07 05:16:15.000000000","tz":120},"subject":"gdb_server: Improve const correctness","message":"gdb_server: Improve const correctness\n\nOn several packat-handling functions, add \"const\" to arguments\nthat represent read-only packet buffers.\n\nFor instance on GCC 13.2.0, this code:\n\nconst char *some_packet \u003d \"...\";\ngdb_put_packet(conn, some_packet, strlen(some_packet));\n\nwould prior to the fix produce warning:\n\npassing argument 2 of ‘gdb_put_packet’ discards ‘const’\nqualifier from pointer target type [-Wdiscarded-qualifiers]\n\nChange-Id: Idb62f57d37ed323c39de38982e57afdd3882e280\nSigned-off-by: Jan Matyas \u003cjan.matyas@codasip.com\u003e\n"}},"2e77f27a386a1a4582ca826d37069250162214a7":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2024-10-09 07:37:14.000000000","uploader":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"ref":"refs/changes/17/8517/5","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/17/8517/5","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/17/8517/5 \u0026\u0026 git checkout -b change-8517 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/17/8517/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/17/8517/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/17/8517/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/17/8517/5","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/17/8517/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"edf2c82cf615af4926cc3536bbbafce2c55fe4e0","subject":"helper/align.h: Fix macro IS_PWR_OF_2"}],"author":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2024-09-30 12:55:58.000000000","tz":120},"committer":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2024-10-09 07:36:45.000000000","tz":120},"subject":"gdb_server: Improve const correctness","message":"gdb_server: Improve const correctness\n\nOn several packet-handling functions, add \"const\" to arguments\nthat represent read-only packet buffers.\n\nFor instance on GCC 13.2.0, this code:\n\nconst char *some_packet \u003d \"...\";\ngdb_put_packet(conn, some_packet, strlen(some_packet));\n\nwould prior to the fix produce warning:\n\npassing argument 2 of ‘gdb_put_packet’ discards ‘const’\nqualifier from pointer target type [-Wdiscarded-qualifiers]\n\nChange-Id: Idb62f57d37ed323c39de38982e57afdd3882e280\nSigned-off-by: Jan Matyas \u003cjan.matyas@codasip.com\u003e\n"}},"d09ff476446a5403e556476b41a5a3c9bdf0a706":{"kind":"REWORK","_number":6,"created":"2024-10-20 09:25:25.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/17/8517/6","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/17/8517/6","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/17/8517/6 \u0026\u0026 git checkout -b change-8517 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/17/8517/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/17/8517/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/17/8517/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/17/8517/6","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/17/8517/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"114ca19f64d8af5365ecf171cc2adc45a763a406","subject":"gitignore: Start ignoring \".vscode\""}],"author":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2024-09-30 12:55:58.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-10-20 09:25:25.000000000","tz":0},"subject":"gdb_server: Improve const correctness","message":"gdb_server: Improve const correctness\n\nOn several packet-handling functions, add \"const\" to arguments\nthat represent read-only packet buffers.\n\nFor instance on GCC 13.2.0, this code:\n\nconst char *some_packet \u003d \"...\";\ngdb_put_packet(conn, some_packet, strlen(some_packet));\n\nwould prior to the fix produce warning:\n\npassing argument 2 of ‘gdb_put_packet’ discards ‘const’\nqualifier from pointer target type [-Wdiscarded-qualifiers]\n\nChange-Id: Idb62f57d37ed323c39de38982e57afdd3882e280\nSigned-off-by: Jan Matyas \u003cjan.matyas@codasip.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8517\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}