)]}'
{"id":"openocd~master~I99366bb03cd3b83f8f408514e657f30e59813063","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001874":{"account":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"last_update":"2024-10-21 11:27:02.000000000","reason":"\u003cGERRIT_ACCOUNT_1001874\u003e replied on the change","reason_account":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"}},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-12-31 14:45:11.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}},"hashtags":[],"change_id":"I99366bb03cd3b83f8f408514e657f30e59813063","subject":"stlink: deprecate HLA support","status":"MERGED","created":"2024-10-12 14:47:04.000000000","updated":"2024-12-31 16:35:41.000000000","submitted":"2024-11-02 21:01:07.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":7,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8523","meta_rev_id":"07ac8e9c33343f8d61bea96167a0454a94e46df0","_number":8523,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-11-02 21:01:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-11-02 21:01:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-11-02 21:01:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"}],"CC":[{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-10-12 15:01:36.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-10-18 08:40:12.000000000","updated_by":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"reviewer":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"state":"CC"},{"updated":"2024-10-22 19:56:41.000000000","updated_by":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"reviewer":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"state":"REVIEWER"},{"updated":"2024-12-31 11:25:27.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"CC"}],"messages":[{"id":"4b4e7d2dbb67b0d7aaf1dd3c0021561d24b71406","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-10-12 14:47:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d19e3077726edd84ce23be46f856dee5f5603ea4","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-10-12 15:01:36.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20082/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19237/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"5328a3336bae5de5e033c96b3fb3b0418d5f4697","author":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"real_author":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"date":"2024-10-18 08:40:12.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"3e28f830d0e277d80fd7b99e5dafae30d682fc39","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-10-19 19:28:28.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"312b8ee487c3678ccaeb4d6a456698fa1bb25061","author":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"real_author":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"date":"2024-10-21 11:27:02.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e27f3d38b210eac84940f2daa11f5d458cdf1cba","author":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"real_author":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"date":"2024-10-22 19:56:41.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"4aac1e4540591a1b923383364d0123dc4423e379","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-11-02 21:00:58.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"a7c21c26ccf5933d5b708bdf3bff22c50d0f21cd","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-11-02 21:01:07.000000000","message":"Change has been successfully cherry-picked as 34ec5536c0ba3315bc5a841244bbf70141ccfbb4","accounts_in_message":[],"_revision_number":2},{"id":"5395e6eeafb827c1d962615fced177d7427cdf0c","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-12-31 11:25:27.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"894cb37b2c3689dc63b13ea29fce3de5c5fa3e7c","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-12-31 14:45:11.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"07ac8e9c33343f8d61bea96167a0454a94e46df0","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-12-31 16:35:41.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2}],"current_revision":"34ec5536c0ba3315bc5a841244bbf70141ccfbb4","revisions":{"34ec5536c0ba3315bc5a841244bbf70141ccfbb4":{"kind":"REWORK","_number":2,"created":"2024-11-02 21:01:07.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/23/8523/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/23/8523/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/23/8523/2 \u0026\u0026 git checkout -b change-8523 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/23/8523/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/23/8523/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/23/8523/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/23/8523/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/23/8523/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3ce0962f2c525595bcbd0bd5da73673e236fc42d","subject":"target: cortex_m: fix polling for target kept under reset"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-10-12 09:48:05.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-11-02 21:01:07.000000000","tz":0},"subject":"stlink: deprecate HLA support","message":"stlink: deprecate HLA support\n\nThe STLink API that supports dap-direct is available from STLink\nfirmware v2j24, published in early 2015.\nWe can reasonably expect that any old STLink still in use today\nhas got at least one firmware update during the last 10 years.\n\nMost of the board files in upstream OpenOCD still use the STLink\nin HLA mode. This limits the test coverage of the dap-direct code,\nwhich was introduced in OpenOCD v0.11.0.\n\n- Rename interface/stlink.cfg as interface/stlink-hla.cfg to still\n  provide support for HLA, adding a deprecated message.\n\n- Rename interface/stlink-dap.cfg as interface/stlink.cfg to make\n  dap-direct the default trasport.\n\n- Add a redirect file interface/stlink-dap.cfg for users that have\n  out-of-tree custom board files.\n\n- Update all the board files to the new setup.\n\n- Remove STLink HLA mentions from the documentation, while adding\n  a reference to interface/stlink-hla.cfg\n\nCheckpatch-ignore: LONG_LINE\nChange-Id: I99366bb03cd3b83f8f408514e657f30e59813063\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8523\nTested-by: jenkins\nReviewed-by: Andrzej Sierżęga \u003casier70@gmail.com\u003e\n"}},"a908e37f27a4b39ba9d06e5a135ad15e01be58fa":{"kind":"REWORK","_number":1,"created":"2024-10-12 14:47:04.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/23/8523/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/23/8523/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/23/8523/1 \u0026\u0026 git checkout -b change-8523 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/23/8523/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/23/8523/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/23/8523/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/23/8523/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/23/8523/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"edf2c82cf615af4926cc3536bbbafce2c55fe4e0","subject":"helper/align.h: Fix macro IS_PWR_OF_2"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-10-12 09:48:05.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-10-12 14:46:11.000000000","tz":120},"subject":"stlink: deprecate HLA support","message":"stlink: deprecate HLA support\n\nThe STLink API that supports dap-direct is available from STLink\nfirmware v2j24, published in early 2015.\nWe can reasonably expect that any old STLink still in use today\nhas got at least one firmware update during the last 10 years.\n\nMost of the board files in upstream OpenOCD still use the STLink\nin HLA mode. This limits the test coverage of the dap-direct code,\nwhich was introduced in OpenOCD v0.11.0.\n\n- Rename interface/stlink.cfg as interface/stlink-hla.cfg to still\n  provide support for HLA, adding a deprecated message.\n\n- Rename interface/stlink-dap.cfg as interface/stlink.cfg to make\n  dap-direct the default trasport.\n\n- Add a redirect file interface/stlink-dap.cfg for users that have\n  out-of-tree custom board files.\n\n- Update all the board files to the new setup.\n\n- Remove STLink HLA mentions from the documentation, while adding\n  a reference to interface/stlink-hla.cfg\n\nCheckpatch-ignore: LONG_LINE\nChange-Id: I99366bb03cd3b83f8f408514e657f30e59813063\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}