)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"030c6334eb95685c99738ffe302ac4ae0efb168e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"08fcc3bb_1fd8da45","updated":"2024-10-13 15:34:39.000000000","message":"Added Tomas. There is something not clear. Please check the few comments below.\nApparently the second parameter of `target_step()` is intended to be an `enum` with values `0, 1, 2`.","commit_id":"0aa6e3773bc8496b706b8ef9d4a873274d5fe4d0"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"73fe92e89fdf4ef1532f6ed0f22965c58f9a1111","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"01757049_c651b1f2","updated":"2024-12-10 10:50:50.000000000","message":"Let\u0027s try if Matthias could explain `current_pc` states.","commit_id":"3968fe9f442ad37da3979323f857da48122acd52"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f635f00fa73eba238bc8dd6d2dccce286a2bccc4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9e56880e_9bd897e5","updated":"2024-10-28 15:49:52.000000000","message":"Tomas, any hint to my previous comments?","commit_id":"3968fe9f442ad37da3979323f857da48122acd52"}],"src/server/gdb_server.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"030c6334eb95685c99738ffe302ac4ae0efb168e","unresolved":true,"context_lines":[{"line_number":3031,"context_line":"\t\tbool fake_step \u003d false;"},{"line_number":3032,"context_line":""},{"line_number":3033,"context_line":"\t\tstruct target *ct \u003d target;"},{"line_number":3034,"context_line":"\t\tint current_pc \u003d 1;"},{"line_number":3035,"context_line":"\t\tint64_t thread_id;"},{"line_number":3036,"context_line":"\t\tparse++;"},{"line_number":3037,"context_line":"\t\tif (parse[0] \u003d\u003d \u0027:\u0027) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"a02ec59e_ec9ef09d","line":3034,"updated":"2024-10-13 15:34:39.000000000","message":"Here `current_pc` is declared as `int`","commit_id":"0aa6e3773bc8496b706b8ef9d4a873274d5fe4d0"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9bed39a7317e032f4c77f9d5799a3d49cd674d3e","unresolved":false,"context_lines":[{"line_number":3031,"context_line":"\t\tbool fake_step \u003d false;"},{"line_number":3032,"context_line":""},{"line_number":3033,"context_line":"\t\tstruct target *ct \u003d target;"},{"line_number":3034,"context_line":"\t\tint current_pc \u003d 1;"},{"line_number":3035,"context_line":"\t\tint64_t thread_id;"},{"line_number":3036,"context_line":"\t\tparse++;"},{"line_number":3037,"context_line":"\t\tif (parse[0] \u003d\u003d \u0027:\u0027) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"78db4d85_c4a23b31","line":3034,"in_reply_to":"850227de_e6636d66","updated":"2025-02-21 10:16:19.000000000","message":"Done","commit_id":"0aa6e3773bc8496b706b8ef9d4a873274d5fe4d0"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"3524120f9e2ab4b05158b487b3993af64a4c1c92","unresolved":true,"context_lines":[{"line_number":3031,"context_line":"\t\tbool fake_step \u003d false;"},{"line_number":3032,"context_line":""},{"line_number":3033,"context_line":"\t\tstruct target *ct \u003d target;"},{"line_number":3034,"context_line":"\t\tint current_pc \u003d 1;"},{"line_number":3035,"context_line":"\t\tint64_t thread_id;"},{"line_number":3036,"context_line":"\t\tparse++;"},{"line_number":3037,"context_line":"\t\tif (parse[0] \u003d\u003d \u0027:\u0027) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"850227de_e6636d66","line":3034,"in_reply_to":"a02ec59e_ec9ef09d","updated":"2024-10-13 16:37:18.000000000","message":"Good catch, let\u0027s wait until Tomas responds.","commit_id":"0aa6e3773bc8496b706b8ef9d4a873274d5fe4d0"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"030c6334eb95685c99738ffe302ac4ae0efb168e","unresolved":true,"context_lines":[{"line_number":3083,"context_line":"\t\t\t\t\t\t */"},{"line_number":3084,"context_line":"\t\t\t\t\t\tLOG_DEBUG(\"request to step current core only\");"},{"line_number":3085,"context_line":"\t\t\t\t\t\t/* uncomment after checking that indeed other targets are safe */"},{"line_number":3086,"context_line":"\t\t\t\t\t\t/*current_pc \u003d 2;*/"},{"line_number":3087,"context_line":"\t\t\t\t\t}"},{"line_number":3088,"context_line":"\t\t\t\t}"},{"line_number":3089,"context_line":"\t\t\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"a3611731_bb7eb327","line":3086,"updated":"2024-10-13 15:34:39.000000000","message":"This is strange!\n\nTomas,\nthis comes from your commit https://review.openocd.org/4432\nIs there something you planned to do that is not broken by this new commit ?","commit_id":"0aa6e3773bc8496b706b8ef9d4a873274d5fe4d0"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9bed39a7317e032f4c77f9d5799a3d49cd674d3e","unresolved":true,"context_lines":[{"line_number":3083,"context_line":"\t\t\t\t\t\t */"},{"line_number":3084,"context_line":"\t\t\t\t\t\tLOG_DEBUG(\"request to step current core only\");"},{"line_number":3085,"context_line":"\t\t\t\t\t\t/* uncomment after checking that indeed other targets are safe */"},{"line_number":3086,"context_line":"\t\t\t\t\t\t/*current_pc \u003d 2;*/"},{"line_number":3087,"context_line":"\t\t\t\t\t}"},{"line_number":3088,"context_line":"\t\t\t\t}"},{"line_number":3089,"context_line":"\t\t\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"4b8fd582_0ccf17f2","line":3086,"in_reply_to":"12db11be_cf1a87e0","updated":"2025-02-21 10:16:19.000000000","message":"Should we keep this comment as is?\nMaybe in another patch, not in this huge one, and explain why in the commit message.","commit_id":"0aa6e3773bc8496b706b8ef9d4a873274d5fe4d0"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"e44298adb71e7a50f4483a1902f4888b8bdcc993","unresolved":true,"context_lines":[{"line_number":3083,"context_line":"\t\t\t\t\t\t */"},{"line_number":3084,"context_line":"\t\t\t\t\t\tLOG_DEBUG(\"request to step current core only\");"},{"line_number":3085,"context_line":"\t\t\t\t\t\t/* uncomment after checking that indeed other targets are safe */"},{"line_number":3086,"context_line":"\t\t\t\t\t\t/*current_pc \u003d 2;*/"},{"line_number":3087,"context_line":"\t\t\t\t\t}"},{"line_number":3088,"context_line":"\t\t\t\t}"},{"line_number":3089,"context_line":"\t\t\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"12db11be_cf1a87e0","line":3086,"in_reply_to":"2063cc6d_fa209625","updated":"2025-01-25 17:19:37.000000000","message":"Yup, we at least tried. No objections.","commit_id":"0aa6e3773bc8496b706b8ef9d4a873274d5fe4d0"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"7039f3c6e33cf6f1298fadbf301ffe194adbc149","unresolved":false,"context_lines":[{"line_number":3083,"context_line":"\t\t\t\t\t\t */"},{"line_number":3084,"context_line":"\t\t\t\t\t\tLOG_DEBUG(\"request to step current core only\");"},{"line_number":3085,"context_line":"\t\t\t\t\t\t/* uncomment after checking that indeed other targets are safe */"},{"line_number":3086,"context_line":"\t\t\t\t\t\t/*current_pc \u003d 2;*/"},{"line_number":3087,"context_line":"\t\t\t\t\t}"},{"line_number":3088,"context_line":"\t\t\t\t}"},{"line_number":3089,"context_line":"\t\t\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"3583b6dc_b0e8e675","line":3086,"in_reply_to":"4b8fd582_0ccf17f2","updated":"2025-02-21 10:58:54.000000000","message":"Yes, let\u0027s keep this comment as is for now.","commit_id":"0aa6e3773bc8496b706b8ef9d4a873274d5fe4d0"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"573d327e4722492a1ca93ff9ea50fbdca8d335e7","unresolved":true,"context_lines":[{"line_number":3083,"context_line":"\t\t\t\t\t\t */"},{"line_number":3084,"context_line":"\t\t\t\t\t\tLOG_DEBUG(\"request to step current core only\");"},{"line_number":3085,"context_line":"\t\t\t\t\t\t/* uncomment after checking that indeed other targets are safe */"},{"line_number":3086,"context_line":"\t\t\t\t\t\t/*current_pc \u003d 2;*/"},{"line_number":3087,"context_line":"\t\t\t\t\t}"},{"line_number":3088,"context_line":"\t\t\t\t}"},{"line_number":3089,"context_line":"\t\t\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"2063cc6d_fa209625","line":3086,"in_reply_to":"6c0bdbed_98d4e089","updated":"2025-01-25 15:57:28.000000000","message":"I don\u0027t expect an answer from Matthias soon. Merge?","commit_id":"0aa6e3773bc8496b706b8ef9d4a873274d5fe4d0"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"3524120f9e2ab4b05158b487b3993af64a4c1c92","unresolved":true,"context_lines":[{"line_number":3083,"context_line":"\t\t\t\t\t\t */"},{"line_number":3084,"context_line":"\t\t\t\t\t\tLOG_DEBUG(\"request to step current core only\");"},{"line_number":3085,"context_line":"\t\t\t\t\t\t/* uncomment after checking that indeed other targets are safe */"},{"line_number":3086,"context_line":"\t\t\t\t\t\t/*current_pc \u003d 2;*/"},{"line_number":3087,"context_line":"\t\t\t\t\t}"},{"line_number":3088,"context_line":"\t\t\t\t}"},{"line_number":3089,"context_line":"\t\t\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"fc71b214_5212d419","line":3086,"in_reply_to":"a3611731_bb7eb327","updated":"2024-10-13 16:37:18.000000000","message":"Hm, the patch is 6 years old and the entire target code treats `current_pc` like a `bool`. I would suggest to change it to `bool`. If we need a new feature like stepping a single threat, we change it to an `enum`.","commit_id":"0aa6e3773bc8496b706b8ef9d4a873274d5fe4d0"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"73fe92e89fdf4ef1532f6ed0f22965c58f9a1111","unresolved":true,"context_lines":[{"line_number":3083,"context_line":"\t\t\t\t\t\t */"},{"line_number":3084,"context_line":"\t\t\t\t\t\tLOG_DEBUG(\"request to step current core only\");"},{"line_number":3085,"context_line":"\t\t\t\t\t\t/* uncomment after checking that indeed other targets are safe */"},{"line_number":3086,"context_line":"\t\t\t\t\t\t/*current_pc \u003d 2;*/"},{"line_number":3087,"context_line":"\t\t\t\t\t}"},{"line_number":3088,"context_line":"\t\t\t\t}"},{"line_number":3089,"context_line":"\t\t\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"6c0bdbed_98d4e089","line":3086,"in_reply_to":"cac08a68_803c4d00","updated":"2024-12-10 10:50:50.000000000","message":"The tri-state `current_pc` stuff is not mine, it uploaded Matthias Welwarsky.\nSee https://review.openocd.org/c/openocd/+/4432/comment/ee875fcf_413e3228/","commit_id":"0aa6e3773bc8496b706b8ef9d4a873274d5fe4d0"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f635f00fa73eba238bc8dd6d2dccce286a2bccc4","unresolved":true,"context_lines":[{"line_number":3083,"context_line":"\t\t\t\t\t\t */"},{"line_number":3084,"context_line":"\t\t\t\t\t\tLOG_DEBUG(\"request to step current core only\");"},{"line_number":3085,"context_line":"\t\t\t\t\t\t/* uncomment after checking that indeed other targets are safe */"},{"line_number":3086,"context_line":"\t\t\t\t\t\t/*current_pc \u003d 2;*/"},{"line_number":3087,"context_line":"\t\t\t\t\t}"},{"line_number":3088,"context_line":"\t\t\t\t}"},{"line_number":3089,"context_line":"\t\t\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"cac08a68_803c4d00","line":3086,"in_reply_to":"fc71b214_5212d419","updated":"2024-10-28 15:49:52.000000000","message":"And should we keep this comment that assigns 2 to a bool?","commit_id":"0aa6e3773bc8496b706b8ef9d4a873274d5fe4d0"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"030c6334eb95685c99738ffe302ac4ae0efb168e","unresolved":true,"context_lines":[{"line_number":3129,"context_line":"\t\t\treturn true;"},{"line_number":3130,"context_line":"\t\t}"},{"line_number":3131,"context_line":""},{"line_number":3132,"context_line":"\t\tretval \u003d target_step(ct, current_pc, 0, false);"},{"line_number":3133,"context_line":"\t\tif (retval \u003d\u003d ERROR_TARGET_NOT_HALTED)"},{"line_number":3134,"context_line":"\t\t\tLOG_TARGET_INFO(ct, \"target was not halted when step was requested\");"},{"line_number":3135,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"9fccab91_19febad0","line":3132,"updated":"2024-10-13 15:34:39.000000000","message":"Also `current_pc` should be a bool!","commit_id":"0aa6e3773bc8496b706b8ef9d4a873274d5fe4d0"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9bed39a7317e032f4c77f9d5799a3d49cd674d3e","unresolved":false,"context_lines":[{"line_number":3129,"context_line":"\t\t\treturn true;"},{"line_number":3130,"context_line":"\t\t}"},{"line_number":3131,"context_line":""},{"line_number":3132,"context_line":"\t\tretval \u003d target_step(ct, current_pc, 0, false);"},{"line_number":3133,"context_line":"\t\tif (retval \u003d\u003d ERROR_TARGET_NOT_HALTED)"},{"line_number":3134,"context_line":"\t\t\tLOG_TARGET_INFO(ct, \"target was not halted when step was requested\");"},{"line_number":3135,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"4432a6d5_a18f437e","line":3132,"in_reply_to":"0b350d47_a4cda748","updated":"2025-02-21 10:16:19.000000000","message":"Done","commit_id":"0aa6e3773bc8496b706b8ef9d4a873274d5fe4d0"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"3524120f9e2ab4b05158b487b3993af64a4c1c92","unresolved":true,"context_lines":[{"line_number":3129,"context_line":"\t\t\treturn true;"},{"line_number":3130,"context_line":"\t\t}"},{"line_number":3131,"context_line":""},{"line_number":3132,"context_line":"\t\tretval \u003d target_step(ct, current_pc, 0, false);"},{"line_number":3133,"context_line":"\t\tif (retval \u003d\u003d ERROR_TARGET_NOT_HALTED)"},{"line_number":3134,"context_line":"\t\t\tLOG_TARGET_INFO(ct, \"target was not halted when step was requested\");"},{"line_number":3135,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"0b350d47_a4cda748","line":3132,"in_reply_to":"9fccab91_19febad0","updated":"2024-10-13 16:37:18.000000000","message":"This one is fixed by fixing your comment above, no?","commit_id":"0aa6e3773bc8496b706b8ef9d4a873274d5fe4d0"}],"src/target/aarch64.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"030c6334eb95685c99738ffe302ac4ae0efb168e","unresolved":true,"context_lines":[{"line_number":774,"context_line":""},{"line_number":775,"context_line":"\t\t/*  resume at current address, not in step mode */"},{"line_number":776,"context_line":"\t\tretval \u003d aarch64_restore_one(curr, true, \u0026address, handle_breakpoints,"},{"line_number":777,"context_line":"\t\t\tfalse);"},{"line_number":778,"context_line":"\t\tif (retval \u003d\u003d ERROR_OK)"},{"line_number":779,"context_line":"\t\t\tretval \u003d aarch64_prepare_restart_one(curr);"},{"line_number":780,"context_line":"\t\tif (retval !\u003d ERROR_OK) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"72b8f3fb_4a704175","line":777,"updated":"2024-10-13 15:34:39.000000000","message":"no need for newline!","commit_id":"0aa6e3773bc8496b706b8ef9d4a873274d5fe4d0"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f635f00fa73eba238bc8dd6d2dccce286a2bccc4","unresolved":true,"context_lines":[{"line_number":774,"context_line":""},{"line_number":775,"context_line":"\t\t/*  resume at current address, not in step mode */"},{"line_number":776,"context_line":"\t\tretval \u003d aarch64_restore_one(curr, true, \u0026address, handle_breakpoints,"},{"line_number":777,"context_line":"\t\t\tfalse);"},{"line_number":778,"context_line":"\t\tif (retval \u003d\u003d ERROR_OK)"},{"line_number":779,"context_line":"\t\t\tretval \u003d aarch64_prepare_restart_one(curr);"},{"line_number":780,"context_line":"\t\tif (retval !\u003d ERROR_OK) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"5eca55f9_0b0dfc56","line":777,"in_reply_to":"3f896454_51dd0722","updated":"2024-10-28 15:49:52.000000000","message":"Our coding style reports 120 chars, even if gerrit breaks the line well before that.\nI stick to `vim`, old habits are hard to change!","commit_id":"0aa6e3773bc8496b706b8ef9d4a873274d5fe4d0"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a4431a6bd49e4ad7129e207eeb234738e7b41eb8","unresolved":false,"context_lines":[{"line_number":774,"context_line":""},{"line_number":775,"context_line":"\t\t/*  resume at current address, not in step mode */"},{"line_number":776,"context_line":"\t\tretval \u003d aarch64_restore_one(curr, true, \u0026address, handle_breakpoints,"},{"line_number":777,"context_line":"\t\t\tfalse);"},{"line_number":778,"context_line":"\t\tif (retval \u003d\u003d ERROR_OK)"},{"line_number":779,"context_line":"\t\t\tretval \u003d aarch64_prepare_restart_one(curr);"},{"line_number":780,"context_line":"\t\tif (retval !\u003d ERROR_OK) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"bb60649c_9117ba71","line":777,"in_reply_to":"448fcda2_b0e84b31","updated":"2024-11-11 17:45:07.000000000","message":"Thanks for pointing it.\nI remember we changed the line length check in checkpatch to 120, but I forgot it was for exceptions only.\nNow that we can add in the commit message the checkpatch exception\n`Checkpatch-ignore: LONG_LINE`\nI think we could return to default checkpatch line length 80 and handle the exceptions case by case","commit_id":"0aa6e3773bc8496b706b8ef9d4a873274d5fe4d0"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"acdc70239e01f5f6d609f0899d3a587d8551f1c2","unresolved":true,"context_lines":[{"line_number":774,"context_line":""},{"line_number":775,"context_line":"\t\t/*  resume at current address, not in step mode */"},{"line_number":776,"context_line":"\t\tretval \u003d aarch64_restore_one(curr, true, \u0026address, handle_breakpoints,"},{"line_number":777,"context_line":"\t\t\tfalse);"},{"line_number":778,"context_line":"\t\tif (retval \u003d\u003d ERROR_OK)"},{"line_number":779,"context_line":"\t\t\tretval \u003d aarch64_prepare_restart_one(curr);"},{"line_number":780,"context_line":"\t\tif (retval !\u003d ERROR_OK) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"448fcda2_b0e84b31","line":777,"in_reply_to":"5eca55f9_0b0dfc56","updated":"2024-11-10 13:45:15.000000000","message":"The 120 chars is an absolute maximum. The C coding style [1] states:\n\n\u003e Finally, try to avoid lines of code that are longer than 72-80 columns\n\nIn my opinion the \u002780 chars rule\u0027 should be used in this case. Maybe we need to clarify the style guide?\n\n[1] https://openocd.org/doc/doxygen/html/stylec.html","commit_id":"0aa6e3773bc8496b706b8ef9d4a873274d5fe4d0"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"3524120f9e2ab4b05158b487b3993af64a4c1c92","unresolved":true,"context_lines":[{"line_number":774,"context_line":""},{"line_number":775,"context_line":"\t\t/*  resume at current address, not in step mode */"},{"line_number":776,"context_line":"\t\tretval \u003d aarch64_restore_one(curr, true, \u0026address, handle_breakpoints,"},{"line_number":777,"context_line":"\t\t\tfalse);"},{"line_number":778,"context_line":"\t\tif (retval \u003d\u003d ERROR_OK)"},{"line_number":779,"context_line":"\t\t\tretval \u003d aarch64_prepare_restart_one(curr);"},{"line_number":780,"context_line":"\t\tif (retval !\u003d ERROR_OK) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"3f896454_51dd0722","line":777,"in_reply_to":"72b8f3fb_4a704175","updated":"2024-10-13 16:37:18.000000000","message":"What editor and configuration do you use? Because Gerrit obviously uses 100 chars as delimiter while our coding style states 80 chars. Right?","commit_id":"0aa6e3773bc8496b706b8ef9d4a873274d5fe4d0"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"9765359ecced9ebd3138934fb35e3723c2b69a06","unresolved":false,"context_lines":[{"line_number":774,"context_line":""},{"line_number":775,"context_line":"\t\t/*  resume at current address, not in step mode */"},{"line_number":776,"context_line":"\t\tretval \u003d aarch64_restore_one(curr, true, \u0026address, handle_breakpoints,"},{"line_number":777,"context_line":"\t\t\tfalse);"},{"line_number":778,"context_line":"\t\tif (retval \u003d\u003d ERROR_OK)"},{"line_number":779,"context_line":"\t\t\tretval \u003d aarch64_prepare_restart_one(curr);"},{"line_number":780,"context_line":"\t\tif (retval !\u003d ERROR_OK) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"020d7ff4_84c65676","line":777,"in_reply_to":"bb60649c_9117ba71","updated":"2024-11-11 18:38:34.000000000","message":"Sounds good! Now, we just need an answer from Tomas :)","commit_id":"0aa6e3773bc8496b706b8ef9d4a873274d5fe4d0"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"030c6334eb95685c99738ffe302ac4ae0efb168e","unresolved":true,"context_lines":[{"line_number":1149,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":1150,"context_line":"\t\treturn retval;"},{"line_number":1151,"context_line":""},{"line_number":1152,"context_line":"\tif (target-\u003esmp \u0026\u0026 (current \u003d\u003d 1)) {"},{"line_number":1153,"context_line":"\t\t/*"},{"line_number":1154,"context_line":"\t\t * isolate current target so that it doesn\u0027t get resumed"},{"line_number":1155,"context_line":"\t\t * together with the others"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"3170856b_a9bd6667","line":1152,"updated":"2024-10-13 15:34:39.000000000","message":"current is now a `bool` !","commit_id":"0aa6e3773bc8496b706b8ef9d4a873274d5fe4d0"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"3524120f9e2ab4b05158b487b3993af64a4c1c92","unresolved":true,"context_lines":[{"line_number":1149,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":1150,"context_line":"\t\treturn retval;"},{"line_number":1151,"context_line":""},{"line_number":1152,"context_line":"\tif (target-\u003esmp \u0026\u0026 (current \u003d\u003d 1)) {"},{"line_number":1153,"context_line":"\t\t/*"},{"line_number":1154,"context_line":"\t\t * isolate current target so that it doesn\u0027t get resumed"},{"line_number":1155,"context_line":"\t\t * together with the others"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"3d7e2f2a_441e206e","line":1152,"in_reply_to":"3170856b_a9bd6667","updated":"2024-10-13 16:37:18.000000000","message":"Good catch, thanks!","commit_id":"0aa6e3773bc8496b706b8ef9d4a873274d5fe4d0"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9bed39a7317e032f4c77f9d5799a3d49cd674d3e","unresolved":false,"context_lines":[{"line_number":1149,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":1150,"context_line":"\t\treturn retval;"},{"line_number":1151,"context_line":""},{"line_number":1152,"context_line":"\tif (target-\u003esmp \u0026\u0026 (current \u003d\u003d 1)) {"},{"line_number":1153,"context_line":"\t\t/*"},{"line_number":1154,"context_line":"\t\t * isolate current target so that it doesn\u0027t get resumed"},{"line_number":1155,"context_line":"\t\t * together with the others"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"d037da35_3b799349","line":1152,"in_reply_to":"3d7e2f2a_441e206e","updated":"2025-02-21 10:16:19.000000000","message":"Done","commit_id":"0aa6e3773bc8496b706b8ef9d4a873274d5fe4d0"}]}