)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1002298,"name":"Marek Kraus","email":"gamelaster@outlook.com","username":"gamelaster"},"change_message_id":"b8891788d5cb4008921364d4cab3fe7f7528b8f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3f140635_66f1a648","updated":"2024-10-27 15:47:48.000000000","message":"Based on our conversation on IRC, the reset mechanism was simplified. Thanks","commit_id":"e834fea784b6c50204dd48650df9cb9cadfff4a8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a5d8dbe8b17367d86a2136b92ff9c61b29a49340","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c1cc2e54_a48340e7","updated":"2024-10-27 22:02:45.000000000","message":"Thanks!","commit_id":"006bfc2f67a1e2600e33298fa348348e4f87d7ff"}],"tcl/target/bl702.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3604e999ead80953c54fe0c78fb12b89393b4410","unresolved":true,"context_lines":[{"line_number":56,"context_line":"\t# In GLB_SWRST_CFG2, clear CTRL_SYS_RESET, CTRL_CPU_RESET and CTRL_PWRON_RESET"},{"line_number":57,"context_line":"\tmmw 0x40000018 0x0 0x00000007"},{"line_number":58,"context_line":"\t# In GLB_SWRST_CFG2, set CTRL_SYS_RESET, CTRL_CPU_RESET and CTRL_PWRON_RESET to 1"},{"line_number":59,"context_line":"\tmmw 0x40000018 0x6 0x0"},{"line_number":60,"context_line":"}"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"c4cb7908_10434699","side":"PARENT","line":59,"updated":"2024-10-26 14:33:03.000000000","message":"You can prevent the error messages by using here:\n`catch {mmw 0x40000018 0x6 0x0}`\nthus keeping the code simpler without loading and executing the binary in memory.\n\nI think that in your new implementation you propose, you could still get error when you run `resume` if there is any other JTAG access after the core has started. But probably it\u0027s not your case.","commit_id":"d09ff476446a5403e556476b41a5a3c9bdf0a706"},{"author":{"_account_id":1002298,"name":"Marek Kraus","email":"gamelaster@outlook.com","username":"gamelaster"},"change_message_id":"b8891788d5cb4008921364d4cab3fe7f7528b8f9","unresolved":false,"context_lines":[{"line_number":56,"context_line":"\t# In GLB_SWRST_CFG2, clear CTRL_SYS_RESET, CTRL_CPU_RESET and CTRL_PWRON_RESET"},{"line_number":57,"context_line":"\tmmw 0x40000018 0x0 0x00000007"},{"line_number":58,"context_line":"\t# In GLB_SWRST_CFG2, set CTRL_SYS_RESET, CTRL_CPU_RESET and CTRL_PWRON_RESET to 1"},{"line_number":59,"context_line":"\tmmw 0x40000018 0x6 0x0"},{"line_number":60,"context_line":"}"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"e4820a0c_8605604c","side":"PARENT","line":59,"in_reply_to":"c4cb7908_10434699","updated":"2024-10-27 15:47:48.000000000","message":"Done","commit_id":"d09ff476446a5403e556476b41a5a3c9bdf0a706"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3d279b8e7eaefb628545ae681935e013d2766b22","unresolved":true,"context_lines":[{"line_number":42,"context_line":"\thalt"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"\t# Switch clock to internal RC32M"},{"line_number":45,"context_line":" \t# In HBN_GLB, set ROOT_CLK_SEL \u003d 0"},{"line_number":46,"context_line":" \tmmw 0x4000f030 0x0 0x00000003"},{"line_number":47,"context_line":" \t# Wait for clock switch"},{"line_number":48,"context_line":" \tsleep 10"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"995098ea_8b8a6b4b","line":45,"updated":"2024-10-27 17:29:17.000000000","message":"gerrit shows that, from this line till line 57, you have added one \u0027space\u0027 at the beginning of every line, before the existing TAB.\nThis adds unnecessarily modifications in this file.\n\nI\u0027m also going to modify checkpatch to catch such inconsistent indentation (mix space and TAB) in the TCL files. This will later trigger errors in this file and we will have to fix.\nIf you can, please send a new version without such spaces.","commit_id":"c0d4e927029cf62bcd0e9ae337273fca2530c0d1"},{"author":{"_account_id":1002298,"name":"Marek Kraus","email":"gamelaster@outlook.com","username":"gamelaster"},"change_message_id":"bd31e1b6a93d46b712f0a4750b61038602626b2e","unresolved":false,"context_lines":[{"line_number":42,"context_line":"\thalt"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"\t# Switch clock to internal RC32M"},{"line_number":45,"context_line":" \t# In HBN_GLB, set ROOT_CLK_SEL \u003d 0"},{"line_number":46,"context_line":" \tmmw 0x4000f030 0x0 0x00000003"},{"line_number":47,"context_line":" \t# Wait for clock switch"},{"line_number":48,"context_line":" \tsleep 10"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"72aadff4_4fd25347","line":45,"in_reply_to":"995098ea_8b8a6b4b","updated":"2024-10-27 19:35:09.000000000","message":"Done","commit_id":"c0d4e927029cf62bcd0e9ae337273fca2530c0d1"}]}
