)]}'
{"id":"openocd~master~Ife2cdcc6a2d96a2e24039bfec149705baf046318","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-10-27 22:02:45.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1002298":{"account":{"_account_id":1002298,"name":"Marek Kraus","email":"gamelaster@outlook.com","username":"gamelaster"},"last_update":"2024-11-09 21:06:05.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ife2cdcc6a2d96a2e24039bfec149705baf046318","subject":"tcl/target/bl702: implement full software reset","status":"MERGED","created":"2024-10-23 15:05:13.000000000","updated":"2024-11-09 21:06:05.000000000","submitted":"2024-11-09 21:06:05.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8529","meta_rev_id":"968eb1d9cc0d7340ffd39a0f575cf84787925fff","_number":8529,"owner":{"_account_id":1002298,"name":"Marek Kraus","email":"gamelaster@outlook.com","username":"gamelaster"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-11-09 21:06:05.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-11-09 21:06:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-10-23 15:18:43.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-10-26 14:33:03.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2024-10-27 22:02:45.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"bb95652e1a16512a5a80a3056a7fe159c1f00698","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002298,"name":"Marek Kraus","email":"gamelaster@outlook.com","username":"gamelaster"},"real_author":{"_account_id":1002298,"name":"Marek Kraus","email":"gamelaster@outlook.com","username":"gamelaster"},"date":"2024-10-23 15:05:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9b0754384720381753268d15489447deff5e1001","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-10-23 15:18:43.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20104/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19259/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"3604e999ead80953c54fe0c78fb12b89393b4410","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-10-26 14:33:03.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7293103ef18e4e25806fef6560147f2ec03c9799","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002298,"name":"Marek Kraus","email":"gamelaster@outlook.com","username":"gamelaster"},"real_author":{"_account_id":1002298,"name":"Marek Kraus","email":"gamelaster@outlook.com","username":"gamelaster"},"date":"2024-10-27 15:46:20.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"cb2860e749bca54da0067a06364d61c1a6fb5883","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-10-27 15:47:26.000000000","message":"Patch Set 2: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/20116/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19272/ : FAILURE","accounts_in_message":[],"_revision_number":2},{"id":"b8891788d5cb4008921364d4cab3fe7f7528b8f9","author":{"_account_id":1002298,"name":"Marek Kraus","email":"gamelaster@outlook.com","username":"gamelaster"},"real_author":{"_account_id":1002298,"name":"Marek Kraus","email":"gamelaster@outlook.com","username":"gamelaster"},"date":"2024-10-27 15:47:48.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"fed5e45ab724293fbf8330cb7e2bd8c26e816347","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002298,"name":"Marek Kraus","email":"gamelaster@outlook.com","username":"gamelaster"},"real_author":{"_account_id":1002298,"name":"Marek Kraus","email":"gamelaster@outlook.com","username":"gamelaster"},"date":"2024-10-27 15:48:36.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"d33e4af0072aa68d04d96b03129c0e589b57c920","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002298,"name":"Marek Kraus","email":"gamelaster@outlook.com","username":"gamelaster"},"real_author":{"_account_id":1002298,"name":"Marek Kraus","email":"gamelaster@outlook.com","username":"gamelaster"},"date":"2024-10-27 15:50:02.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"b132821fdc6cca05cc206f75c3381bace334af20","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-10-27 15:50:06.000000000","message":"Patch Set 3: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/20117/ : ABORTED\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19273/ : ABORTED","accounts_in_message":[],"_revision_number":3},{"id":"dce82634d10d2485b1ee6229d79e53f756d7cc7b","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-10-27 16:03:18.000000000","message":"Patch Set 4: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20118/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19274/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"3d279b8e7eaefb628545ae681935e013d2766b22","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-10-27 17:29:17.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"1c0ff61963d07ac7f5b825245051a61f6da9947c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002298,"name":"Marek Kraus","email":"gamelaster@outlook.com","username":"gamelaster"},"real_author":{"_account_id":1002298,"name":"Marek Kraus","email":"gamelaster@outlook.com","username":"gamelaster"},"date":"2024-10-27 19:33:26.000000000","message":"Uploaded patch set 5.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":5},{"id":"bd31e1b6a93d46b712f0a4750b61038602626b2e","author":{"_account_id":1002298,"name":"Marek Kraus","email":"gamelaster@outlook.com","username":"gamelaster"},"real_author":{"_account_id":1002298,"name":"Marek Kraus","email":"gamelaster@outlook.com","username":"gamelaster"},"date":"2024-10-27 19:35:09.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"5fbd3a290435e7699281fd48e311af5b7b3dbca0","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-10-27 19:47:12.000000000","message":"Patch Set 5: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20119/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19275/ : SUCCESS","accounts_in_message":[],"_revision_number":5},{"id":"a5d8dbe8b17367d86a2136b92ff9c61b29a49340","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-10-27 22:02:45.000000000","message":"Patch Set 5: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"df8c278d3a20b53bafc5b2940107a41c30fbb21b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-11-09 21:05:50.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"968eb1d9cc0d7340ffd39a0f575cf84787925fff","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-11-09 21:06:05.000000000","message":"Change has been successfully cherry-picked as b68d23da3c3bc67cffc750fddd64a6be9c615fdb","accounts_in_message":[],"_revision_number":6}],"current_revision":"b68d23da3c3bc67cffc750fddd64a6be9c615fdb","revisions":{"006bfc2f67a1e2600e33298fa348348e4f87d7ff":{"kind":"REWORK","_number":5,"created":"2024-10-27 19:33:26.000000000","uploader":{"_account_id":1002298,"name":"Marek Kraus","email":"gamelaster@outlook.com","username":"gamelaster"},"ref":"refs/changes/29/8529/5","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/29/8529/5","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/29/8529/5 \u0026\u0026 git checkout -b change-8529 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/29/8529/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/29/8529/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/29/8529/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/29/8529/5","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/29/8529/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d09ff476446a5403e556476b41a5a3c9bdf0a706","subject":"gdb_server: Improve const correctness"}],"author":{"name":"Marek Kraus","email":"gamelaster@outlook.com","date":"2024-10-23 14:27:33.000000000","tz":120},"committer":{"name":"Marek Kraus","email":"gamelaster@outlook.com","date":"2024-10-27 19:33:09.000000000","tz":60},"subject":"tcl/target/bl702: implement full software reset","message":"tcl/target/bl702: implement full software reset\n\nIn previous implementation, it was known that it does not perform\nfull reset, and that some peripherals, such as GLB core,\nwhich handles among other stuff GPIOs, was not reset.\n\nIt was presumed, that full reset by software is not possible,\nalthough, by accident, even when comment says that\nCTRL_PWRON_RESET is set to 1, it is not\n(value written into 0x40000018 supposed to be 0x7, not 0x6).\n\nCTRL_PWRON_RESET indeed triggers full \"power-on like\" reset,\nso this method is implemented in this commit.\nThere are some workarounds to make reset seamless, without any\nerror messages, which are described in comments of TCL script.\n\nOnly down-side of this reset is, that chip is halted after reset\nbit later in BootROM than previous implementation,\nbut it\u0027s still good.\n\nChange-Id: Ife2cdcc6a2d96a2e24039bfec149705baf046318\nSigned-off-by: Marek Kraus \u003cgamelaster@outlook.com\u003e\n"}},"c0d4e927029cf62bcd0e9ae337273fca2530c0d1":{"kind":"REWORK","_number":4,"created":"2024-10-27 15:50:02.000000000","uploader":{"_account_id":1002298,"name":"Marek Kraus","email":"gamelaster@outlook.com","username":"gamelaster"},"ref":"refs/changes/29/8529/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/29/8529/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/29/8529/4 \u0026\u0026 git checkout -b change-8529 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/29/8529/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/29/8529/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/29/8529/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/29/8529/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/29/8529/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d09ff476446a5403e556476b41a5a3c9bdf0a706","subject":"gdb_server: Improve const correctness"}],"author":{"name":"Marek Kraus","email":"gamelaster@outlook.com","date":"2024-10-23 14:27:33.000000000","tz":120},"committer":{"name":"Marek Kraus","email":"gamelaster@outlook.com","date":"2024-10-27 15:49:55.000000000","tz":60},"subject":"tcl/target/bl702: implement full software reset","message":"tcl/target/bl702: implement full software reset\n\nIn previous implementation, it was known that it does not perform\nfull reset, and that some peripherals, such as GLB core,\nwhich handles among other stuff GPIOs, was not reset.\n\nIt was presumed, that full reset by software is not possible,\nalthough, by accident, even when comment says that\nCTRL_PWRON_RESET is set to 1, it is not\n(value written into 0x40000018 supposed to be 0x7, not 0x6).\n\nCTRL_PWRON_RESET indeed triggers full \"power-on like\" reset,\nso this method is implemented in this commit.\nThere are some workarounds to make reset seamless, without any\nerror messages, which are described in comments of TCL script.\n\nOnly down-side of this reset is, that chip is halted after reset\nbit later in BootROM than previous implementation,\nbut it\u0027s still good.\n\nChange-Id: Ife2cdcc6a2d96a2e24039bfec149705baf046318\nSigned-off-by: Marek Kraus \u003cgamelaster@outlook.com\u003e\n"}},"b68d23da3c3bc67cffc750fddd64a6be9c615fdb":{"kind":"REWORK","_number":6,"created":"2024-11-09 21:06:05.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/29/8529/6","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/29/8529/6","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/29/8529/6 \u0026\u0026 git checkout -b change-8529 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/29/8529/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/29/8529/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/29/8529/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/29/8529/6","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/29/8529/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bcebc84882116c5c08c9243297a925262b1c3f0f","subject":"contrib: convert \u0027unsigned\u0027 to \u0027unsigned int\u0027"}],"author":{"name":"Marek Kraus","email":"gamelaster@outlook.com","date":"2024-10-23 14:27:33.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-11-09 21:06:05.000000000","tz":0},"subject":"tcl/target/bl702: implement full software reset","message":"tcl/target/bl702: implement full software reset\n\nIn previous implementation, it was known that it does not perform\nfull reset, and that some peripherals, such as GLB core,\nwhich handles among other stuff GPIOs, was not reset.\n\nIt was presumed, that full reset by software is not possible,\nalthough, by accident, even when comment says that\nCTRL_PWRON_RESET is set to 1, it is not\n(value written into 0x40000018 supposed to be 0x7, not 0x6).\n\nCTRL_PWRON_RESET indeed triggers full \"power-on like\" reset,\nso this method is implemented in this commit.\nThere are some workarounds to make reset seamless, without any\nerror messages, which are described in comments of TCL script.\n\nOnly down-side of this reset is, that chip is halted after reset\nbit later in BootROM than previous implementation,\nbut it\u0027s still good.\n\nChange-Id: Ife2cdcc6a2d96a2e24039bfec149705baf046318\nSigned-off-by: Marek Kraus \u003cgamelaster@outlook.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8529\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\n"}},"253e28e3d965691a9c86025596ec3d34133b8378":{"kind":"REWORK","_number":1,"created":"2024-10-23 15:05:13.000000000","uploader":{"_account_id":1002298,"name":"Marek Kraus","email":"gamelaster@outlook.com","username":"gamelaster"},"ref":"refs/changes/29/8529/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/29/8529/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/29/8529/1 \u0026\u0026 git checkout -b change-8529 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/29/8529/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/29/8529/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/29/8529/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/29/8529/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/29/8529/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d09ff476446a5403e556476b41a5a3c9bdf0a706","subject":"gdb_server: Improve const correctness"}],"author":{"name":"Marek Kraus","email":"gamelaster@outlook.com","date":"2024-10-23 14:27:33.000000000","tz":120},"committer":{"name":"Marek Kraus","email":"gamelaster@outlook.com","date":"2024-10-23 14:57:11.000000000","tz":120},"subject":"tcl/target/bl702: implement full software reset","message":"tcl/target/bl702: implement full software reset\n\nIn previous implementation, it was known that it does not perform\nfull reset, and that some peripherals, such as GLB core,\nwhich handles among other stuff GPIOs, was not reset.\n\nIt was presumed, that full reset by software is not possible,\nalthough, by accident, even when comment says that\nCTRL_PWRON_RESET is set to 1, it is not\n(value written into 0x40000018 supposed to be 0x7, not 0x6).\n\nCTRL_PWRON_RESET indeed triggers full \"power-on like\" reset,\nso this method is implemented in this commit.\nThere are some workarounds to make reset seamless, without any\nerror messages, which are described in comments of TCL script.\n\nOnly down-side of this reset is, that chip is halted after reset\nbit later in BootROM than previous implementation,\nbut it\u0027s still good.\n\nChange-Id: Ife2cdcc6a2d96a2e24039bfec149705baf046318\nSigned-off-by: Marek Kraus \u003cgamelaster@outlook.com\u003e\n"}},"27fed3a50615ab450151e286cc7da85f6580618a":{"kind":"REWORK","_number":3,"created":"2024-10-27 15:48:36.000000000","uploader":{"_account_id":1002298,"name":"Marek Kraus","email":"gamelaster@outlook.com","username":"gamelaster"},"ref":"refs/changes/29/8529/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/29/8529/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/29/8529/3 \u0026\u0026 git checkout -b change-8529 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/29/8529/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/29/8529/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/29/8529/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/29/8529/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/29/8529/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d09ff476446a5403e556476b41a5a3c9bdf0a706","subject":"gdb_server: Improve const correctness"}],"author":{"name":"Marek Kraus","email":"gamelaster@outlook.com","date":"2024-10-23 14:27:33.000000000","tz":120},"committer":{"name":"Marek Kraus","email":"gamelaster@outlook.com","date":"2024-10-27 15:48:31.000000000","tz":60},"subject":"tcl/target/bl702: implement full software reset","message":"tcl/target/bl702: implement full software reset\n\nIn previous implementation, it was known that it does not perform\nfull reset, and that some peripherals, such as GLB core,\nwhich handles among other stuff GPIOs, was not reset.\n\nIt was presumed, that full reset by software is not possible,\nalthough, by accident, even when comment says that\nCTRL_PWRON_RESET is set to 1, it is not\n(value written into 0x40000018 supposed to be 0x7, not 0x6).\n\nCTRL_PWRON_RESET indeed triggers full \"power-on like\" reset,\nso this method is implemented in this commit.\nThere are some workarounds to make reset seamless, without any\nerror messages, which are described in comments of TCL script.\n\nOnly down-side of this reset is, that chip is halted after reset\nbit later in BootROM than previous implementation,\nbut it\u0027s still good.\n\nChange-Id: Ife2cdcc6a2d96a2e24039bfec149705baf046318\nSigned-off-by: Marek Kraus \u003cgamelaster@outlook.com\u003e\n"}},"e834fea784b6c50204dd48650df9cb9cadfff4a8":{"kind":"REWORK","_number":2,"created":"2024-10-27 15:46:20.000000000","uploader":{"_account_id":1002298,"name":"Marek Kraus","email":"gamelaster@outlook.com","username":"gamelaster"},"ref":"refs/changes/29/8529/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/29/8529/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/29/8529/2 \u0026\u0026 git checkout -b change-8529 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/29/8529/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/29/8529/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/29/8529/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/29/8529/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/29/8529/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d09ff476446a5403e556476b41a5a3c9bdf0a706","subject":"gdb_server: Improve const correctness"}],"author":{"name":"Marek Kraus","email":"gamelaster@outlook.com","date":"2024-10-23 14:27:33.000000000","tz":120},"committer":{"name":"Marek Kraus","email":"gamelaster@outlook.com","date":"2024-10-27 15:44:38.000000000","tz":60},"subject":"tcl/target/bl702: implement full software reset","message":"tcl/target/bl702: implement full software reset\n\nIn previous implementation, it was known that it does not perform\nfull reset, and that some peripherals, such as GLB core,\nwhich handles among other stuff GPIOs, was not reset.\n\nIt was presumed, that full reset by software is not possible,\nalthough, by accident, even when comment says that\nCTRL_PWRON_RESET is set to 1, it is not\n(value written into 0x40000018 supposed to be 0x7, not 0x6).\n\nCTRL_PWRON_RESET indeed triggers full \"power-on like\" reset,\nso this method is implemented in this commit.\nThere are some workarounds to make reset seamless, without any\nerror messages, which are described in comments of TCL script.\n\nOnly down-side of this reset is, that chip is halted after reset\nbit later in BootROM than previous implementation,\nbut it\u0027s still good.\n\nChange-Id: Ife2cdcc6a2d96a2e24039bfec149705baf046318\nSigned-off-by: Marek Kraus \u003cgamelaster@outlook.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}