)]}'
{"id":"openocd~master~I32cc0a03b1355c472c2f7a98c28bc31a5e94d7db","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001667":{"account":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"last_update":"2024-10-29 06:12:18.000000000","reason":"\u003cGERRIT_ACCOUNT_1001667\u003e replied on the change","reason_account":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"}}},"hashtags":[],"change_id":"I32cc0a03b1355c472c2f7a98c28bc31a5e94d7db","subject":"jtag/commands: Add missing includes","status":"ABANDONED","created":"2024-10-28 14:21:23.000000000","updated":"2024-10-29 09:18:06.000000000","total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"6cc05a9fdcd34d522e142600b3a2a81066557f4b","_number":8530,"owner":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"actions":{},"labels":{"Verified":{"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-10-28 14:31:58.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"}],"messages":[{"id":"d74793dc2245531eee1cc6a6370d5bf633970295","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2024-10-28 14:21:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e1ab3dc8888c614d9885b456e1c1908bc7313eca","tag":"autogenerated:gerrit:abandon","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2024-10-28 14:29:29.000000000","message":"Abandoned\n\nThe issue is more complex than initially apparent. The change would introduce cyclical dependency: jtag/jtag.h --\u003e jtag/commands.h --\u003e jtag/drivers/minidriver_imp.h --\u003e jtag/minidriver.h --\u003e jtag/jtag.h\n\nMore investigation will be needed.\n\nAbandoning it for the time being.","accounts_in_message":[],"_revision_number":1},{"id":"2e19c52f5c6210fb60e77b7d28bb60394ef20c18","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-10-28 14:31:58.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"38a5c56ad11603b79f05e39924aa9a8b22ab4e56","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2024-10-29 06:12:18.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"6cc05a9fdcd34d522e142600b3a2a81066557f4b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-10-29 09:18:06.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1}],"current_revision":"36557cd1ebf0312b3da0e98a3551148b859b11b6","revisions":{"36557cd1ebf0312b3da0e98a3551148b859b11b6":{"kind":"REWORK","_number":1,"created":"2024-10-28 14:21:23.000000000","uploader":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"ref":"refs/changes/30/8530/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/30/8530/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/30/8530/1 \u0026\u0026 git checkout -b change-8530 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/30/8530/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/30/8530/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/30/8530/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/30/8530/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/30/8530/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d09ff476446a5403e556476b41a5a3c9bdf0a706","subject":"gdb_server: Improve const correctness"}],"author":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2024-10-28 14:16:28.000000000","tz":60},"committer":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2024-10-28 14:20:35.000000000","tz":60},"subject":"jtag/commands: Add missing includes","message":"jtag/commands: Add missing includes\n\nFile jtag/commands.h uses datatypes from stdint.h (uint*_t)\nand jtag/jtag.h (tap_state_t) but the includes were missing.\nAdd them.\n\nThe issue was discovered while experimenting with automated\ntools for cleanup of includes [1] [2].\n\n[1] https://clang.llvm.org/docs/ClangFormatStyleOptions.html#sortincludes\n[2] https://clang.llvm.org/extra/clang-tidy/checks/misc\n    /include-cleaner.html\n\nChange-Id: I32cc0a03b1355c472c2f7a98c28bc31a5e94d7db\nSigned-off-by: Jan Matyas \u003cjan.matyas@codasip.com\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}