)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"change_message_id":"9aecccec9b2fa399e194213320715ef66221f1ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"82e861c5_be7c1da1","updated":"2024-11-01 17:08:00.000000000","message":"AFAICT, ChangeLog is only meant for end users consumption (not automated processing). It\u0027s included in the release tarballs and then e.g. Debian ships them as `/usr/share/doc/openocd/changelog.gz`.\nSo since new output is nicer and more readable I\u0027m all for it.","commit_id":"0a046e7aae116a4770471cbc360abc01ecec7926"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"212c3319ac94d27cded5c01dd3f44989c8236992","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c95902c9_0ce12973","updated":"2024-11-01 16:44:21.000000000","message":"Thanks for this patch.\nIndeed the output looks way better than from git2cl. \nI like it also because it would allow dropping the submodule git2cl. We are moving to drop soon jimtcl and libjaylink, so git2cl remains as the last submodule.\n\nBut this is only used by Paul for the releases.\nI prefer having Paul to approve this patch.","commit_id":"0a046e7aae116a4770471cbc360abc01ecec7926"},{"author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"change_message_id":"1004d156bc640da2bdfe1aa08a2b780e76979df1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"09799410_6e8a3d22","updated":"2024-11-01 19:43:40.000000000","message":"I removed git2cl as announced, I added some trailing whitespace trimming, and I made the makefile recipe more robust by generating to a temporary file, and moving the finished file to the target filename (which is an atomic operation).","commit_id":"ab6edaee4e72f629eabd010fc6ae6d746bc13779"},{"author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"change_message_id":"8fdc671252c14b430b7e22c860321aaf3b9843c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"becc1579_9f5b35ef","updated":"2024-11-02 21:21:37.000000000","message":"I think this patch is ready to merge.","commit_id":"ab6edaee4e72f629eabd010fc6ae6d746bc13779"}],"Makefile.am":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"212c3319ac94d27cded5c01dd3f44989c8236992","unresolved":true,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"dist-hook:"},{"line_number":120,"context_line":"\tif test -d $(srcdir)/.git -a \\( ! -e $(distdir)/ChangeLog -o -w $(distdir)/ChangeLog \\) ; then \\"},{"line_number":121,"context_line":"\t\tgit --git-dir $(srcdir)/.git log --date\u003dshort --pretty\u003d\"format:%ad  %aN \u003c%aE\u003e%n%n%w(0,4,6)* %s%n%+b\" \\"},{"line_number":122,"context_line":"\t\t\u003e $(distdir)/ChangeLog ; \\"},{"line_number":123,"context_line":"\tfi"},{"line_number":124,"context_line":"\tfor i in $$($(TCL_FILES)); do \\"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"364de190_1a039f2b","line":121,"updated":"2024-11-01 16:44:21.000000000","message":"I think the last part of the string `...* %s%n+%b\"` can be simplified as `...* %B\"`.","commit_id":"0a046e7aae116a4770471cbc360abc01ecec7926"},{"author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"change_message_id":"884e88de59eb326780d9160dea7e4c616b07d46d","unresolved":true,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"dist-hook:"},{"line_number":120,"context_line":"\tif test -d $(srcdir)/.git -a \\( ! -e $(distdir)/ChangeLog -o -w $(distdir)/ChangeLog \\) ; then \\"},{"line_number":121,"context_line":"\t\tgit --git-dir $(srcdir)/.git log --date\u003dshort --pretty\u003d\"format:%ad  %aN \u003c%aE\u003e%n%n%w(0,4,6)* %s%n%+b\" \\"},{"line_number":122,"context_line":"\t\t\u003e $(distdir)/ChangeLog ; \\"},{"line_number":123,"context_line":"\tfi"},{"line_number":124,"context_line":"\tfor i in $$($(TCL_FILES)); do \\"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ba23f521_789afead","line":121,"in_reply_to":"364de190_1a039f2b","updated":"2024-11-01 17:10:25.000000000","message":"Good catch! The \"%s %b\" combination does not seem to work well if there is no empty line between the commit subject and the rest of the commit body. Placeholder %s also tends to generate very long first lines. I will switch to %B, which gives better results.","commit_id":"0a046e7aae116a4770471cbc360abc01ecec7926"},{"author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"change_message_id":"1004d156bc640da2bdfe1aa08a2b780e76979df1","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"dist-hook:"},{"line_number":120,"context_line":"\tif test -d $(srcdir)/.git -a \\( ! -e $(distdir)/ChangeLog -o -w $(distdir)/ChangeLog \\) ; then \\"},{"line_number":121,"context_line":"\t\tgit --git-dir $(srcdir)/.git log --date\u003dshort --pretty\u003d\"format:%ad  %aN \u003c%aE\u003e%n%n%w(0,4,6)* %s%n%+b\" \\"},{"line_number":122,"context_line":"\t\t\u003e $(distdir)/ChangeLog ; \\"},{"line_number":123,"context_line":"\tfi"},{"line_number":124,"context_line":"\tfor i in $$($(TCL_FILES)); do \\"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"4815a4f3_049387f6","line":121,"in_reply_to":"ba23f521_789afead","updated":"2024-11-01 19:43:40.000000000","message":"Done","commit_id":"0a046e7aae116a4770471cbc360abc01ecec7926"},{"author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"change_message_id":"fcf703188984e7dc90aac5e6a1f7748f0ac0c84e","unresolved":true,"context_lines":[{"line_number":120,"context_line":"\tif test -d $(srcdir)/.git -a \\( ! -e $(distdir)/ChangeLog -o -w $(distdir)/ChangeLog \\) ; then \\"},{"line_number":121,"context_line":"\t\tgit --git-dir $(srcdir)/.git log --date\u003dshort --pretty\u003d\"format:%ad  %aN \u003c%aE\u003e%n%n%w(0,4,6)* %s%n%+b\" \\"},{"line_number":122,"context_line":"\t\t\u003e $(distdir)/ChangeLog ; \\"},{"line_number":123,"context_line":"\tfi"},{"line_number":124,"context_line":"\tfor i in $$($(TCL_FILES)); do \\"},{"line_number":125,"context_line":"\t\tj\u003d\"$(distdir)/$(TCL_PATH)/$$i\" \u0026\u0026 \\"},{"line_number":126,"context_line":"\t\tmkdir -p \"$$(dirname $$j)\" \u0026\u0026 \\"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"71e8cf94_6741f99d","line":123,"updated":"2024-10-31 23:02:34.000000000","message":"If this patch gets approved, I\u0027ll try to update it in order to remove the tools/git2cl Git submodule.","commit_id":"0a046e7aae116a4770471cbc360abc01ecec7926"},{"author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"change_message_id":"1004d156bc640da2bdfe1aa08a2b780e76979df1","unresolved":false,"context_lines":[{"line_number":120,"context_line":"\tif test -d $(srcdir)/.git -a \\( ! -e $(distdir)/ChangeLog -o -w $(distdir)/ChangeLog \\) ; then \\"},{"line_number":121,"context_line":"\t\tgit --git-dir $(srcdir)/.git log --date\u003dshort --pretty\u003d\"format:%ad  %aN \u003c%aE\u003e%n%n%w(0,4,6)* %s%n%+b\" \\"},{"line_number":122,"context_line":"\t\t\u003e $(distdir)/ChangeLog ; \\"},{"line_number":123,"context_line":"\tfi"},{"line_number":124,"context_line":"\tfor i in $$($(TCL_FILES)); do \\"},{"line_number":125,"context_line":"\t\tj\u003d\"$(distdir)/$(TCL_PATH)/$$i\" \u0026\u0026 \\"},{"line_number":126,"context_line":"\t\tmkdir -p \"$$(dirname $$j)\" \u0026\u0026 \\"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"c755cd54_845052df","line":123,"in_reply_to":"71e8cf94_6741f99d","updated":"2024-11-01 19:43:40.000000000","message":"Done","commit_id":"0a046e7aae116a4770471cbc360abc01ecec7926"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"826eb761731b66303cc4f79afa3d0d9fa12f0cc6","unresolved":true,"context_lines":[{"line_number":121,"context_line":"dist-hook:"},{"line_number":122,"context_line":"\tif test -d $(srcdir)/.git -a \\( ! -e $(distdir)/ChangeLog -o -w $(distdir)/ChangeLog \\) ; then \\"},{"line_number":123,"context_line":"\t\tgit --git-dir $(srcdir)/.git log --date\u003dshort --pretty\u003d\"format:%ad  %aN \u003c%aE\u003e%n%n%w(0,4,6)* %B\" \\"},{"line_number":124,"context_line":"\t\t| sed \u0027s/[[:space:]]*$$//\u0027 \u003e $(distdir)/ChangeLog.tmp \u0026\u0026 \\"},{"line_number":125,"context_line":"\t\tmv $(distdir)/ChangeLog.tmp $(distdir)/ChangeLog; \\"},{"line_number":126,"context_line":"\tfi"},{"line_number":127,"context_line":"\tfor i in $$($(TCL_FILES)); do \\"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"f1a7b7d7_1956753f","line":124,"updated":"2024-11-02 11:44:11.000000000","message":"The double \u0027$\u0027 looks incorrect. Can you please verify it?\nAny specific reason to pass through a temporary file?","commit_id":"ab6edaee4e72f629eabd010fc6ae6d746bc13779"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3606ab54c4ad6cbbb3a2404a1d580a95d1f0ac19","unresolved":false,"context_lines":[{"line_number":121,"context_line":"dist-hook:"},{"line_number":122,"context_line":"\tif test -d $(srcdir)/.git -a \\( ! -e $(distdir)/ChangeLog -o -w $(distdir)/ChangeLog \\) ; then \\"},{"line_number":123,"context_line":"\t\tgit --git-dir $(srcdir)/.git log --date\u003dshort --pretty\u003d\"format:%ad  %aN \u003c%aE\u003e%n%n%w(0,4,6)* %B\" \\"},{"line_number":124,"context_line":"\t\t| sed \u0027s/[[:space:]]*$$//\u0027 \u003e $(distdir)/ChangeLog.tmp \u0026\u0026 \\"},{"line_number":125,"context_line":"\t\tmv $(distdir)/ChangeLog.tmp $(distdir)/ChangeLog; \\"},{"line_number":126,"context_line":"\tfi"},{"line_number":127,"context_line":"\tfor i in $$($(TCL_FILES)); do \\"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"6a1ed977_d728196b","line":124,"in_reply_to":"844baf2c_93e6abd7","updated":"2024-11-02 20:53:44.000000000","message":"Yes, you are right, double dollar is required in a Makefile.","commit_id":"ab6edaee4e72f629eabd010fc6ae6d746bc13779"},{"author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"change_message_id":"f6cc2969fe2c5629fb19912fa7a4828b8bdd158d","unresolved":false,"context_lines":[{"line_number":121,"context_line":"dist-hook:"},{"line_number":122,"context_line":"\tif test -d $(srcdir)/.git -a \\( ! -e $(distdir)/ChangeLog -o -w $(distdir)/ChangeLog \\) ; then \\"},{"line_number":123,"context_line":"\t\tgit --git-dir $(srcdir)/.git log --date\u003dshort --pretty\u003d\"format:%ad  %aN \u003c%aE\u003e%n%n%w(0,4,6)* %B\" \\"},{"line_number":124,"context_line":"\t\t| sed \u0027s/[[:space:]]*$$//\u0027 \u003e $(distdir)/ChangeLog.tmp \u0026\u0026 \\"},{"line_number":125,"context_line":"\t\tmv $(distdir)/ChangeLog.tmp $(distdir)/ChangeLog; \\"},{"line_number":126,"context_line":"\tfi"},{"line_number":127,"context_line":"\tfor i in $$($(TCL_FILES)); do \\"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"844baf2c_93e6abd7","line":124,"in_reply_to":"f1a7b7d7_1956753f","updated":"2024-11-02 13:38:35.000000000","message":"The GNU Make manual is here: https://www.gnu.org/software/make/manual/make.html\n\nAbout the double \u0027$\u0027, you need to escape that character inside Makefile recipes. Without the doubling, it does not work. Search for the following example in the GNU Make manual: sed \u0027s/$$/^M/\u0027\n\nUsing a temporary file is the only way to write reliable Makefile recipes. Search for \"defensive recipes\" in the GNU Make manual.","commit_id":"ab6edaee4e72f629eabd010fc6ae6d746bc13779"}]}