)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"cc5a6e70e39f467d3f35b0c7b09c93b7428c793f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2b6524d5_a11fd8cd","updated":"2024-11-10 23:21:02.000000000","message":"I think that Patchset2 plus my comment is way more readable that this Patchset3.\nAnyway, let\u0027s see what is the result from build on Mac and BSD.\n\nI hope someone proposes a patch to support Bus Pirate in Windows. It should not be that difficult, but I don\u0027t have neither the adapter nor the host.","commit_id":"b79a49458bf237d8cb60a211efd48df6c7994db7"},{"author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"change_message_id":"aef30c0c1414505876fe3221407dc5ff80d782a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"401541bf_8c612845","updated":"2024-11-10 22:30:32.000000000","message":"The latest patch version now enables the Bus Pirate on most systems.","commit_id":"b79a49458bf237d8cb60a211efd48df6c7994db7"},{"author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"change_message_id":"5ac8d535a4e9f994a45ea71ca52011b7c690249b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"13bf5443_238c1111","in_reply_to":"1c796f28_51940bfb","updated":"2024-11-12 16:03:53.000000000","message":"When and if that patch gets merged, we can easily auto-enable the Bus Pirate under Windows. But for now, I think it is worth merging this patch to auto-enable it on the systems were it should work.","commit_id":"b79a49458bf237d8cb60a211efd48df6c7994db7"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"5f154bb151db731f888f980266d4d03d235aeaec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1c796f28_51940bfb","in_reply_to":"2b6524d5_a11fd8cd","updated":"2024-11-12 15:50:54.000000000","message":"There is, already!\nhttps://review.openocd.org/c/openocd/+/7805\njtag/driver: buspirate add Windows support","commit_id":"b79a49458bf237d8cb60a211efd48df6c7994db7"}],"configure.ac":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c0aa745772a91582137fc622ea0c57acd520db33","unresolved":true,"context_lines":[{"line_number":430,"context_line":"    parport_use_giveio\u003dyes"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"    AS_IF([test \"x$enable_buspirate\" \u003d \"xyes\"], ["},{"line_number":433,"context_line":"      AC_MSG_ERROR([buspirate currently not supported by MinGW32 hosts])"},{"line_number":434,"context_line":"    ])"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"    # In case enable_buspirate\u003dauto, make sure it will not be built."}],"source_content_type":"application/octet-stream","patch_set":2,"id":"78b02317_3d997934","side":"PARENT","line":433,"updated":"2024-11-04 14:24:20.000000000","message":"The original code was flagging BusPirate as not available on MinGW only.\nActually was claiming MinGW32, but the test above was valid for MinGW64 too!","commit_id":"40d58ce5290a51c58615c4f95912b69fa7975aea"},{"author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"change_message_id":"780740c0ab853c02c8276669bc5002dd8990a21e","unresolved":false,"context_lines":[{"line_number":430,"context_line":"    parport_use_giveio\u003dyes"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"    AS_IF([test \"x$enable_buspirate\" \u003d \"xyes\"], ["},{"line_number":433,"context_line":"      AC_MSG_ERROR([buspirate currently not supported by MinGW32 hosts])"},{"line_number":434,"context_line":"    ])"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"    # In case enable_buspirate\u003dauto, make sure it will not be built."}],"source_content_type":"application/octet-stream","patch_set":2,"id":"cadf2c7b_f50f9ebe","side":"PARENT","line":433,"in_reply_to":"032629dd_54edadce","updated":"2024-11-04 15:39:11.000000000","message":"In this case, I suggest you merge this patch. It is unlikely, but if anybody complains, then we can easily add any platforms we may have missed, but this time we will hopefully document where the driver does work.","commit_id":"40d58ce5290a51c58615c4f95912b69fa7975aea"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"07505670b97979795a55074cf7459b59c172a80e","unresolved":false,"context_lines":[{"line_number":430,"context_line":"    parport_use_giveio\u003dyes"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"    AS_IF([test \"x$enable_buspirate\" \u003d \"xyes\"], ["},{"line_number":433,"context_line":"      AC_MSG_ERROR([buspirate currently not supported by MinGW32 hosts])"},{"line_number":434,"context_line":"    ])"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"    # In case enable_buspirate\u003dauto, make sure it will not be built."}],"source_content_type":"application/octet-stream","patch_set":2,"id":"032629dd_54edadce","side":"PARENT","line":433,"in_reply_to":"1fdb4a92_4ea1a9ea","updated":"2024-11-04 15:20:50.000000000","message":"No idea! I don\u0027t have this adapter!","commit_id":"40d58ce5290a51c58615c4f95912b69fa7975aea"},{"author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"change_message_id":"aef30c0c1414505876fe3221407dc5ff80d782a0","unresolved":false,"context_lines":[{"line_number":430,"context_line":"    parport_use_giveio\u003dyes"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"    AS_IF([test \"x$enable_buspirate\" \u003d \"xyes\"], ["},{"line_number":433,"context_line":"      AC_MSG_ERROR([buspirate currently not supported by MinGW32 hosts])"},{"line_number":434,"context_line":"    ])"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"    # In case enable_buspirate\u003dauto, make sure it will not be built."}],"source_content_type":"application/octet-stream","patch_set":2,"id":"850efbba_d222518f","side":"PARENT","line":433,"in_reply_to":"5496aa7e_5b8ff490","updated":"2024-11-10 22:30:32.000000000","message":"Done","commit_id":"40d58ce5290a51c58615c4f95912b69fa7975aea"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"8103c87a320b1fc07385c3cee0e898518a1f0fed","unresolved":true,"context_lines":[{"line_number":430,"context_line":"    parport_use_giveio\u003dyes"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"    AS_IF([test \"x$enable_buspirate\" \u003d \"xyes\"], ["},{"line_number":433,"context_line":"      AC_MSG_ERROR([buspirate currently not supported by MinGW32 hosts])"},{"line_number":434,"context_line":"    ])"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"    # In case enable_buspirate\u003dauto, make sure it will not be built."}],"source_content_type":"application/octet-stream","patch_set":2,"id":"5496aa7e_5b8ff490","side":"PARENT","line":433,"in_reply_to":"699586d3_2fbc4ef6","updated":"2024-11-09 22:48:21.000000000","message":"From:\nhttps://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.72/html_node/Canonicalizing.html\nhttps://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.72/html_node/Specifying-Target-Triplets.html\n\n`$host` should be something like `x86_64-w64-mingw64` that is then split in the triplet `$host_cpu-$host_vendor-$host_os`, so `$host_os` should become `mingw64`.\nIf you want, feel free to drop `$host` and only use `$host_os`, but in a separate patch.\n\nI used to compile, time to time, in a VM with openBSB, but it doesn\u0027t boot anymore. I need to fix it.\nO_NOCTTY and O_NDELAY are present in BSD and should work as in Linux.\nI also have access to an ACI that autobuilds for MacOS the upstream master branch, but I can only get feedback after the merge.\n\nAnyway, the original configure allowed to build buspirate for several OS, I don\u0027t see reason for changing this. If later someone complains that `auto` prevents building on his OS, that would be a good feedback to explicitly ban buspirate from that OS.","commit_id":"40d58ce5290a51c58615c4f95912b69fa7975aea"},{"author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"change_message_id":"b8df2db0b16ef6d3fe55691be59a4b5f5043ac05","unresolved":false,"context_lines":[{"line_number":430,"context_line":"    parport_use_giveio\u003dyes"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"    AS_IF([test \"x$enable_buspirate\" \u003d \"xyes\"], ["},{"line_number":433,"context_line":"      AC_MSG_ERROR([buspirate currently not supported by MinGW32 hosts])"},{"line_number":434,"context_line":"    ])"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"    # In case enable_buspirate\u003dauto, make sure it will not be built."}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1fdb4a92_4ea1a9ea","side":"PARENT","line":433,"in_reply_to":"78b02317_3d997934","updated":"2024-11-04 14:58:03.000000000","message":"I believe that the Bus Pirate driver only works on Linux at the moment.","commit_id":"40d58ce5290a51c58615c4f95912b69fa7975aea"},{"author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"change_message_id":"961f0486a5a1c2303996dc1a969e8d9c7f8a9310","unresolved":true,"context_lines":[{"line_number":430,"context_line":"    parport_use_giveio\u003dyes"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"    AS_IF([test \"x$enable_buspirate\" \u003d \"xyes\"], ["},{"line_number":433,"context_line":"      AC_MSG_ERROR([buspirate currently not supported by MinGW32 hosts])"},{"line_number":434,"context_line":"    ])"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"    # In case enable_buspirate\u003dauto, make sure it will not be built."}],"source_content_type":"application/octet-stream","patch_set":2,"id":"699586d3_2fbc4ef6","side":"PARENT","line":433,"in_reply_to":"bb826411_4ec65f79","updated":"2024-11-04 20:34:12.000000000","message":"OK, let\u0027s assume that the serial ports, including O_NOCTTY and O_NDELAY, do work on BSD and Darwin, at least as far as the Bus Pirate requires.\n\nWe are currently checking $host_os for \"linux*\" and \"freebsd*\", and $host for \"*-cygwin*\", \"*-mingw* | *-msys*\" and \"*darwin*\".\n\nBy the way, I wonder whether we should always check either $host_os or $host, instead of sometimes one, and sometimes the other.\n\nPreviously, OpenOCD\u0027s configure script was only enabling the Bus Pirate adapter on demand, and banning it on MinGW32.\n\nI think it should be enabled by default on Linux, that is, \"linux*\" should set it to \u0027auto\u0027.\n\n\"*-mingw* | *-msys*\" should remain banned.\n\nWhat would you do with the rest? Would you set the Bus Pirate to \u0027auto\u0027 on all other systems? Or just enable it when the user specifically asks for it?\n\nIs Jenkins building for BSD, Darwin and Cygwin, perhaps with cross-compilers? Or not at all?\n\nCan I see somewhere the source code for the continuous integration build and test steps?","commit_id":"40d58ce5290a51c58615c4f95912b69fa7975aea"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c54b3939b36a02df4b15c970c37feeedb9933fef","unresolved":true,"context_lines":[{"line_number":430,"context_line":"    parport_use_giveio\u003dyes"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"    AS_IF([test \"x$enable_buspirate\" \u003d \"xyes\"], ["},{"line_number":433,"context_line":"      AC_MSG_ERROR([buspirate currently not supported by MinGW32 hosts])"},{"line_number":434,"context_line":"    ])"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"    # In case enable_buspirate\u003dauto, make sure it will not be built."}],"source_content_type":"application/octet-stream","patch_set":2,"id":"bb826411_4ec65f79","side":"PARENT","line":433,"in_reply_to":"cadf2c7b_f50f9ebe","updated":"2024-11-04 16:34:16.000000000","message":"MinGW has its own API to access a serial port, so no surprise this code would not work (it should probably even not compile!).\nNot sure about CygWin, as last time I tried to use it was probably ~25 years ago.\nBut the BSD family is posix, so it should work. And Darwin is a derived from BSD. Why you think it should not work?","commit_id":"40d58ce5290a51c58615c4f95912b69fa7975aea"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c0aa745772a91582137fc622ea0c57acd520db33","unresolved":true,"context_lines":[{"line_number":700,"context_line":"PROCESS_ADAPTERS([LIBGPIOD_ADAPTERS], [\"x$use_libgpiod\" \u003d \"xyes\"], [libgpiod])"},{"line_number":701,"context_line":"PROCESS_ADAPTERS([LIBJAYLINK_ADAPTERS], [\"x$use_internal_libjaylink\" \u003d \"xyes\" -o \"x$use_libjaylink\" \u003d \"xyes\"], [libjaylink-0.2])"},{"line_number":702,"context_line":"PROCESS_ADAPTERS([PCIE_ADAPTERS], [\"x$is_linux\" \u003d \"xyes\"], [Linux build])"},{"line_number":703,"context_line":"PROCESS_ADAPTERS([SERIAL_PORT_ADAPTERS], [\"x$is_linux\" \u003d \"xyes\"], [Linux build])"},{"line_number":704,"context_line":"PROCESS_ADAPTERS([DUMMY_ADAPTER], [true], [unused])"},{"line_number":705,"context_line":""},{"line_number":706,"context_line":"AS_IF([test \"x$enable_linuxgpiod\" !\u003d \"xno\"], ["}],"source_content_type":"application/octet-stream","patch_set":2,"id":"99cc011a_603da7d5","line":703,"updated":"2024-11-04 14:24:20.000000000","message":"Now it is available on Linux only.\nWhat about the other OS? CygWin, Darwin, xBSD, ...?\nI think the test should be\n`PROCESS_ADAPTERS([SERIAL_PORT_ADAPTERS], [\"x$is_mingw\" !\u003d \"xyes\"], [build not MinGW])`","commit_id":"7b051935f55b6e51e71d0b113cfc5622ac0869d7"},{"author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"change_message_id":"b8df2db0b16ef6d3fe55691be59a4b5f5043ac05","unresolved":false,"context_lines":[{"line_number":700,"context_line":"PROCESS_ADAPTERS([LIBGPIOD_ADAPTERS], [\"x$use_libgpiod\" \u003d \"xyes\"], [libgpiod])"},{"line_number":701,"context_line":"PROCESS_ADAPTERS([LIBJAYLINK_ADAPTERS], [\"x$use_internal_libjaylink\" \u003d \"xyes\" -o \"x$use_libjaylink\" \u003d \"xyes\"], [libjaylink-0.2])"},{"line_number":702,"context_line":"PROCESS_ADAPTERS([PCIE_ADAPTERS], [\"x$is_linux\" \u003d \"xyes\"], [Linux build])"},{"line_number":703,"context_line":"PROCESS_ADAPTERS([SERIAL_PORT_ADAPTERS], [\"x$is_linux\" \u003d \"xyes\"], [Linux build])"},{"line_number":704,"context_line":"PROCESS_ADAPTERS([DUMMY_ADAPTER], [true], [unused])"},{"line_number":705,"context_line":""},{"line_number":706,"context_line":"AS_IF([test \"x$enable_linuxgpiod\" !\u003d \"xno\"], ["}],"source_content_type":"application/octet-stream","patch_set":2,"id":"4aa73afd_4bd623a4","line":703,"in_reply_to":"99cc011a_603da7d5","updated":"2024-11-04 14:58:03.000000000","message":"Done","commit_id":"7b051935f55b6e51e71d0b113cfc5622ac0869d7"}]}