)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"change_message_id":"a3509fa135fe05ff9b5813502d2670905ab2c8a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"55d01b78_434466a5","updated":"2024-12-22 21:36:11.000000000","message":"It has been almost 7 weeks since I posted this patch. I hope it does not get forgotten. I wanted to amend related patch 8536 afterwards.","commit_id":"80ab19397250080d2a4647202b0730f8b9acd25b"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"bc93ad6bb1ca87351d756808371c01a7a95f33ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6192a9a2_ff3f9e6f","updated":"2024-11-04 13:33:30.000000000","message":"Missing `bcm2835gpio.c` ?\nWhat about https://review.openocd.org/c/openocd/+/8536 ?","commit_id":"80ab19397250080d2a4647202b0730f8b9acd25b"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"26b2c0172942a66fa376aef40c3cd313243fca6d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4039aa63_c5f936ff","updated":"2025-01-02 16:36:28.000000000","message":"Sorry for the long wait.\nLet\u0027s proceed merging this, then the new 8536 will follow","commit_id":"80ab19397250080d2a4647202b0730f8b9acd25b"},{"author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"change_message_id":"f62f981b24efe518a9b491b9d64b7109dc2f3ff9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"47640c83_37dd94e5","in_reply_to":"6192a9a2_ff3f9e6f","updated":"2024-11-04 13:46:38.000000000","message":"We do not really need to modify bcm2835gpio.c .\n\nI mean, variable \"struct bitbang_interface bcm2835gpio_bitbang\" inside bcm2835gpio.c must not be const there, it can remain non-const.\n\nThe other patch 8536 I submitted is therefore completely independent of this patch.","commit_id":"80ab19397250080d2a4647202b0730f8b9acd25b"}],"src/jtag/drivers/bitbang.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"23899856a4d9ef0fe80d0847c0950b28790cb50d","unresolved":true,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"int bitbang_execute_queue(struct jtag_command *cmd_queue);"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"extern const struct bitbang_interface *bitbang_interface;"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"#endif /* OPENOCD_JTAG_DRIVERS_BITBANG_H */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"2d0a03bc_84356ac9","line":70,"updated":"2024-11-04 13:45:31.000000000","message":"I don\u0027t really like having such modifiable global variables.\nWhat about introducing here an API\n`int bitbang_init_interface(const struct bitbang_interface *bb_interface);`\nand in `bitbang.c`\n```\nstatic const struct bitbang_interface *bitbang_interface;\n...\nint bitbang_init_interface(const struct bitbang_interface *bb_interface)\n{\n    bitbang_interface \u003d bb_interface;\n    return ERROR_OK;\n}\n```\n\nIf you prefer, this can be done in a separate patch","commit_id":"80ab19397250080d2a4647202b0730f8b9acd25b"},{"author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"change_message_id":"e3c6af4f649a1b3e21af8359dd5ee4b92c21d280","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"int bitbang_execute_queue(struct jtag_command *cmd_queue);"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"extern const struct bitbang_interface *bitbang_interface;"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"#endif /* OPENOCD_JTAG_DRIVERS_BITBANG_H */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"1fdfe33f_42f751f6","line":70,"in_reply_to":"2d0a03bc_84356ac9","updated":"2024-11-04 13:48:06.000000000","message":"I agree, but that could be a separate patch.","commit_id":"80ab19397250080d2a4647202b0730f8b9acd25b"}]}