)]}'
{"id":"openocd~master~I3b55b8fffa07ce67177c108e7c9554ca46674246","project":"openocd","branch":"master","hashtags":[],"change_id":"I3b55b8fffa07ce67177c108e7c9554ca46674246","subject":"checkpatch: exclude gerrit\u0027s Change-Id line from commit description","status":"MERGED","created":"2024-11-04 15:07:41.000000000","updated":"2024-11-16 14:25:35.000000000","submitted":"2024-11-16 14:25:35.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8539","meta_rev_id":"7bc9b9dc244e7d5588ac7c45e826f62a04bf312c","_number":8539,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-11-16 14:25:35.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-11-16 14:25:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-11-04 15:24:11.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"53120dfaa004133ea09ff9d3c55625ee1f82b89c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-11-04 15:07:41.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4474f50dd7a67866ec208846f0be113ed4d8b5e9","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-11-04 15:24:11.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20141/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19297/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"69e79505d3d99e3e7143419490b018490cbcdca9","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-11-04 16:27:04.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"a73427af86614ecb70f4851956dac1fd704b6c60","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-11-16 14:25:32.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"7bc9b9dc244e7d5588ac7c45e826f62a04bf312c","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-11-16 14:25:35.000000000","message":"Change has been successfully cherry-picked as 8a3723022689dd078c3e61268615616d5566fc94","accounts_in_message":[],"_revision_number":2}],"current_revision":"8a3723022689dd078c3e61268615616d5566fc94","revisions":{"8a3723022689dd078c3e61268615616d5566fc94":{"kind":"REWORK","_number":2,"created":"2024-11-16 14:25:35.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/39/8539/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/39/8539/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/39/8539/2 \u0026\u0026 git checkout -b change-8539 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/39/8539/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/39/8539/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/39/8539/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/39/8539/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/39/8539/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6d60ac5c08e6343008f40ee3d8daa5e8e00eb148","subject":"Make bootstrap more robust"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-04-10 10:02:55.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-11-16 14:25:35.000000000","tz":0},"subject":"checkpatch: exclude gerrit\u0027s Change-Id line from commit description","message":"checkpatch: exclude gerrit\u0027s Change-Id line from commit description\n\nCheckpatch rejects patches that have empty commit description and\nlogs them with:\n\tWARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one\nBut if the patch has a gerrit\u0027s Change-Id line placed before the\nline Signed-off-by, then checkpatch considers the Change-Id line\nas a valid commit description text.\n\nUse the Change-Id tag as a marker of the end of the commit message,\nthus not counting its line as part of the commit description.\n\nThis patch is not relevant for the Linux kernel development process\nas gerrit is not involved and the Change-Id tag is rejected. But\nother projects, like OpenOCD, base the development on gerrit and\nreuse kernel\u0027s checkpatch with flag \u0027--ignore GERRIT_CHANGE_ID\u0027.\n\nThis patch has been refused [1] in Linux upstream because it has\nnot been considered relevant for that project.\nLet\u0027s take it as another add-on in OpenOCD checkpatch.\n\nChange-Id: I3b55b8fffa07ce67177c108e7c9554ca46674246\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nLink: [1] https://lore.kernel.org/lkml/20230410100255.16755-1-borneo.antonio@gmail.com/\nReviewed-on: https://review.openocd.org/c/openocd/+/8539\nTested-by: jenkins\n"}},"a3b5f9b3310fe354569c848d47facaecbdd4fb8c":{"kind":"REWORK","_number":1,"created":"2024-11-04 15:07:41.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/39/8539/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/39/8539/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/39/8539/1 \u0026\u0026 git checkout -b change-8539 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/39/8539/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/39/8539/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/39/8539/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/39/8539/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/39/8539/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"40d58ce5290a51c58615c4f95912b69fa7975aea","subject":"tcl/target/renesas_rz_g2: Rename to renesas_rz and add RZ/V2L-G3S"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-04-10 10:02:55.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-11-04 15:06:25.000000000","tz":60},"subject":"checkpatch: exclude gerrit\u0027s Change-Id line from commit description","message":"checkpatch: exclude gerrit\u0027s Change-Id line from commit description\n\nCheckpatch rejects patches that have empty commit description and\nlogs them with:\n\tWARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one\nBut if the patch has a gerrit\u0027s Change-Id line placed before the\nline Signed-off-by, then checkpatch considers the Change-Id line\nas a valid commit description text.\n\nUse the Change-Id tag as a marker of the end of the commit message,\nthus not counting its line as part of the commit description.\n\nThis patch is not relevant for the Linux kernel development process\nas gerrit is not involved and the Change-Id tag is rejected. But\nother projects, like OpenOCD, base the development on gerrit and\nreuse kernel\u0027s checkpatch with flag \u0027--ignore GERRIT_CHANGE_ID\u0027.\n\nThis patch has been refused [1] in Linux upstream because it has\nnot been considered relevant for that project.\nLet\u0027s take it as another add-on in OpenOCD checkpatch.\n\nChange-Id: I3b55b8fffa07ce67177c108e7c9554ca46674246\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nLink: [1] https://lore.kernel.org/lkml/20230410100255.16755-1-borneo.antonio@gmail.com/\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}