)]}'
{"id":"openocd~master~I84f738309d23c8d0b5329aa04436db750cf185e5","project":"openocd","branch":"master","hashtags":[],"change_id":"I84f738309d23c8d0b5329aa04436db750cf185e5","subject":"jtag: driver: make local functions static","status":"MERGED","created":"2024-11-09 21:00:27.000000000","updated":"2024-11-23 13:46:01.000000000","submitted":"2024-11-23 13:46:01.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8543","meta_rev_id":"17a773c9112a48d1afce450e3aad31ccc921b3a3","_number":8543,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-11-23 13:46:01.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-11-23 13:46:01.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-11-09 22:29:01.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"c527773d2439bd37bd84a4d6e1ef17f18d116c32","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-11-09 21:00:27.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0d1384e1e671a4c1bffd70991cc3e15819a30d20","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-11-09 22:29:01.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20187/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19343/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"0b7e38f41b8a71a1508a8c62bd30889895e27d82","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-11-10 08:06:44.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"dbc88c547bf823098c79eceff5ed2b6e33e8c289","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-11-23 13:45:56.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"17a773c9112a48d1afce450e3aad31ccc921b3a3","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-11-23 13:46:01.000000000","message":"Change has been successfully cherry-picked as f4ac0c7022933adcbc68140ca565e93ece726ab5","accounts_in_message":[],"_revision_number":2}],"current_revision":"f4ac0c7022933adcbc68140ca565e93ece726ab5","revisions":{"f1c02765f6e6e73b7b91560ebbbc793c47f876e1":{"kind":"REWORK","_number":1,"created":"2024-11-09 21:00:27.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/43/8543/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/43/8543/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/43/8543/1 \u0026\u0026 git checkout -b change-8543 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/43/8543/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/43/8543/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/43/8543/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/43/8543/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/43/8543/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"438e344d1a72b654740b643235325d87b5a420e2","subject":"jtag: core: make local functions static"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-11-09 18:39:11.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-11-09 20:54:47.000000000","tz":60},"subject":"jtag: driver: make local functions static","message":"jtag: driver: make local functions static\n\nThe functions:\n- interface_jtag_add_callback();\n- interface_jtag_add_callback4();\nare not referenced outside the file.\n\nMake them static.\n\nChange-Id: I84f738309d23c8d0b5329aa04436db750cf185e5\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"f4ac0c7022933adcbc68140ca565e93ece726ab5":{"kind":"REWORK","_number":2,"created":"2024-11-23 13:46:01.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/43/8543/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/43/8543/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/43/8543/2 \u0026\u0026 git checkout -b change-8543 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/43/8543/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/43/8543/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/43/8543/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/43/8543/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/43/8543/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f82664ff827ba76f773c51b74705c13b9c813758","subject":"jtag: core: make local functions static"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-11-09 18:39:11.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-11-23 13:46:01.000000000","tz":0},"subject":"jtag: driver: make local functions static","message":"jtag: driver: make local functions static\n\nThe functions:\n- interface_jtag_add_callback();\n- interface_jtag_add_callback4();\nare not referenced outside the file.\n\nMake them static.\n\nChange-Id: I84f738309d23c8d0b5329aa04436db750cf185e5\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8543\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}