)]}'
{"id":"openocd~master~Ia8d35554673145fdfe0e501543eb18919863039f","project":"openocd","branch":"master","hashtags":[],"change_id":"Ia8d35554673145fdfe0e501543eb18919863039f","subject":"semihosting: make local functions static","status":"MERGED","created":"2024-11-09 21:00:27.000000000","updated":"2024-11-23 13:48:25.000000000","submitted":"2024-11-23 13:48:25.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8551","meta_rev_id":"cc6589496fa572f7d02fbe28dd2930260c15e10b","_number":8551,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-11-23 13:48:25.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-11-23 13:48:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-11-10 01:34:23.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"7bc81e0535cf469f9268bacbd36f7e98ca05525c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-11-09 21:00:27.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c40f30321c95b3a55752b9a20cbe1ea90dbba1d8","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-11-10 01:34:23.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20195/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19351/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"e609d5538fdb6cd3cee9bd3cf5d85a76bf3e0712","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-11-10 08:08:11.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"269e8f1a0197d7943a276a6161244c9b9eecb8cf","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-11-23 13:48:20.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"cc6589496fa572f7d02fbe28dd2930260c15e10b","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-11-23 13:48:25.000000000","message":"Change has been successfully cherry-picked as 61fbcbeca83452f3a035f3f4982703096fb5d8ef","accounts_in_message":[],"_revision_number":2}],"current_revision":"61fbcbeca83452f3a035f3f4982703096fb5d8ef","revisions":{"61fbcbeca83452f3a035f3f4982703096fb5d8ef":{"kind":"REWORK","_number":2,"created":"2024-11-23 13:48:25.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/51/8551/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/51/8551/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/51/8551/2 \u0026\u0026 git checkout -b change-8551 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/51/8551/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/51/8551/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/51/8551/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/51/8551/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/51/8551/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b04a58e3fcbfd9a701126473279fa17d37f23784","subject":"target: esirisc: make local functions static"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-11-09 18:21:30.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-11-23 13:48:25.000000000","tz":0},"subject":"semihosting: make local functions static","message":"semihosting: make local functions static\n\nThe functions:\n- semihosting_opcode_to_str();\n- semihosting_write_fields();\n- semihosting_set_field();\nare not referenced outside the file.\n\nMake them static.\n\nChange-Id: Ia8d35554673145fdfe0e501543eb18919863039f\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8551\nTested-by: jenkins\n"}},"71ce62ddff014953502b7e65afa82f7b77ab53ef":{"kind":"REWORK","_number":1,"created":"2024-11-09 21:00:27.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/51/8551/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/51/8551/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/51/8551/1 \u0026\u0026 git checkout -b change-8551 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/51/8551/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/51/8551/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/51/8551/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/51/8551/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/51/8551/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f83b0d5efabe1bb91b755a17be14e9f70b53e63b","subject":"target: esirisc: make local functions static"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-11-09 18:21:30.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-11-09 20:58:55.000000000","tz":60},"subject":"semihosting: make local functions static","message":"semihosting: make local functions static\n\nThe functions:\n- semihosting_opcode_to_str();\n- semihosting_write_fields();\n- semihosting_set_field();\nare not referenced outside the file.\n\nMake them static.\n\nChange-Id: Ia8d35554673145fdfe0e501543eb18919863039f\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}