)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b406e16a1dd1988a4526b2a3c4d46677277089e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0419f164_f1fcf332","updated":"2024-11-11 22:14:44.000000000","message":"Hi Conor, thanks for this series.\n\nI see you pushed this as https://review.openocd.org/c/openocd/+/8371\nthen abandoned and pushed again here.\nIn the future, to keep gerrit history, please don\u0027t abandon a patch and re-push it, but keep the same Change-Id in the commit message and push the new patch version. Gerrit will do the link between the versions.\n\nI have quite some remark and I think I will return on it after your reply.","commit_id":"8e6f9b458ac06f5b25ab2eb1e89f73b3061aae82"},{"author":{"_account_id":1002335,"name":"Conor Paxton","display_name":"con-pax","email":"conor.paxton@microchip.com","username":"con-pax","status":"Microchip"},"change_message_id":"cf2b3d000694533e47b0c5a49fda446c1348fff1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c8df1267_6e4f5b0d","in_reply_to":"0419f164_f1fcf332","updated":"2024-11-18 14:21:23.000000000","message":"Hi Antonio, Thanks a million for taking the time to review this. I will work on your feedback as soon as possible. Apologies are in order, I made a mess of the first push of the patch set. I actually stripped the original change ID from the patches prior to re-applying them so that they would get the change ID from the rebase. I realise now that that was dumb!(I see that the change ID is for Jenkins)\nThanks again, I will get on to your comments starting today\n\n(apologies, I am totally new to Gerrit - I thought I sent this message last week, but it was saved as a draft)","commit_id":"8e6f9b458ac06f5b25ab2eb1e89f73b3061aae82"},{"author":{"_account_id":1002335,"name":"Conor Paxton","display_name":"con-pax","email":"conor.paxton@microchip.com","username":"con-pax","status":"Microchip"},"change_message_id":"485cf97c6e1ed99c7d31caf9c9fdcd720508ee49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"11a9c72a_965c70ae","updated":"2024-11-27 14:44:55.000000000","message":"Hi Antonio, I think I have addressed your comments. I feel very green with Gerrit, I am trying to reply done to each of your comments, however it just gets saved as a draft. Anyway, if you get a chance to re-review (in your own time, of course) it would be much appreciated. Thanks for all the suggestions.\nConor","commit_id":"aa5912f388b2788d081b225213f7a7e276c008fe"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"ea4e6644a990b0b6a268569758d86a1fadf83917","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f7c8beba_1299b5a1","updated":"2025-01-31 05:54:47.000000000","message":"Hi! We have some libusb helpers here: src/jtag/drivers/libusb_helper.c\nPlease use them where possible. If there are some missing, please add new helpers.","commit_id":"c8b8e22c6189307cf4559080e76635f774177b53"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"b2872cf022e52a795e1216ffb962e1af546314fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8a7e8282_626a6bf3","updated":"2025-10-29 09:17:02.000000000","message":"I just rebased the patch to compile after merging\n8675: adapter: use bitmask for driver\u0027s transports | https://review.openocd.org/c/openocd/+/8675","commit_id":"694f439a37ccd233e50843920836af246847ecd8"}],"configure.ac":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b406e16a1dd1988a4526b2a3c4d46677277089e0","unresolved":true,"context_lines":[{"line_number":119,"context_line":"m4_define([ADAPTER_VAR], [enable_[]ADAPTER_ARG($1)])"},{"line_number":120,"context_line":"m4_define([ADAPTER_OPT], [m4_translit(ADAPTER_ARG($1), [_], [-])])"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"m4_define([USB1_ADAPTERS],"},{"line_number":123,"context_line":"\t[[[ftdi], [MPSSE mode of FTDI based devices], [FTDI]],"},{"line_number":124,"context_line":"\t[[stlink], [ST-Link Programmer], [HLADAPTER_STLINK]],"},{"line_number":125,"context_line":"\t[[ti_icdi], [TI ICDI JTAG Programmer], [HLADAPTER_ICDI]],"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"6c942d23_52f2d971","line":122,"updated":"2024-11-11 22:14:44.000000000","message":"The fp6 is libusb based, so you can simply add, in this array, a line\n`\t[[microchip_fp6], [Microchip FlashPro6 Programmer], [MICROCHIP_FP6]],`\nand drop all the other lines you have added below in this file.","commit_id":"8e6f9b458ac06f5b25ab2eb1e89f73b3061aae82"}],"doc/openocd.texi":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b406e16a1dd1988a4526b2a3c4d46677277089e0","unresolved":true,"context_lines":[{"line_number":493,"context_line":"ARM has released a interface standard called CMSIS-DAP that simplifies connecting"},{"line_number":494,"context_line":"debuggers to ARM Cortex based targets @url{http://www.keil.com/support/man/docs/dapdebug/dapdebug_introduction.htm}."},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"@section USB Other"},{"line_number":497,"context_line":"@itemize @bullet"},{"line_number":498,"context_line":"@item @b{USBprog}"},{"line_number":499,"context_line":"@* Link: @url{http://shop.embedded-projects.net/} - which uses an Atmel MEGA32 and a UBN9604"}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"23e6e0ac_1ae578e7","line":496,"updated":"2024-11-11 22:14:44.000000000","message":"Please introduce fp6 here, or in a separate section","commit_id":"8e6f9b458ac06f5b25ab2eb1e89f73b3061aae82"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b406e16a1dd1988a4526b2a3c4d46677277089e0","unresolved":true,"context_lines":[{"line_number":2488,"context_line":"@deffn {Config Command} {adapter serial} serial_string"},{"line_number":2489,"context_line":"Specifies the @var{serial_string} of the adapter to use."},{"line_number":2490,"context_line":"If this command is not specified, serial strings are not checked."},{"line_number":2491,"context_line":"Only the following adapter drivers use the serial string from this command:"},{"line_number":2492,"context_line":"arm-jtag-ew, cmsis_dap, esp_usb_jtag, ft232r, ftdi, hla (ti-icdi), jlink, kitprog, opendus,"},{"line_number":2493,"context_line":"openjtag, osbdm, presto, rlink, st-link, usb_blaster (ublast2), usbprog, vsllink, xds110."},{"line_number":2494,"context_line":"@end deffn"}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"47e1e3d9_e8248007","line":2491,"updated":"2024-11-11 22:14:44.000000000","message":"Maybe after my change proposal, fp6 should be added here too","commit_id":"8e6f9b458ac06f5b25ab2eb1e89f73b3061aae82"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b406e16a1dd1988a4526b2a3c4d46677277089e0","unresolved":true,"context_lines":[{"line_number":2493,"context_line":"openjtag, osbdm, presto, rlink, st-link, usb_blaster (ublast2), usbprog, vsllink, xds110."},{"line_number":2494,"context_line":"@end deffn"},{"line_number":2495,"context_line":""},{"line_number":2496,"context_line":"@section Interface Drivers"},{"line_number":2497,"context_line":""},{"line_number":2498,"context_line":"Each of the interface drivers listed here must be explicitly"},{"line_number":2499,"context_line":"enabled when OpenOCD is configured, in order to be made"}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"f531d854_1171a7e6","line":2496,"updated":"2024-11-11 22:14:44.000000000","message":"Somewhere below we need a new\n```\n@deffn {Interface Driver} {microchip-fp6}\n...\n@end deffn\n```","commit_id":"8e6f9b458ac06f5b25ab2eb1e89f73b3061aae82"}],"src/jtag/drivers/mchp_fp.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b406e16a1dd1988a4526b2a3c4d46677277089e0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"/* SPDX-License-Identifier: GPL-2.0-or-later */"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"#ifndef MCHP_FP"},{"line_number":4,"context_line":"#define MCHP_FP"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"9d4cebea_bfe49235","line":1,"updated":"2024-11-11 22:14:44.000000000","message":"Please add include files only for stuff that need to be shared among files.\nThe info in this and in next include file can be expanded directly inside `mchp_fp6.c`.","commit_id":"8e6f9b458ac06f5b25ab2eb1e89f73b3061aae82"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b406e16a1dd1988a4526b2a3c4d46677277089e0","unresolved":true,"context_lines":[{"line_number":18,"context_line":"#define FP_TARGET_FREQUENCY_ADDRESS\t\t\t0xa0fffff0"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"/* Opcodes */"},{"line_number":21,"context_line":"#define SEND_PACKET_OPCODE\t\t\t\t0x11"},{"line_number":22,"context_line":"#define DDR_REMAP_OPCODE\t\t\t\t0x12"},{"line_number":23,"context_line":"#define ENVM_REMAP_OPCODE\t\t\t\t0x13"},{"line_number":24,"context_line":"#define READ_PRINT_BUFFER_OPCODE\t\t\t0x21"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"bb03413a_fed10a60","line":21,"updated":"2024-11-11 22:14:44.000000000","message":"The TAB size in OpenOCD coding style is 4 spaces.\nHere I see that you have aligned the value of the macros using a TAB of 8 spaces.\nPlease adjust your editor to OpenOCD coding style","commit_id":"8e6f9b458ac06f5b25ab2eb1e89f73b3061aae82"}],"src/jtag/drivers/mchp_fp6.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b406e16a1dd1988a4526b2a3c4d46677277089e0","unresolved":true,"context_lines":[{"line_number":21,"context_line":"struct fp6_ctx {"},{"line_number":22,"context_line":"\tstruct libusb_context *usb_ctx;"},{"line_number":23,"context_line":"\tstruct libusb_device_handle *usb_dev;"},{"line_number":24,"context_line":"\tuint32_t usb_write_timeout;"},{"line_number":25,"context_line":"\tuint32_t usb_read_timeout;"},{"line_number":26,"context_line":"\tuint8_t in_ep;"},{"line_number":27,"context_line":"\tuint8_t out_ep;"},{"line_number":28,"context_line":"\tuint16_t max_packet_size;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"363258d4_7a94df65","line":25,"range":{"start_line":24,"start_character":1,"end_line":25,"end_character":27},"updated":"2024-11-11 22:14:44.000000000","message":"These are used as `timeout` parameter to `libusb_fill_bulk_transfer()` and similar.\nBut `libusb_fill_bulk_transfer()` requires the `timeout` parameter to be `unsigned int`.\nIn OpenOCD we use types from stdint \u0027only\u0027 to match the data size of the target or of the adapter protocol.\nHere, and probably in other fields below, there is no need for stdint types. Please revisit them.\n\nIn this specific case of the `timeout` parameter, you never change the value, but you only assign them once to `FP_READ_TIMEOUT`. Drop these two fields, rename the macro as `TIMEOUT_MS` and use it directly in the code. Or, even use directly the macro `LIBUSB_TIMEOUT_MS` if you don\u0027t mind about the value.","commit_id":"8e6f9b458ac06f5b25ab2eb1e89f73b3061aae82"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b406e16a1dd1988a4526b2a3c4d46677277089e0","unresolved":true,"context_lines":[{"line_number":236,"context_line":"{"},{"line_number":237,"context_line":"\tint retval \u003d ctx-\u003eretval;"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"\tif (retval !\u003d ERROR_OK) {"},{"line_number":240,"context_line":"\t\tLOG_ERROR(\"Ignoring flush due to previous error\");"},{"line_number":241,"context_line":"\t\tassert(ctx-\u003ewrite_count \u003d\u003d 0 \u0026\u0026 ctx-\u003eread_count \u003d\u003d 0);"},{"line_number":242,"context_line":"\t\tctx-\u003eretval \u003d ERROR_OK;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"ce757f6d_5b51b64b","line":239,"updated":"2024-11-11 22:14:44.000000000","message":"Where `ctx-\u003eretval` is assigned to a value different than `ERROR_OK` ?","commit_id":"8e6f9b458ac06f5b25ab2eb1e89f73b3061aae82"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b406e16a1dd1988a4526b2a3c4d46677277089e0","unresolved":true,"context_lines":[{"line_number":252,"context_line":"\tstruct transfer_result read_result \u003d { .ctx \u003d ctx, .done \u003d true };"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"\tif (ctx-\u003eread_count) {"},{"line_number":255,"context_line":"\t\tbuffer_write_byte(ctx, 0x87); /* SEND_IMMEDIATE */"},{"line_number":256,"context_line":"\t\tread_result.done \u003d false;"},{"line_number":257,"context_line":"\t\t/*"},{"line_number":258,"context_line":"\t\t * delay read transaction to ensure the FP6 chip can support us with data"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"69815f59_7b96a18d","line":255,"updated":"2024-11-11 22:14:44.000000000","message":"What is `0x87`? Should be another macro?","commit_id":"8e6f9b458ac06f5b25ab2eb1e89f73b3061aae82"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b406e16a1dd1988a4526b2a3c4d46677277089e0","unresolved":true,"context_lines":[{"line_number":373,"context_line":""},{"line_number":374,"context_line":"\tmemset(\u0026ctx-\u003ewrite_buffer[ctx-\u003ewrite_count + PAYLOAD_PACKET_START_ADDRESS + buf_len], 0, pad_len);"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"\tadd_usb_packet_header(ctx, FP_PACKET_START_CODE, opcode, target_address, buf_len + pad_len, 0xDEAD);"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"\tctx-\u003ewrite_count +\u003d COMMAND_PACKET_LENGTH + buf_len + pad_len;"},{"line_number":379,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"cb113120_c5aefb49","line":376,"updated":"2024-11-11 22:14:44.000000000","message":"What is `0xDEAD` ? Can be another macro?","commit_id":"8e6f9b458ac06f5b25ab2eb1e89f73b3061aae82"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b406e16a1dd1988a4526b2a3c4d46677277089e0","unresolved":true,"context_lines":[{"line_number":380,"context_line":"\treturn err;"},{"line_number":381,"context_line":"}"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"__attribute__((always_inline)) inline"},{"line_number":384,"context_line":"static int construct_and_send_packet(struct fp6_ctx *ctx, uint16_t opcode, uint8_t const *buf,"},{"line_number":385,"context_line":"\t\t\t\t\t\t\t\t\t\t\t\t\tuint32_t buf_len, uint32_t target_address)"},{"line_number":386,"context_line":"{"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"e7aaa73e_c27a0dce","line":383,"updated":"2024-11-11 22:14:44.000000000","message":"I prefer to left the compiler to decided for the inline.\nHere the code speed is not critical because we are always waiting for USB.","commit_id":"8e6f9b458ac06f5b25ab2eb1e89f73b3061aae82"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b406e16a1dd1988a4526b2a3c4d46677277089e0","unresolved":true,"context_lines":[{"line_number":630,"context_line":""},{"line_number":631,"context_line":"static int execute_delay(struct fp6_ctx *ctx, uint32_t ticks)"},{"line_number":632,"context_line":"{"},{"line_number":633,"context_line":"\tuint8_t payload[4] \u003d { 0 };"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"\tpayload[0] \u003d ticks \u003e\u003e 16;"},{"line_number":636,"context_line":"\tpayload[1] \u003d ticks \u003e\u003e 24;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"f268f95c_c1aef408","line":633,"updated":"2024-11-11 22:14:44.000000000","message":"No need for the initialization","commit_id":"8e6f9b458ac06f5b25ab2eb1e89f73b3061aae82"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b406e16a1dd1988a4526b2a3c4d46677277089e0","unresolved":true,"context_lines":[{"line_number":658,"context_line":"\treturn err;"},{"line_number":659,"context_line":"}"},{"line_number":660,"context_line":""},{"line_number":661,"context_line":"static inline uint32_t ROUND_UP8(uint32_t num)"},{"line_number":662,"context_line":"{"},{"line_number":663,"context_line":"\tnum +\u003d 7;"},{"line_number":664,"context_line":"\tnum /\u003d 8;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"5ca5ab1f_6f26eeb4","line":661,"updated":"2024-11-11 22:14:44.000000000","message":"Use the existing macro `ALIGN_UP(num, 8)`","commit_id":"8e6f9b458ac06f5b25ab2eb1e89f73b3061aae82"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b406e16a1dd1988a4526b2a3c4d46677277089e0","unresolved":true,"context_lines":[{"line_number":1010,"context_line":""},{"line_number":1011,"context_line":"\treturn ERROR_OK;"},{"line_number":1012,"context_line":"error:"},{"line_number":1013,"context_line":"\treturn ERROR_FAIL;"},{"line_number":1014,"context_line":"}"},{"line_number":1015,"context_line":""},{"line_number":1016,"context_line":"static int mchp_fp6_execute_statemove(struct fp6_ctx *ctx, struct statemove_command const *cmd)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"4b4ac6bc_e63cafb1","line":1013,"updated":"2024-11-11 22:14:44.000000000","message":"you need to split the on-error path:\n```\nlate_error:\n\tlibusb_exit(ctx);\nerror:\n\tfree(ctx-\u003eread_chunk);\n\tfree(ctx-\u003eread_buffer);\n\tfree(ctx-\u003ewrite_buffer);\n\treturn ERROR_FAIL;\n```","commit_id":"8e6f9b458ac06f5b25ab2eb1e89f73b3061aae82"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b406e16a1dd1988a4526b2a3c4d46677277089e0","unresolved":true,"context_lines":[{"line_number":1162,"context_line":""},{"line_number":1163,"context_line":"static const struct command_registration mchp_fp6_subcommand_handlers[] \u003d {"},{"line_number":1164,"context_line":"\t{"},{"line_number":1165,"context_line":"\t\t.name \u003d \"serial\","},{"line_number":1166,"context_line":"\t\t.handler \u003d mchp_fp6_handle_serial_num,"},{"line_number":1167,"context_line":"\t\t.mode \u003d COMMAND_CONFIG,"},{"line_number":1168,"context_line":"\t\t.help \u003d \"SERIAL_NUM to locate unique FP6\","}],"source_content_type":"text/x-csrc","patch_set":1,"id":"606b2c57_419b3673","line":1165,"updated":"2024-11-11 22:14:44.000000000","message":"No, we have a generic command `adapter serial` that saves the serial string and can be queried with `adapter_get_required_serial()`.\nAll drivers that check serial should use this command.\nAnd, if you use `jtag_libusb_open()` to open the USB device, it will run the check on serial and location for you.","commit_id":"8e6f9b458ac06f5b25ab2eb1e89f73b3061aae82"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b406e16a1dd1988a4526b2a3c4d46677277089e0","unresolved":true,"context_lines":[{"line_number":1182,"context_line":"\tCOMMAND_REGISTRATION_DONE"},{"line_number":1183,"context_line":"};"},{"line_number":1184,"context_line":""},{"line_number":1185,"context_line":"static const char * const mchp_fp6_transports[] \u003d { \"jtag\", NULL };"},{"line_number":1186,"context_line":""},{"line_number":1187,"context_line":"static struct jtag_interface mchp_fp6_interface \u003d {"},{"line_number":1188,"context_line":"\t.supported \u003d 0, /* Don\u0027t support DEBUG_CAP_TMS_SEQ */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"25326c1e_33531277","line":1185,"updated":"2024-11-11 22:14:44.000000000","message":"No need for this, since below you can use:\n`\t.transports \u003d jtag_only,`","commit_id":"8e6f9b458ac06f5b25ab2eb1e89f73b3061aae82"}],"src/jtag/interface.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b406e16a1dd1988a4526b2a3c4d46677277089e0","unresolved":true,"context_lines":[{"line_number":403,"context_line":"extern struct adapter_driver vsllink_adapter_driver;"},{"line_number":404,"context_line":"extern struct adapter_driver xds110_adapter_driver;"},{"line_number":405,"context_line":"extern struct adapter_driver xlnx_pcie_xvc_adapter_driver;"},{"line_number":406,"context_line":"extern struct adapter_driver mchp_fp6_adapter_driver;"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"#endif /* OPENOCD_JTAG_INTERFACE_H */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"8959176d_1fffbd83","line":406,"updated":"2024-11-11 22:14:44.000000000","message":"Please add the line in alphabetic order, between `linuxgpiod_adapter_driver` and `opendous_adapter_driver`","commit_id":"8e6f9b458ac06f5b25ab2eb1e89f73b3061aae82"}],"tcl/board/microchip_riscv_fp6.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b406e16a1dd1988a4526b2a3c4d46677277089e0","unresolved":true,"context_lines":[{"line_number":3,"context_line":"#   Copyright (C) 2015-2018 by Microchip Technology Inc.                  *"},{"line_number":4,"context_line":"#   http://www.microchip.com/support                                      *"},{"line_number":5,"context_line":"#                                                                         *"},{"line_number":6,"context_line":"#   This program is free software; you can redistribute it and/or modify  *"},{"line_number":7,"context_line":"#   it under the terms of the GNU General Public License as published by  *"},{"line_number":8,"context_line":"#   the Free Software Foundation; either version 2 of the License, or     *"},{"line_number":9,"context_line":"#   (at your option) any later version.                                   *"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"b2c7b0e4_bcd8bc4b","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":75},"updated":"2024-11-11 22:14:44.000000000","message":"Please drop the GPL bolierplate, it is fully covered by the SPDX line above.\nBut feel free to keep the copyright by mchp","commit_id":"8e6f9b458ac06f5b25ab2eb1e89f73b3061aae82"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b406e16a1dd1988a4526b2a3c4d46677277089e0","unresolved":true,"context_lines":[{"line_number":18,"context_line":"#**************************************************************************"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"#------------------------------------------------------------------------------"},{"line_number":21,"context_line":"# Microchip RISC-V board"},{"line_number":22,"context_line":"#------------------------------------------------------------------------------"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# Device"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"88065817_4e103211","line":21,"updated":"2024-11-11 22:14:44.000000000","message":"This patch is about the adapter fp6. Why adding a board config file?","commit_id":"8e6f9b458ac06f5b25ab2eb1e89f73b3061aae82"}],"tcl/interface/flashpro6.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b406e16a1dd1988a4526b2a3c4d46677277089e0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# SPDX-License-Identifier: GPL-2.0-or-later"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# FlashPro6"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"adapter driver microchip-fp6"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"6681c2b8_0a30baa5","line":4,"updated":"2024-11-11 22:14:44.000000000","message":"Please add some more info, eventually a web link to the Microchip page with the description and possible a photo of the adapter if it is available standalone","commit_id":"8e6f9b458ac06f5b25ab2eb1e89f73b3061aae82"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b406e16a1dd1988a4526b2a3c4d46677277089e0","unresolved":true,"context_lines":[{"line_number":8,"context_line":"# For a specific FP6"},{"line_number":9,"context_line":"# mchp_fp6 serial 016B047E"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"adapter speed 6000"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"6a7b5983_7480b594","line":11,"updated":"2024-11-11 22:14:44.000000000","message":"We use to put the speed in tcl/target/ cfg file, not in tcl/interface/","commit_id":"8e6f9b458ac06f5b25ab2eb1e89f73b3061aae82"}],"tcl/target/microchip_riscv.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b406e16a1dd1988a4526b2a3c4d46677277089e0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# SPDX-License-Identifier: GPL-2.0-or-later"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"#------------------------------------------------------------------------------"},{"line_number":4,"context_line":"# Microchip RISC-V"},{"line_number":5,"context_line":"#------------------------------------------------------------------------------"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# PolarFire SoC (MPFS) hart id to name lookup table"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"56c7814e_16ac017c","line":4,"updated":"2024-11-11 22:14:44.000000000","message":"This patch is about the fp6 adapter. Why adding a risc-v target? Should this be in a separate patch?\n\nI\u0027m not able to review this file as I\u0027m not used at risc-v config files.","commit_id":"8e6f9b458ac06f5b25ab2eb1e89f73b3061aae82"}]}