)]}'
{"id":"openocd~master~I8609f9807c8bd14eaf6c93acf63fd51b55c9bbbb","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2024-11-23 13:48:52.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I8609f9807c8bd14eaf6c93acf63fd51b55c9bbbb","subject":"helper/jim-nvp.h: Rework \u0027isconfigure\u0027 variable","status":"MERGED","created":"2024-11-10 17:21:06.000000000","updated":"2024-11-23 13:48:52.000000000","submitted":"2024-11-23 13:48:52.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8573","meta_rev_id":"808557692d3a2a119b857e5d595dd4dadd950319","_number":8573,"owner":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-11-23 13:48:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-11-23 13:48:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-11-10 18:07:05.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-11-10 22:17:46.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"344fdbbd8efb0be0c582ef9a4c842658ad192a61","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2024-11-10 17:21:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"89fad22d479d62b543727ce76713377e378ac678","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-11-10 18:07:05.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20201/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19357/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"dabde929d7845b1100f05cf1aee68d2c188a2878","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-11-10 22:17:46.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"62f3136c08a7ae30acccf77647c8c26268b9f82a","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-11-23 13:48:48.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"808557692d3a2a119b857e5d595dd4dadd950319","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-11-23 13:48:52.000000000","message":"Change has been successfully cherry-picked as 8c739a45a042cf7a9b5bba48f0e20cbc3168ee73","accounts_in_message":[],"_revision_number":2}],"current_revision":"8c739a45a042cf7a9b5bba48f0e20cbc3168ee73","revisions":{"8c739a45a042cf7a9b5bba48f0e20cbc3168ee73":{"kind":"REWORK","_number":2,"created":"2024-11-23 13:48:52.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/73/8573/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/73/8573/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/73/8573/2 \u0026\u0026 git checkout -b change-8573 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/73/8573/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/73/8573/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/73/8573/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/73/8573/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/73/8573/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"61fbcbeca83452f3a035f3f4982703096fb5d8ef","subject":"semihosting: make local functions static"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2024-10-21 08:39:28.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-11-23 13:48:52.000000000","tz":0},"subject":"helper/jim-nvp.h: Rework \u0027isconfigure\u0027 variable","message":"helper/jim-nvp.h: Rework \u0027isconfigure\u0027 variable\n\nChange the variable name to \u0027is_configure\u0027 to be compatible with the\ncoding style and use \u0027bool\u0027 as data type.\n\nChange-Id: I8609f9807c8bd14eaf6c93acf63fd51b55c9bbbb\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8573\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"1fad3cbb237a5e994e6648d910c155ad4041a338":{"kind":"REWORK","_number":1,"created":"2024-11-10 17:21:06.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/73/8573/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/73/8573/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/73/8573/1 \u0026\u0026 git checkout -b change-8573 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/73/8573/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/73/8573/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/73/8573/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/73/8573/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/73/8573/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b68d23da3c3bc67cffc750fddd64a6be9c615fdb","subject":"tcl/target/bl702: implement full software reset"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2024-10-21 08:39:28.000000000","tz":120},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2024-11-10 17:18:54.000000000","tz":60},"subject":"helper/jim-nvp.h: Rework \u0027isconfigure\u0027 variable","message":"helper/jim-nvp.h: Rework \u0027isconfigure\u0027 variable\n\nChange the variable name to \u0027is_configure\u0027 to be compatible with the\ncoding style and use \u0027bool\u0027 as data type.\n\nChange-Id: I8609f9807c8bd14eaf6c93acf63fd51b55c9bbbb\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}