)]}'
{"id":"openocd~master~Ie11bf0234574f2a9180d3d3a16efb78e08dfcd86","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001874":{"account":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"last_update":"2024-11-12 10:19:24.000000000","reason":"\u003cGERRIT_ACCOUNT_1001874\u003e replied on the change","reason_account":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"}},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-11-23 13:49:10.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"Ie11bf0234574f2a9180d3d3a16efb78e08dfcd86","subject":"driver: stlink: get adapter speed through adapter_get_speed_khz()","status":"MERGED","created":"2024-11-10 22:54:41.000000000","updated":"2024-11-23 13:49:16.000000000","submitted":"2024-11-23 13:49:16.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8574","meta_rev_id":"50093a405bbac2c821c7b1e0f25c5a096ac7d56b","_number":8574,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-11-23 13:49:16.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-11-23 13:49:16.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-11-23 13:49:16.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-11-10 22:54:41.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"state":"REVIEWER"},{"updated":"2024-11-10 23:10:53.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"4d493af7b037cb0494ac392854abcba4a104e0c8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-11-10 22:54:41.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7b15c79c31559171cbd160a2e9b87aac91bf9de6","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-11-10 23:10:53.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20203/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19359/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"1b9c9619ef96a107348961079927285d9526d18e","author":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"real_author":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"date":"2024-11-12 10:19:24.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"5cd0056dc3bca997aa4bedd130a61037a9daf853","author":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"real_author":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"date":"2024-11-12 12:27:20.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"d8de0136303edd672bd92e68bf1540fbd3800957","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-11-23 13:49:10.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"50093a405bbac2c821c7b1e0f25c5a096ac7d56b","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-11-23 13:49:16.000000000","message":"Change has been successfully cherry-picked as c582cfbf758fdf188b02d8e57e0f57ce9c36663e","accounts_in_message":[],"_revision_number":2}],"current_revision":"c582cfbf758fdf188b02d8e57e0f57ce9c36663e","revisions":{"c582cfbf758fdf188b02d8e57e0f57ce9c36663e":{"kind":"REWORK","_number":2,"created":"2024-11-23 13:49:16.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/74/8574/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/74/8574/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/74/8574/2 \u0026\u0026 git checkout -b change-8574 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/74/8574/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/74/8574/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/74/8574/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/74/8574/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/74/8574/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8c739a45a042cf7a9b5bba48f0e20cbc3168ee73","subject":"helper/jim-nvp.h: Rework \u0027isconfigure\u0027 variable"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-11-10 13:30:25.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-11-23 13:49:16.000000000","tz":0},"subject":"driver: stlink: get adapter speed through adapter_get_speed_khz()","message":"driver: stlink: get adapter speed through adapter_get_speed_khz()\n\nThe stlink driver, both in dapdirect and in HLA modes, pretends to\nstore locally the value of the adapter speed in order to use it\nlater-on during adapter initialization.\nIt doesn\u0027t work in dapdirect mode since the code to store locally\nthe value will not be executed until the adapter is already fully\ninitialized.\n\nThis cause an issue in dapdirect mode:\n- due to the local value, still kept at -1, the adapter will be\n  initialized to the lowest clock speed (5 KHz on stlink v2 in SWD\n  mode);\n- after the adapter initialization the framework will again set\n  the speed with the value requested by the user.\n\nSome target, like nRF51822, only accepts JTAG/SWD speed in a\ndefined range of frequencies. The initial speed of 5 KHz used by\ndapdirect can be out of range, making the target debug port not\nworking.\n\nThe adapter framework already stores the value of speed and makes\nit available through adapter_get_speed_khz().\n\nDrop struct hl_interface_param::initial_interface_speed.\nLet the code to use adapter_get_speed_khz().\n\nChange-Id: Ie11bf0234574f2a9180d3d3a16efb78e08dfcd86\nReported-by: Andrzej Sierżęga \u003casier70@gmail.com\u003e\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8574\nReviewed-by: Andrzej Sierżęga \u003casier70@gmail.com\u003e\nTested-by: jenkins\n"}},"04cc91a1585b8506aae2e2cea486e4073cd76e0a":{"kind":"REWORK","_number":1,"created":"2024-11-10 22:54:41.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/74/8574/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/74/8574/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/74/8574/1 \u0026\u0026 git checkout -b change-8574 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/74/8574/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/74/8574/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/74/8574/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/74/8574/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/74/8574/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b68d23da3c3bc67cffc750fddd64a6be9c615fdb","subject":"tcl/target/bl702: implement full software reset"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-11-10 13:30:25.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-11-10 22:53:18.000000000","tz":60},"subject":"driver: stlink: get adapter speed through adapter_get_speed_khz()","message":"driver: stlink: get adapter speed through adapter_get_speed_khz()\n\nThe stlink driver, both in dapdirect and in HLA modes, pretends to\nstore locally the value of the adapter speed in order to use it\nlater-on during adapter initialization.\nIt doesn\u0027t work in dapdirect mode since the code to store locally\nthe value will not be executed until the adapter is already fully\ninitialized.\n\nThis cause an issue in dapdirect mode:\n- due to the local value, still kept at -1, the adapter will be\n  initialized to the lowest clock speed (5 KHz on stlink v2 in SWD\n  mode);\n- after the adapter initialization the framework will again set\n  the speed with the value requested by the user.\n\nSome target, like nRF51822, only accepts JTAG/SWD speed in a\ndefined range of frequencies. The initial speed of 5 KHz used by\ndapdirect can be out of range, making the target debug port not\nworking.\n\nThe adapter framework already stores the value of speed and makes\nit available through adapter_get_speed_khz().\n\nDrop struct hl_interface_param::initial_interface_speed.\nLet the code to use adapter_get_speed_khz().\n\nChange-Id: Ie11bf0234574f2a9180d3d3a16efb78e08dfcd86\nReported-by: Andrzej Sierżęga \u003casier70@gmail.com\u003e\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}