)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"04647db276f58f6a5ef4c29cd16ebfd1cc0287ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a5939d4a_46519c2f","updated":"2024-11-12 08:40:36.000000000","message":"Thanks.\nBut we also need to discriminate logging from command output.\nSomehow we need to report that command_print() is \"the\" way to output command results and errors, not LOG_xxx().\nI don\u0027t have a complete explanation for how to select:\n- critical errors that will crash OpenOCD (e.g. out of memory) \u003d\u003e LOG_ERROR()\n- messages used to debug OpenOCD \u003d\u003e LOG_DEBUG()\n- information for the user (e.g. discover target type) \u003d\u003e LOG_INFO() or LOG_WARNING()\n- output or errors from a TCL command \u003d\u003e command_print(). Sub-functions of a command that have no `CMD` macro should be reworked to carry `CMD`, but exceptionally can use LOG_xxx().\n- output during polling or during JTAG operation have no `CMD` associated and should use LOG_xxx()\n\nAnything missing?\nIn this same patch or in a new one?","commit_id":"4d302d33c407455428302831f9ddeb221447430a"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"8ba45df1c808fad945ebcd010f192f91c33929af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"04b7496a_76fcb431","in_reply_to":"a5939d4a_46519c2f","updated":"2024-12-15 21:30:10.000000000","message":"Thanks for the input Antonio. I addressed most of your comments, including a short sentence about the distinction between logging and Tcl command output. I would prefer a dedicated section about Tcl command guidelines including output.","commit_id":"4d302d33c407455428302831f9ddeb221447430a"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"fa1101b61e62e95f87d0126e73e4b4042b15b2ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5685787e_384036c9","updated":"2024-12-16 10:00:15.000000000","message":"Thanks! I agree with the proposal, just like to add one rule.","commit_id":"14a1ea5da64e253c5c74a8d8909a1c2111ee50b3"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ea1b6401cec60acdd4858fcc6d1c312c3747e398","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2f068fba_7340a9d9","updated":"2024-12-17 10:58:51.000000000","message":"Thanks","commit_id":"8d9e7c801dcbc2472303dd02ba2e81f60f23d90a"}],"doc/manual/style.txt":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"fa1101b61e62e95f87d0126e73e4b4042b15b2ab","unresolved":true,"context_lines":[{"line_number":235,"context_line":"   - Use `LOG_ERROR()` to provide information in case an operation failed in an unrecoverable way. For example, if necessary memory cannot be allocated."},{"line_number":236,"context_line":"   - Use `LOG_WARNING()` to inform the user of about an unexpected behavior that can be handled and the intended operation is still be performed. For example, in case a command is deprecated but is nevertheless executed."},{"line_number":237,"context_line":"   - Use `LOG_INFO()` to provide insightful or necessary information to the user. For example, features or capabilities of a discovered target."},{"line_number":238,"context_line":"   - Use `LOG_DEBUG()` to provide information for troubleshooting. For example, detailed information which makes it easier to debug a specific operation."},{"line_number":239,"context_line":"   - Use `LOG_DEBUG_IO()` to provide I/O related information for troubleshooting. For example, details about the communication between OpenOCD and a debug adapter."},{"line_number":240,"context_line":" - If the log message is related to a target, use the corresponding `LOG_TARGET_xxx()` functions."},{"line_number":241,"context_line":" - Do not use a period or exclamation mark at the end of a message."}],"source_content_type":"text/plain","patch_set":2,"id":"d94e7f42_947df4d4","line":238,"range":{"start_line":238,"start_character":10,"end_line":238,"end_character":19},"updated":"2024-12-16 10:00:15.000000000","message":"I\u0027d like to add something like:\nTry to avoid flooding the log by emitting LOG_DEBUG() messages at each target poll. Use LOG_DEBUG_IO() for such frequent messages.","commit_id":"14a1ea5da64e253c5c74a8d8909a1c2111ee50b3"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ea1b6401cec60acdd4858fcc6d1c312c3747e398","unresolved":false,"context_lines":[{"line_number":235,"context_line":"   - Use `LOG_ERROR()` to provide information in case an operation failed in an unrecoverable way. For example, if necessary memory cannot be allocated."},{"line_number":236,"context_line":"   - Use `LOG_WARNING()` to inform the user of about an unexpected behavior that can be handled and the intended operation is still be performed. For example, in case a command is deprecated but is nevertheless executed."},{"line_number":237,"context_line":"   - Use `LOG_INFO()` to provide insightful or necessary information to the user. For example, features or capabilities of a discovered target."},{"line_number":238,"context_line":"   - Use `LOG_DEBUG()` to provide information for troubleshooting. For example, detailed information which makes it easier to debug a specific operation."},{"line_number":239,"context_line":"   - Use `LOG_DEBUG_IO()` to provide I/O related information for troubleshooting. For example, details about the communication between OpenOCD and a debug adapter."},{"line_number":240,"context_line":" - If the log message is related to a target, use the corresponding `LOG_TARGET_xxx()` functions."},{"line_number":241,"context_line":" - Do not use a period or exclamation mark at the end of a message."}],"source_content_type":"text/plain","patch_set":2,"id":"e8d63aa2_0eb4a5d5","line":238,"range":{"start_line":238,"start_character":10,"end_line":238,"end_character":19},"in_reply_to":"d94e7f42_947df4d4","updated":"2024-12-17 10:58:51.000000000","message":"Done","commit_id":"14a1ea5da64e253c5c74a8d8909a1c2111ee50b3"}]}