)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"ac8bafd5197143fcd85542d423955e2e774df0ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"73125808_52ab62d3","updated":"2024-11-18 10:13:33.000000000","message":"LGTM. Only a minor suggestion.","commit_id":"8f6a99874837b50774d629dfe93b60562519feeb"}],"src/target/target.c":[{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"ac8bafd5197143fcd85542d423955e2e774df0ac","unresolved":true,"context_lines":[{"line_number":4636,"context_line":"\t\tif (retval !\u003d ERROR_OK) {"},{"line_number":4637,"context_line":"\t\t\tLOG_DEBUG(\"write_memory: write at \" TARGET_ADDR_FMT \" with width\u003d%u and count\u003d%zu failed\","},{"line_number":4638,"context_line":"\t\t\t\taddr,  width_bits, chunk_len);"},{"line_number":4639,"context_line":"\t\t\tcommand_print(CMD, \"write_memory: failed to write memory\");"},{"line_number":4640,"context_line":"\t\t\tfree(buffer);"},{"line_number":4641,"context_line":"\t\t\treturn retval;"},{"line_number":4642,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"b33ded81_5d425c31","line":4639,"updated":"2024-11-18 10:13:33.000000000","message":"IMHO, it would be a bit more robust to use `\"%s: ...` and `CMD_NAME` instead of writing command name explicitly.","commit_id":"8f6a99874837b50774d629dfe93b60562519feeb"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"6f4fb29f203251440002b1d0ef7c4c101e5e7e19","unresolved":false,"context_lines":[{"line_number":4636,"context_line":"\t\tif (retval !\u003d ERROR_OK) {"},{"line_number":4637,"context_line":"\t\t\tLOG_DEBUG(\"write_memory: write at \" TARGET_ADDR_FMT \" with width\u003d%u and count\u003d%zu failed\","},{"line_number":4638,"context_line":"\t\t\t\taddr,  width_bits, chunk_len);"},{"line_number":4639,"context_line":"\t\t\tcommand_print(CMD, \"write_memory: failed to write memory\");"},{"line_number":4640,"context_line":"\t\t\tfree(buffer);"},{"line_number":4641,"context_line":"\t\t\treturn retval;"},{"line_number":4642,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"56361623_e73d8f67","line":4639,"in_reply_to":"097bc0fc_73541dcc","updated":"2025-03-09 14:12:40.000000000","message":"Done","commit_id":"8f6a99874837b50774d629dfe93b60562519feeb"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e58ddbedf943fa94ae750beb10a93bd873459713","unresolved":true,"context_lines":[{"line_number":4636,"context_line":"\t\tif (retval !\u003d ERROR_OK) {"},{"line_number":4637,"context_line":"\t\t\tLOG_DEBUG(\"write_memory: write at \" TARGET_ADDR_FMT \" with width\u003d%u and count\u003d%zu failed\","},{"line_number":4638,"context_line":"\t\t\t\taddr,  width_bits, chunk_len);"},{"line_number":4639,"context_line":"\t\t\tcommand_print(CMD, \"write_memory: failed to write memory\");"},{"line_number":4640,"context_line":"\t\t\tfree(buffer);"},{"line_number":4641,"context_line":"\t\t\treturn retval;"},{"line_number":4642,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"097bc0fc_73541dcc","line":4639,"in_reply_to":"b33ded81_5d425c31","updated":"2024-11-23 17:54:07.000000000","message":"I have just lazily converted it to `command_print()`, but actually there should be no need for the command name in the error message.\nI think we need to improve the way we print-out the errors, but not adding extra text the each error message.\nI will drop the command name, also in `read_memory`.","commit_id":"8f6a99874837b50774d629dfe93b60562519feeb"}]}