)]}'
{"id":"openocd~master~I399402ac11b6d459f1771e59e44210aef3e2a637","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2025-03-09 14:12:40.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1002047":{"account":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"last_update":"2025-03-10 06:33:07.000000000","reason":"\u003cGERRIT_ACCOUNT_1002047\u003e replied on the change","reason_account":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"}}},"hashtags":[],"change_id":"I399402ac11b6d459f1771e59e44210aef3e2a637","subject":"target: rewrite command \u0027write_memory\u0027 as COMMAND_HANDLER","status":"MERGED","created":"2024-11-16 15:01:56.000000000","updated":"2025-03-29 18:23:15.000000000","submitted":"2025-03-29 18:23:15.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8582","meta_rev_id":"08136d037216b765fca13a77ab0775273791d25e","_number":8582,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-03-29 18:23:15.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-03-29 18:23:15.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-03-29 18:23:15.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-11-16 15:19:01.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-11-18 10:13:33.000000000","updated_by":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"reviewer":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"state":"REVIEWER"}],"messages":[{"id":"ec3c144566ca182e912db8a71e403b55dc09a0ef","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-11-16 15:01:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"417313ad2f0b1ea160e8ee8e8c6dc1e413e6f084","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-11-16 15:19:01.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/19380/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit/20224/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"a2e612e2b0a4fb8b8585aa6bf57f7f0ef293a83a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-11-16 15:49:06.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"33cf609eb15d0ba1cd547c37ab005ff90126907f","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-11-16 16:31:56.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20229/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19383/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"46ffb2bad6b658d2ad1899db8ce1cf713e025c11","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-11-17 15:41:32.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"ac8bafd5197143fcd85542d423955e2e774df0ac","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2024-11-18 10:13:33.000000000","message":"Patch Set 2: Code-Review+1\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"e58ddbedf943fa94ae750beb10a93bd873459713","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-11-23 17:54:07.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"5b946812e607b122d0c32b686d2dc190cdee58ad","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-03-09 14:11:14.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Code-Review+1, Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"6f4fb29f203251440002b1d0ef7c4c101e5e7e19","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-03-09 14:12:40.000000000","message":"Patch Set 3: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"82d5e83230c8e04c57ee0e12ecf7bba80210e4a5","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-03-09 14:32:32.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20031/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/20892/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"8e7fb61f4b1bf3693337e88fb7f707815e5f0cda","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2025-03-10 06:33:07.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"b31bafb7f965dbceef0c93b9969cc655fcb15900","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-03-29 18:23:07.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"08136d037216b765fca13a77ab0775273791d25e","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-03-29 18:23:15.000000000","message":"Change has been successfully cherry-picked as f55ec6d4492251a453eb441dfd427b5f4ca4e452","accounts_in_message":[],"_revision_number":4}],"current_revision":"f55ec6d4492251a453eb441dfd427b5f4ca4e452","revisions":{"f55ec6d4492251a453eb441dfd427b5f4ca4e452":{"kind":"REWORK","_number":4,"created":"2025-03-29 18:23:15.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/82/8582/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/82/8582/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/82/8582/4 \u0026\u0026 git checkout -b change-8582 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/82/8582/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/82/8582/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/82/8582/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/82/8582/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/82/8582/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"864e1341ada378db6a553b2f13ef7741ffcede51","subject":"target: read_memory: drop command name from error messages"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-12-02 13:21:42.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-03-29 18:23:15.000000000","tz":0},"subject":"target: rewrite command \u0027write_memory\u0027 as COMMAND_HANDLER","message":"target: rewrite command \u0027write_memory\u0027 as COMMAND_HANDLER\n\nWhile there:\n- drop the command name from the error messages;\n- check the returned value from Jim_GetWide() to detect incorrect\n  numeric values.\n\nChange-Id: I399402ac11b6d459f1771e59e44210aef3e2a637\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8582\nTested-by: jenkins\nReviewed-by: Evgeniy Naydanov \u003cevgeniy.naydanov@syntacore.com\u003e\n"}},"bd6ad91956c6f214257ed3bf4b884118ce91af74":{"kind":"REWORK","_number":1,"created":"2024-11-16 15:01:56.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/82/8582/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/82/8582/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/82/8582/1 \u0026\u0026 git checkout -b change-8582 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/82/8582/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/82/8582/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/82/8582/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/82/8582/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/82/8582/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8a3723022689dd078c3e61268615616d5566fc94","subject":"checkpatch: exclude gerrit\u0027s Change-Id line from commit description"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-12-02 13:21:42.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-11-16 14:32:38.000000000","tz":60},"subject":"target: rewrite command \u0027write_memory\u0027 as COMMAND_HANDLER","message":"target: rewrite command \u0027write_memory\u0027 as COMMAND_HANDLER\n\nWhile there, check the returned value from Jim_GetWide() to detect\nincorrect numeric values.\n\nChange-Id: I399402ac11b6d459f1771e59e44210aef3e2a637\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"22e35b0e78f63758a4c4eddfcfb431431434a70e":{"kind":"REWORK","_number":3,"created":"2025-03-09 14:11:14.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/82/8582/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/82/8582/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/82/8582/3 \u0026\u0026 git checkout -b change-8582 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/82/8582/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/82/8582/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/82/8582/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/82/8582/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/82/8582/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cc4c9ddf347a85e18743742f3bf2a2636b1e56f0","subject":"target: read_memory: drop command name from error messages"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-12-02 13:21:42.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-03-09 14:02:54.000000000","tz":60},"subject":"target: rewrite command \u0027write_memory\u0027 as COMMAND_HANDLER","message":"target: rewrite command \u0027write_memory\u0027 as COMMAND_HANDLER\n\nWhile there:\n- drop the command name from the error messages;\n- check the returned value from Jim_GetWide() to detect incorrect\n  numeric values.\n\nChange-Id: I399402ac11b6d459f1771e59e44210aef3e2a637\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"8f6a99874837b50774d629dfe93b60562519feeb":{"kind":"REWORK","_number":2,"created":"2024-11-16 15:49:06.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/82/8582/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/82/8582/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/82/8582/2 \u0026\u0026 git checkout -b change-8582 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/82/8582/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/82/8582/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/82/8582/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/82/8582/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/82/8582/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8a3723022689dd078c3e61268615616d5566fc94","subject":"checkpatch: exclude gerrit\u0027s Change-Id line from commit description"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-12-02 13:21:42.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-11-16 15:48:24.000000000","tz":60},"subject":"target: rewrite command \u0027write_memory\u0027 as COMMAND_HANDLER","message":"target: rewrite command \u0027write_memory\u0027 as COMMAND_HANDLER\n\nWhile there, check the returned value from Jim_GetWide() to detect\nincorrect numeric values.\n\nChange-Id: I399402ac11b6d459f1771e59e44210aef3e2a637\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}