)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"d6ef04fc65571b2449503fbdf0188bbeb8f1755c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"42b33afa_20bf368b","updated":"2024-11-18 08:24:55.000000000","message":"LGTM. Only one minor comment, please take a look.","commit_id":"015a7ed7f090c6c48bb871728a15240966fb009c"}],"src/helper/command.c":[{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"d6ef04fc65571b2449503fbdf0188bbeb8f1755c","unresolved":true,"context_lines":[{"line_number":793,"context_line":"\t\t\t\tcase COMMAND_ANY:"},{"line_number":794,"context_line":"\t\t\t\t\tstage_msg \u003d \" (command valid any time)\";"},{"line_number":795,"context_line":"\t\t\t\t\tbreak;"},{"line_number":796,"context_line":"\t\t\t\tdefault:"},{"line_number":797,"context_line":"\t\t\t\t\tstage_msg \u003d \" (?mode error?)\";"},{"line_number":798,"context_line":"\t\t\t\t\tbreak;"},{"line_number":799,"context_line":"\t\t\t}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"5ca55227_7ff9358f","line":796,"updated":"2024-11-18 08:24:55.000000000","message":"Minor inconsistency:\nYou\u0027ve added `case COMMAND_UNKNOWN:` to a similar switch in `jim_command_mode/handle_command_mode` but have not added it here.\nIs there some meaning behind it that I\u0027m missing?","commit_id":"015a7ed7f090c6c48bb871728a15240966fb009c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"178c69d76590d19bc9820a7e3742361adb720ab6","unresolved":false,"context_lines":[{"line_number":793,"context_line":"\t\t\t\tcase COMMAND_ANY:"},{"line_number":794,"context_line":"\t\t\t\t\tstage_msg \u003d \" (command valid any time)\";"},{"line_number":795,"context_line":"\t\t\t\t\tbreak;"},{"line_number":796,"context_line":"\t\t\t\tdefault:"},{"line_number":797,"context_line":"\t\t\t\t\tstage_msg \u003d \" (?mode error?)\";"},{"line_number":798,"context_line":"\t\t\t\t\tbreak;"},{"line_number":799,"context_line":"\t\t\t}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"b548f33f_8b014b55","line":796,"in_reply_to":"5ca55227_7ff9358f","updated":"2025-03-09 14:14:05.000000000","message":"While `default` covers it, I agree it would be more readable adding explicitly `COMMAND_UNKNOWN`.\nDone!","commit_id":"015a7ed7f090c6c48bb871728a15240966fb009c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a3cdf51524b57b8fb5e3112596d777b2bd832d8e","unresolved":false,"context_lines":[{"line_number":793,"context_line":"\t\t\t\tcase COMMAND_ANY:"},{"line_number":794,"context_line":"\t\t\t\t\tstage_msg \u003d \" (command valid any time)\";"},{"line_number":795,"context_line":"\t\t\t\t\tbreak;"},{"line_number":796,"context_line":"\t\t\t\tdefault:"},{"line_number":797,"context_line":"\t\t\t\t\tstage_msg \u003d \" (?mode error?)\";"},{"line_number":798,"context_line":"\t\t\t\t\tbreak;"},{"line_number":799,"context_line":"\t\t\t}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"244fc9d7_7d203cb3","line":796,"in_reply_to":"766315dc_71af68a5","updated":"2025-03-10 08:09:33.000000000","message":"Sorry, mistake during rebase.\nRe-pushed.\nThanks for your inputs","commit_id":"015a7ed7f090c6c48bb871728a15240966fb009c"},{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"b340055addcbd986dd3e248a5f09a0eed482e625","unresolved":false,"context_lines":[{"line_number":793,"context_line":"\t\t\t\tcase COMMAND_ANY:"},{"line_number":794,"context_line":"\t\t\t\t\tstage_msg \u003d \" (command valid any time)\";"},{"line_number":795,"context_line":"\t\t\t\t\tbreak;"},{"line_number":796,"context_line":"\t\t\t\tdefault:"},{"line_number":797,"context_line":"\t\t\t\t\tstage_msg \u003d \" (?mode error?)\";"},{"line_number":798,"context_line":"\t\t\t\t\tbreak;"},{"line_number":799,"context_line":"\t\t\t}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"766315dc_71af68a5","line":796,"in_reply_to":"b548f33f_8b014b55","updated":"2025-03-10 06:46:17.000000000","message":"Sorry to bother you about such a minor thing, but are you sure? I don\u0027t see it in the diff between the patchsets:\nhttps://review.openocd.org/c/openocd/+/8585/1..3","commit_id":"015a7ed7f090c6c48bb871728a15240966fb009c"}]}