)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"e9736ce8504765aa02579b0f429f936bfc5b0889","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"65d18e73_259f6d32","updated":"2024-11-18 09:21:33.000000000","message":"Thanks for the patch!\n\nPlease take a look at my suggestion. I find the work with `capture` output in current state too convoluted and propose a simplification.","commit_id":"0d3a6afd9e30a2d04b62ebeb86061f1e11da347c"}],"src/helper/command.c":[{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"e9736ce8504765aa02579b0f429f936bfc5b0889","unresolved":true,"context_lines":[{"line_number":705,"context_line":"\tcommand_log_capture_finish(state);"},{"line_number":706,"context_line":""},{"line_number":707,"context_line":"\tint reslen;"},{"line_number":708,"context_line":"\tconst char *result \u003d Jim_GetString(Jim_GetResult(CMD_CTX-\u003einterp), \u0026reslen);"},{"line_number":709,"context_line":"\tif (reslen \u003e 0)"},{"line_number":710,"context_line":"\t\tcommand_print(CMD, \"%s\", result);"},{"line_number":711,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"dcf3cc54_a75596f7","line":708,"updated":"2024-11-18 09:21:33.000000000","message":"IMHO, it will be better to make `command_log_capture_finish()` a `COMMAND_HELPER` and call the `command_print` there directly.\nThis will make the confusing sequence of `Jim_SetResult` in `command_log_capture_finish` immediately followed by `Jim_GetResult` here unnecessary.","commit_id":"0d3a6afd9e30a2d04b62ebeb86061f1e11da347c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"531c95731544675b5f9f63ca823227b47661e7e6","unresolved":false,"context_lines":[{"line_number":705,"context_line":"\tcommand_log_capture_finish(state);"},{"line_number":706,"context_line":""},{"line_number":707,"context_line":"\tint reslen;"},{"line_number":708,"context_line":"\tconst char *result \u003d Jim_GetString(Jim_GetResult(CMD_CTX-\u003einterp), \u0026reslen);"},{"line_number":709,"context_line":"\tif (reslen \u003e 0)"},{"line_number":710,"context_line":"\t\tcommand_print(CMD, \"%s\", result);"},{"line_number":711,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"4c727e01_26828a40","line":708,"in_reply_to":"bffafd08_f3bb7c33","updated":"2025-03-29 23:35:13.000000000","message":"Actually you are right.\nThis new version further drop Jim API, making the code way more readable.\nThanks!","commit_id":"0d3a6afd9e30a2d04b62ebeb86061f1e11da347c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"4540930d7f4fab627ccdfbd6ba186b8406cabbf2","unresolved":false,"context_lines":[{"line_number":705,"context_line":"\tcommand_log_capture_finish(state);"},{"line_number":706,"context_line":""},{"line_number":707,"context_line":"\tint reslen;"},{"line_number":708,"context_line":"\tconst char *result \u003d Jim_GetString(Jim_GetResult(CMD_CTX-\u003einterp), \u0026reslen);"},{"line_number":709,"context_line":"\tif (reslen \u003e 0)"},{"line_number":710,"context_line":"\t\tcommand_print(CMD, \"%s\", result);"},{"line_number":711,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"bffafd08_f3bb7c33","line":708,"in_reply_to":"dcf3cc54_a75596f7","updated":"2025-03-29 22:27:06.000000000","message":"Actually passing through the Jim result was done on purpose to let this code looks like a Jim command that generates a result.\nAnyway this code has to be further reworked to reduce the exposure to Jim API, and I hope what you find that looks confusing will disappear.\nFor the moment I\u0027m only addressing the rewriting of commands as `COMMAND_HANDLER` to drop a big chunk of Jim API from OpenOCD.\nA second step will address these internals.","commit_id":"0d3a6afd9e30a2d04b62ebeb86061f1e11da347c"}]}