)]}'
{"id":"openocd~master~Ibb74db3d90ac6d1589b9dc1e5a7ae59e47945e78","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-11-23 14:12:27.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}},"hashtags":[],"change_id":"Ibb74db3d90ac6d1589b9dc1e5a7ae59e47945e78","subject":"configure: make more robust the check for elf 64","status":"MERGED","created":"2024-11-17 22:09:25.000000000","updated":"2025-01-25 10:36:11.000000000","submitted":"2025-01-25 10:36:11.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8591","meta_rev_id":"4b83d24a61c34ae16b6bedc80e3137a90a970ae8","_number":8591,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-01-25 10:36:11.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-01-25 10:36:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-11-17 22:21:48.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"8cc39851d90ee93e8b58c575050dce8602eb9476","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-11-17 22:09:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ab48fb4f009ace7c6cd652e3f22797cf266af027","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-11-17 22:21:48.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/19396/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit/20240/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"adc6cd4f7929a95d3beea603f1d699ebb5bf7b67","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-11-18 09:01:25.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"d8a6a7d17afb44163e0c51cc99b6b985f17c49a4","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-11-18 09:23:41.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20244/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19398/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"c10b3d45588cd17a657f35fef893de710a54b29d","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-11-23 14:12:27.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"6430d01ed759742e89c7a4f5b96ae70aea63681b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-01-25 10:35:58.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"4b83d24a61c34ae16b6bedc80e3137a90a970ae8","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-01-25 10:36:11.000000000","message":"Change has been successfully cherry-picked as ac18b8cd6a3f21b97f942efdbb0ec2f362bb132b","accounts_in_message":[],"_revision_number":3}],"current_revision":"ac18b8cd6a3f21b97f942efdbb0ec2f362bb132b","revisions":{"41f02b8c4ac2a59082440e7342a5827e34e99bdb":{"kind":"REWORK","_number":1,"created":"2024-11-17 22:09:25.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/91/8591/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/91/8591/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/91/8591/1 \u0026\u0026 git checkout -b change-8591 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/91/8591/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/91/8591/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/91/8591/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/91/8591/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/91/8591/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8a3723022689dd078c3e61268615616d5566fc94","subject":"checkpatch: exclude gerrit\u0027s Change-Id line from commit description"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-11-17 20:35:45.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-11-17 21:49:37.000000000","tz":60},"subject":"configure: make more robust the check for elf 64","message":"configure: make more robust the check for elf 64\n\nThe check if \u0027elf.h\u0027 defines the type \u0027Elf64_Ehdr\u0027 is currently\ndone through \u0027grep\u0027 on the file. While there is no false positive,\nso far, such test could incorrectly find the text inside a comment\nor in a block guarded by #if/#endif.\n\nUse the autoconf macro AC_CHECK_TYPE() to detect if the type is\nproperly declared.\n\nChange-Id: Ibb74db3d90ac6d1589b9dc1e5a7ae59e47945e78\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"ac18b8cd6a3f21b97f942efdbb0ec2f362bb132b":{"kind":"REWORK","_number":3,"created":"2025-01-25 10:36:11.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/91/8591/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/91/8591/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/91/8591/3 \u0026\u0026 git checkout -b change-8591 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/91/8591/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/91/8591/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/91/8591/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/91/8591/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/91/8591/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"345473f3ceaf6a1241f62354e31eeababfc56588","subject":"helper/options: handle errors in `-l`"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-11-17 20:35:45.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-01-25 10:36:11.000000000","tz":0},"subject":"configure: make more robust the check for elf 64","message":"configure: make more robust the check for elf 64\n\nThe check if \u0027elf.h\u0027 defines the type \u0027Elf64_Ehdr\u0027 is currently\ndone through \u0027grep\u0027 on the file. While there is no false positive,\nso far, such test could incorrectly find the text inside a comment\nor in a block guarded by #if/#endif.\n\nUse the autoconf macro AC_CHECK_TYPE() to detect if the type is\nproperly declared.\n\nChange-Id: Ibb74db3d90ac6d1589b9dc1e5a7ae59e47945e78\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8591\nTested-by: jenkins\n"}},"41cd7cd10c3a78ad7d84ca62e194169fa4d42678":{"kind":"REWORK","_number":2,"created":"2024-11-18 09:01:25.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/91/8591/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/91/8591/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/91/8591/2 \u0026\u0026 git checkout -b change-8591 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/91/8591/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/91/8591/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/91/8591/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/91/8591/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/91/8591/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8a3723022689dd078c3e61268615616d5566fc94","subject":"checkpatch: exclude gerrit\u0027s Change-Id line from commit description"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-11-17 20:35:45.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-11-18 09:00:11.000000000","tz":60},"subject":"configure: make more robust the check for elf 64","message":"configure: make more robust the check for elf 64\n\nThe check if \u0027elf.h\u0027 defines the type \u0027Elf64_Ehdr\u0027 is currently\ndone through \u0027grep\u0027 on the file. While there is no false positive,\nso far, such test could incorrectly find the text inside a comment\nor in a block guarded by #if/#endif.\n\nUse the autoconf macro AC_CHECK_TYPE() to detect if the type is\nproperly declared.\n\nChange-Id: Ibb74db3d90ac6d1589b9dc1e5a7ae59e47945e78\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}