)]}'
{"id":"openocd~master~I06473c2c8088b38ee07118bcc9e49bc8eafbc6e2","project":"openocd","branch":"master","hashtags":[],"change_id":"I06473c2c8088b38ee07118bcc9e49bc8eafbc6e2","subject":"target: aarch64: fix out-of-bound access to array","status":"MERGED","created":"2024-11-25 14:11:07.000000000","updated":"2024-12-22 09:50:50.000000000","submitted":"2024-12-22 09:50:50.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8594","meta_rev_id":"a38b9363d77d354fa25abd2acec305a85042de4b","_number":8594,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-12-22 09:50:50.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-12-22 09:50:50.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-11-25 14:29:20.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"1ee26e029a8aa4903b3f863be6a3728efe66b658","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-11-25 14:11:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3d1adc36dc987984a6b09be9f933d5d001d8057b","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-11-25 14:29:20.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20279/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19433/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"3e603ae51594e5fc0c93351e9635f260fdcdb812","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-11-25 14:43:26.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"bf1b09c752de2de4d1f06fc3c3807c78475dadd3","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-12-22 09:50:47.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"a38b9363d77d354fa25abd2acec305a85042de4b","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-12-22 09:50:50.000000000","message":"Change has been successfully cherry-picked as 42f70a3b95ea708d0e4fd5d83a6bc6965fd65ac6","accounts_in_message":[],"_revision_number":2}],"current_revision":"42f70a3b95ea708d0e4fd5d83a6bc6965fd65ac6","revisions":{"7638c8285206068d129c1bd13e14d3ff9949debe":{"kind":"REWORK","_number":1,"created":"2024-11-25 14:11:07.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/94/8594/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/94/8594/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/94/8594/1 \u0026\u0026 git checkout -b change-8594 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/94/8594/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/94/8594/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/94/8594/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/94/8594/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/94/8594/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"133dd9d669e5b8beb7c7787b0be677621808e72d","subject":"target/xtensa: add maskisr command support for NX"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-11-22 17:06:40.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-11-25 14:09:51.000000000","tz":60},"subject":"target: aarch64: fix out-of-bound access to array","message":"target: aarch64: fix out-of-bound access to array\n\nThe command \u0027arm core_state\u0027 uses the enum in \u0027arm-\u003ecore_state\u0027 as\nan index in the table of strings to print the core state.\n\nWith [1] the enum has been extended with the new state for AArch64\nbut not the corresponding table of strings.\nThis causes an access after the limit of arm_state_strings[].\n\nRewrite the table using c99 array designators to better show the\nlink between the enum list and the table.\nAdd the function arm_core_state_string() to check for out-of-bound\nvalues allover the file.\n\nChange-Id: I06473c2c8088b38ee07118bcc9e49bc8eafbc6e2\nFixes: [1] 9cbfc9feb35c (\"arm_dpm: Add new state ARM_STATE_AARCH64\")\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"42f70a3b95ea708d0e4fd5d83a6bc6965fd65ac6":{"kind":"REWORK","_number":2,"created":"2024-12-22 09:50:50.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/94/8594/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/94/8594/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/94/8594/2 \u0026\u0026 git checkout -b change-8594 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/94/8594/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/94/8594/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/94/8594/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/94/8594/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/94/8594/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1710954977a0262e6987426f117aab0f73b27024","subject":"doc/manual: Add section about logging"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-11-22 17:06:40.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-12-22 09:50:50.000000000","tz":0},"subject":"target: aarch64: fix out-of-bound access to array","message":"target: aarch64: fix out-of-bound access to array\n\nThe command \u0027arm core_state\u0027 uses the enum in \u0027arm-\u003ecore_state\u0027 as\nan index in the table of strings to print the core state.\n\nWith [1] the enum has been extended with the new state for AArch64\nbut not the corresponding table of strings.\nThis causes an access after the limit of arm_state_strings[].\n\nRewrite the table using c99 array designators to better show the\nlink between the enum list and the table.\nAdd the function arm_core_state_string() to check for out-of-bound\nvalues allover the file.\n\nChange-Id: I06473c2c8088b38ee07118bcc9e49bc8eafbc6e2\nFixes: [1] 9cbfc9feb35c (\"arm_dpm: Add new state ARM_STATE_AARCH64\")\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8594\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}