)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c1edae770023ca88ca6ea68141fd3fe1a9f4cf68","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5c6a6aab_c0ba88ec","updated":"2024-11-27 08:53:29.000000000","message":"I would have preferred including only the system files we need. We include way too much in every file of OpenOCD, and this slows-down the speed of incremental builds.\nAnyway, let\u0027s fix the build issue asap.\n\nTomas, you introduced the parameter `struct timeval *wait_timeout` in https://review.openocd.org/c/openocd/+/7365\nbut it is currently unused.\nCan it be dropped, simplifying the API and removing the need to this fix?\nI think I can handle it, if you agree and cannot work on it","commit_id":"aad47bd340b6ccb54245c36621adfe62a0fe8047"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"bc62580209b5a53700ae396a8ed126742328553b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"de68b536_9b71c65c","updated":"2024-12-10 08:59:32.000000000","message":"Paul, please test 8639: drivers/cmsis_dap: use blocking flag instead of wait timeout | https://review.openocd.org/c/openocd/+/8639","commit_id":"aad47bd340b6ccb54245c36621adfe62a0fe8047"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"aa6c231d6d4e65b770dfb54411237f736f4a4123","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b0f2caca_d7898924","updated":"2025-01-25 13:30:41.000000000","message":"With https://review.openocd.org/c/openocd/+/8639 merged, I think this can be abandoned","commit_id":"aad47bd340b6ccb54245c36621adfe62a0fe8047"},{"author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"change_message_id":"5b806383baba0651ac568dbc1ab7ec733e0a538e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"29d6c388_86d35e77","updated":"2024-11-27 09:06:19.000000000","message":"struct timeval is introduced and used for async libusb calls afaict, so it\u0027s needed. Plenty of other jtag adapter drivers include the time helper header.","commit_id":"aad47bd340b6ccb54245c36621adfe62a0fe8047"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"8687f78287aea380f5924b3bee6c6082aabaf8fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c6f9d8e1_90d89cac","in_reply_to":"29d6c388_86d35e77","updated":"2024-11-27 10:13:11.000000000","message":"All the calls to `struct cmsis_dap_backend::read()` pass `NULL` for `struct timeval *`, apart for one case.\nThis single case can be rewritten to use the existing parameter `transfer_timeout_ms`, as the value returned in `struct timeval *` is not used by the caller.\nBut I would like to know from Tomas why this was introduced and if he has some further dev that requires it. Otherwise, let\u0027s simplify the code!","commit_id":"aad47bd340b6ccb54245c36621adfe62a0fe8047"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"536b0577fe26ec410953b5b338ac007a304a2a08","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"97cd5f90_b71af57e","in_reply_to":"c6f9d8e1_90d89cac","updated":"2024-12-03 05:34:41.000000000","message":"Antonio, you\u0027re right it can be simplified. `struct timeval *` is a leftover from the development versions where I tried to use sub-millisecond timing. It didn\u0027t prove to be useful. However `read()` should know at least about blocking instead of `struct timeval *`: transfer_timeout_ms is filled to a descriptor first and then we call `libusb_handle_events_timeout_completed()` with the same timeout for blocking op or with zero timeout for non-blocking op.\nI will send a patch.","commit_id":"aad47bd340b6ccb54245c36621adfe62a0fe8047"}]}