)]}'
{"id":"openocd~master~I85ea4ecbd529b060c70f83bcfda7522e1730480d","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000438":{"account":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"last_update":"2025-01-12 11:09:12.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I85ea4ecbd529b060c70f83bcfda7522e1730480d","subject":"amend angie build definitions to fix make dist","status":"MERGED","created":"2024-11-28 21:02:05.000000000","updated":"2025-01-12 11:09:12.000000000","submitted":"2025-01-12 11:09:12.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8600","meta_rev_id":"0484e05da989a70f03cd65b62ea89e3c26a183f4","_number":8600,"owner":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-01-12 11:09:12.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-01-12 11:09:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-11-28 21:18:22.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-01-02 16:41:04.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"69bb12fdce4085f37070f5845b7b2c7a08bea1b5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"real_author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"date":"2024-11-28 21:02:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2fd1af8bc905d64b238b1f0ae51edd6f6b0bc89a","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-11-28 21:18:22.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20300/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19454/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"3d92d1e1cd6e676b809adbc3663dec39330ce800","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-01-02 16:41:04.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"57f371521b1f3a1df925dc39542d926c07cb9380","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-01-12 11:09:05.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"0484e05da989a70f03cd65b62ea89e3c26a183f4","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-01-12 11:09:12.000000000","message":"Change has been successfully cherry-picked as 0ed03df6e95bc336bbece000ffbe4028f70369d8","accounts_in_message":[],"_revision_number":2}],"current_revision":"0ed03df6e95bc336bbece000ffbe4028f70369d8","revisions":{"f16b07221dfccd984321f343106a5f2d5fc0c403":{"kind":"REWORK","_number":1,"created":"2024-11-28 21:02:05.000000000","uploader":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"ref":"refs/changes/00/8600/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/00/8600/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/00/8600/1 \u0026\u0026 git checkout -b change-8600 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/00/8600/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/00/8600/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/00/8600/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/00/8600/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/00/8600/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"133dd9d669e5b8beb7c7787b0be677621808e72d","subject":"target/xtensa: add maskisr command support for NX"}],"author":{"name":"R. Diez","email":"rdiezmail-openocd@yahoo.de","date":"2024-11-28 20:47:34.000000000","tz":60},"committer":{"name":"R. Diez","email":"rdiezmail-openocd@yahoo.de","date":"2024-11-28 20:47:34.000000000","tz":60},"subject":"amend angie build definitions to fix make dist","message":"amend angie build definitions to fix make dist\n\n\"make dist\" was broken because GNU Make was using a built-in rule\nto try to build angie from angie.c . This is a limitation in Automake\nwhen you add a whole subdir with the same name to EXTRA_DIST.\nThe Automake doc actually discourages adding whole subdirs.\n\nChange-Id: I85ea4ecbd529b060c70f83bcfda7522e1730480d\nSigned-off-by: R. Diez \u003crdiezmail-openocd@yahoo.de\u003e\n"}},"0ed03df6e95bc336bbece000ffbe4028f70369d8":{"kind":"REWORK","_number":2,"created":"2025-01-12 11:09:12.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/00/8600/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/00/8600/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/00/8600/2 \u0026\u0026 git checkout -b change-8600 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/00/8600/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/00/8600/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/00/8600/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/00/8600/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/00/8600/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8b5ea720da530d375cc5c5d4a66fb48768a421de","subject":"make bitbang_interface const"}],"author":{"name":"R. Diez","email":"rdiezmail-openocd@yahoo.de","date":"2024-11-28 20:47:34.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-01-12 11:09:12.000000000","tz":0},"subject":"amend angie build definitions to fix make dist","message":"amend angie build definitions to fix make dist\n\n\"make dist\" was broken because GNU Make was using a built-in rule\nto try to build angie from angie.c . This is a limitation in Automake\nwhen you add a whole subdir with the same name to EXTRA_DIST.\nThe Automake doc actually discourages adding whole subdirs.\n\nChange-Id: I85ea4ecbd529b060c70f83bcfda7522e1730480d\nSigned-off-by: R. Diez \u003crdiezmail-openocd@yahoo.de\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8600\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}
