)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2a9ec8ca5e6fabb5526fb2fd4faf31c559028947","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ada4a3ca_1ca3d72c","updated":"2025-01-02 16:30:17.000000000","message":"This patch does not merge anymore after merging some conflicting patch.\nWould you mind rebasing and pushing it again?\n\nThe fix for the warning should be in a separate patch, but I\u0027m not really strict on this since the whole patch is small and easy to review.","commit_id":"bd110b9b49376305fa12743284a112271f848dca"},{"author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"change_message_id":"e790899d00dd66d84de640006b1025b9e88c1318","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2cfa846f_5b4ef716","in_reply_to":"ada4a3ca_1ca3d72c","updated":"2025-01-12 20:20:46.000000000","message":"\u003e This patch does not merge anymore after merging some conflicting patch.\n\u003e Would you mind rebasing and pushing it again?\n\nDone.\n\n\u003e The fix for the warning should be in a separate patch, but I\u0027m not really strict on this since the whole patch is small and easy to review.\n\nPlease accept the patch as it is. Creating a separate patch just for the one compilation warning fix means more bureaucracy, and I do not think it is worth the effort in this particular instance.","commit_id":"bd110b9b49376305fa12743284a112271f848dca"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9f8e3861a3f3683de90d16ee4dff99ea87185bed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4838d474_4939ec37","updated":"2025-01-25 10:51:54.000000000","message":"It should be ok to rebase this.","commit_id":"e9c4c865083b7a9ed438d71907785425c04f9bfb"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"fc58ebfe0c928547462f1f05b208b9817288d32d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cbe5644d_3a4e148e","updated":"2025-01-17 16:10:53.000000000","message":"Thanks.\nNew conflict with https://review.openocd.org/c/openocd/+/8645\nI will handle the rebase during the merge","commit_id":"e9c4c865083b7a9ed438d71907785425c04f9bfb"},{"author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"change_message_id":"14e8e90b2bae96f38e004ebf9ab9d243d8d78ef5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"343762a3_de404cd5","updated":"2025-01-25 20:41:42.000000000","message":"Rebase done.","commit_id":"46a6cec84e2adf0dd3453466987b1460f5a2bfe3"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"fc09227538914169047194130577148ed27c1c35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a8f5ec93_2f7e79a1","updated":"2025-01-25 21:37:32.000000000","message":"Thanks!","commit_id":"46a6cec84e2adf0dd3453466987b1460f5a2bfe3"}],"src/jtag/drivers/vdebug.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ac83a58584976457ad68317b91f72d2614e8957a","unresolved":true,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"#ifdef _WIN32"},{"line_number":254,"context_line":"\thsock \u003d socket(AF_INET, SOCK_STREAM, IPPROTO_IP);"},{"line_number":255,"context_line":"\tif (hsock \u003d\u003d (int)INVALID_SOCKET)"},{"line_number":256,"context_line":"\t\trc \u003d vdebug_socket_error();"},{"line_number":257,"context_line":"#elif defined __CYGWIN__"},{"line_number":258,"context_line":"\t/* SO_RCVLOWAT unsupported on CYGWIN */"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"db2b4584_2ebf43fe","line":255,"updated":"2025-01-18 17:03:39.000000000","message":"We have also https://review.openocd.org/c/openocd/+/8717\nthat fixes this.\nInstead of the cast, I prefer using 8717 that drops INVALID_SOCKET.","commit_id":"e9c4c865083b7a9ed438d71907785425c04f9bfb"},{"author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"change_message_id":"a2b4adcf0bce3ec46f20900571ae41b6e9660328","unresolved":true,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"#ifdef _WIN32"},{"line_number":254,"context_line":"\thsock \u003d socket(AF_INET, SOCK_STREAM, IPPROTO_IP);"},{"line_number":255,"context_line":"\tif (hsock \u003d\u003d (int)INVALID_SOCKET)"},{"line_number":256,"context_line":"\t\trc \u003d vdebug_socket_error();"},{"line_number":257,"context_line":"#elif defined __CYGWIN__"},{"line_number":258,"context_line":"\t/* SO_RCVLOWAT unsupported on CYGWIN */"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"c9b0b51c_96123596","line":255,"in_reply_to":"db2b4584_2ebf43fe","updated":"2025-01-18 18:17:01.000000000","message":"OK, I\u0027ll drop this warning fix in this patch when you commit the other patch. Otherwise, this patch will fail the Jenkins compilation due to the warning.","commit_id":"e9c4c865083b7a9ed438d71907785425c04f9bfb"}]}
