)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"e198828c2316c909b2305ad7b0d121f1389f2b6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"08d3f1be_be356a5c","updated":"2025-02-02 13:42:48.000000000","message":"Thanks..","commit_id":"6145dde8f42905f309a3e9c964855921d804e4bd"},{"author":{"_account_id":1002273,"name":"Richard Allen","email":"rsaxvc@gmail.com","username":"rsaxvc","status":"@BryghtLabs, @rsaxvc.net"},"change_message_id":"8f0349f3db9f79a0cfb52a57e0580bf96515d7ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ec3b5db9_e5c193ea","updated":"2025-02-07 03:59:53.000000000","message":"Valgrind reports no memory errors, and no additional memory leaks.","commit_id":"c5fd20a798862cd44b27b16a45f3cb91baac087f"}],"src/target/target.c":[{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"0c724e704fa977e88c976077534578471d5f900c","unresolved":true,"context_lines":[{"line_number":4313,"context_line":""},{"line_number":4314,"context_line":"static int compare_pc(const void *p1, const void *p2)"},{"line_number":4315,"context_line":"{"},{"line_number":4316,"context_line":"\tuint32_t lhs, rhs;"},{"line_number":4317,"context_line":"\tmemcpy(\u0026lhs, p1, sizeof(lhs));"},{"line_number":4318,"context_line":"\tmemcpy(\u0026rhs, p2, sizeof(rhs));"},{"line_number":4319,"context_line":"\tif (lhs \u003c rhs)"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"5914c60d_5fcc6049","line":4316,"updated":"2025-02-01 13:03:21.000000000","message":"How about without using mempcpy?\n\n    uint32_t lhs \u003d *(const uint32_t *)p1;\n    uint32_t rhs \u003d *(const uint32_t *)p2;\n    return (lhs \u003e rhs) - (lhs \u003c rhs);","commit_id":"ae51b062c78d107d3e8d12bb29ed8c607c227283"},{"author":{"_account_id":1002273,"name":"Richard Allen","email":"rsaxvc@gmail.com","username":"rsaxvc","status":"@BryghtLabs, @rsaxvc.net"},"change_message_id":"3b95a695333f238e02934962840f44d24b86ef3b","unresolved":false,"context_lines":[{"line_number":4313,"context_line":""},{"line_number":4314,"context_line":"static int compare_pc(const void *p1, const void *p2)"},{"line_number":4315,"context_line":"{"},{"line_number":4316,"context_line":"\tuint32_t lhs, rhs;"},{"line_number":4317,"context_line":"\tmemcpy(\u0026lhs, p1, sizeof(lhs));"},{"line_number":4318,"context_line":"\tmemcpy(\u0026rhs, p2, sizeof(rhs));"},{"line_number":4319,"context_line":"\tif (lhs \u003c rhs)"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"fc9a59f4_7edd6bed","line":4316,"in_reply_to":"409df0cb_4bbce632","updated":"2025-02-02 05:42:51.000000000","message":"Done","commit_id":"ae51b062c78d107d3e8d12bb29ed8c607c227283"},{"author":{"_account_id":1002273,"name":"Richard Allen","email":"rsaxvc@gmail.com","username":"rsaxvc","status":"@BryghtLabs, @rsaxvc.net"},"change_message_id":"6bc856b0be57f022e2fbfc23080298ac8301ba7c","unresolved":true,"context_lines":[{"line_number":4313,"context_line":""},{"line_number":4314,"context_line":"static int compare_pc(const void *p1, const void *p2)"},{"line_number":4315,"context_line":"{"},{"line_number":4316,"context_line":"\tuint32_t lhs, rhs;"},{"line_number":4317,"context_line":"\tmemcpy(\u0026lhs, p1, sizeof(lhs));"},{"line_number":4318,"context_line":"\tmemcpy(\u0026rhs, p2, sizeof(rhs));"},{"line_number":4319,"context_line":"\tif (lhs \u003c rhs)"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"409df0cb_4bbce632","line":4316,"in_reply_to":"5914c60d_5fcc6049","updated":"2025-02-02 05:22:01.000000000","message":"Good idea - these will always be properly aligned.","commit_id":"ae51b062c78d107d3e8d12bb29ed8c607c227283"}]}
