)]}'
{"id":"openocd~master~I2383e41fb70063e26aa69fabcf728df597607934","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002340":{"account":{"_account_id":1002340,"name":"Nicolas Derumigny","display_name":"Nicolas Derumigny","email":"nicolas.derumigny@inria.fr","username":"NicolasDerumigny","status":"Post Doc - Inria"},"last_update":"2024-12-16 15:55:56.000000000","reason":"Removed by \u003cGERRIT_ACCOUNT_1002340\u003e using the hovercard menu","reason_account":{"_account_id":1002340,"name":"Nicolas Derumigny","display_name":"Nicolas Derumigny","email":"nicolas.derumigny@inria.fr","username":"NicolasDerumigny","status":"Post Doc - Inria"}},"1001700":{"account":{"_account_id":1001700,"name":"Moritz Fischer","email":"moritzf@google.com","username":"moritzf"},"last_update":"2024-12-12 13:27:25.000000000","reason":"\u003cGERRIT_ACCOUNT_1001700\u003e replied on the change","reason_account":{"_account_id":1001700,"name":"Moritz Fischer","email":"moritzf@google.com","username":"moritzf"}},"1002346":{"account":{"_account_id":1002346,"name":"Henrik Brix Andersen","email":"henrik@brixandersen.dk","username":"henrikbrixandersen"},"last_update":"2025-06-29 07:38:27.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I2383e41fb70063e26aa69fabcf728df597607934","subject":"jtag: drivers: xlnx-pcie-xvc: use correct TMS polarity during pathmove","status":"MERGED","created":"2024-12-11 08:40:30.000000000","updated":"2025-06-29 07:38:27.000000000","submitted":"2025-06-29 07:38:27.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8613","meta_rev_id":"0457d3a298f54769e8d0010a44ed7c4844b5ec1d","_number":8613,"owner":{"_account_id":1002346,"name":"Henrik Brix Andersen","email":"henrik@brixandersen.dk","username":"henrikbrixandersen"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1001700,"name":"Moritz Fischer","email":"moritzf@google.com","username":"moritzf"},{"value":0,"_account_id":1002340,"name":"Nicolas Derumigny","display_name":"Nicolas Derumigny","email":"nicolas.derumigny@inria.fr","username":"NicolasDerumigny","status":"Post Doc - Inria"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-06-29 07:38:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-06-29 07:38:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-06-29 07:38:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001700,"name":"Moritz Fischer","email":"moritzf@google.com","username":"moritzf"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-06-29 07:38:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002340,"name":"Nicolas Derumigny","display_name":"Nicolas Derumigny","email":"nicolas.derumigny@inria.fr","username":"NicolasDerumigny","status":"Post Doc - Inria"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001700,"name":"Moritz Fischer","email":"moritzf@google.com","username":"moritzf"},{"_account_id":1002340,"name":"Nicolas Derumigny","display_name":"Nicolas Derumigny","email":"nicolas.derumigny@inria.fr","username":"NicolasDerumigny","status":"Post Doc - Inria"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-12-11 08:41:48.000000000","updated_by":{"_account_id":1002346,"name":"Henrik Brix Andersen","email":"henrik@brixandersen.dk","username":"henrikbrixandersen"},"reviewer":{"_account_id":1001700,"name":"Moritz Fischer","email":"moritzf@google.com","username":"moritzf"},"state":"REVIEWER"},{"updated":"2024-12-11 08:43:25.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-12-11 09:07:13.000000000","updated_by":{"_account_id":1002346,"name":"Henrik Brix Andersen","email":"henrik@brixandersen.dk","username":"henrikbrixandersen"},"reviewer":{"_account_id":1002340,"name":"Nicolas Derumigny","display_name":"Nicolas Derumigny","email":"nicolas.derumigny@inria.fr","username":"NicolasDerumigny","status":"Post Doc - Inria"},"state":"REVIEWER"},{"updated":"2025-06-21 09:36:45.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"4f088751f1eadd0e006f5827b765e6ebdbc7aaaa","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002346,"name":"Henrik Brix Andersen","email":"henrik@brixandersen.dk","username":"henrikbrixandersen"},"real_author":{"_account_id":1002346,"name":"Henrik Brix Andersen","email":"henrik@brixandersen.dk","username":"henrikbrixandersen"},"date":"2024-12-11 08:40:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b6dcb527f3fc8b953e0e463ef0d441f0cd01434d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002346,"name":"Henrik Brix Andersen","email":"henrik@brixandersen.dk","username":"henrikbrixandersen"},"real_author":{"_account_id":1002346,"name":"Henrik Brix Andersen","email":"henrik@brixandersen.dk","username":"henrikbrixandersen"},"date":"2024-12-11 08:43:22.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"63f66d2b8c055c6be6a4985d51e6fc0b83cdd440","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-12-11 08:43:25.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/19489/ : ABORTED\n\nhttps://build.openocd.org/job/openocd-gerrit/20335/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"d8b4a29517abb7dc3870bafd79071b29c3b05bc1","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-12-11 08:56:08.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20336/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19490/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"e36b6124096a33853c207301b8720a6a1f4b2d9b","author":{"_account_id":1002340,"name":"Nicolas Derumigny","display_name":"Nicolas Derumigny","email":"nicolas.derumigny@inria.fr","username":"NicolasDerumigny","status":"Post Doc - Inria"},"real_author":{"_account_id":1002340,"name":"Nicolas Derumigny","display_name":"Nicolas Derumigny","email":"nicolas.derumigny@inria.fr","username":"NicolasDerumigny","status":"Post Doc - Inria"},"date":"2024-12-12 09:25:40.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"a603739175b14720828ec69b0c663d81be6d8623","author":{"_account_id":1002346,"name":"Henrik Brix Andersen","email":"henrik@brixandersen.dk","username":"henrikbrixandersen"},"real_author":{"_account_id":1002346,"name":"Henrik Brix Andersen","email":"henrik@brixandersen.dk","username":"henrikbrixandersen"},"date":"2024-12-12 09:55:59.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"517c14de94d74825af25051e991691712727f49d","author":{"_account_id":1001700,"name":"Moritz Fischer","email":"moritzf@google.com","username":"moritzf"},"real_author":{"_account_id":1001700,"name":"Moritz Fischer","email":"moritzf@google.com","username":"moritzf"},"date":"2024-12-12 13:27:25.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"f4231d3b48e4556325035fedbfc941e1c4c1cd24","author":{"_account_id":1002346,"name":"Henrik Brix Andersen","email":"henrik@brixandersen.dk","username":"henrikbrixandersen"},"real_author":{"_account_id":1002346,"name":"Henrik Brix Andersen","email":"henrik@brixandersen.dk","username":"henrikbrixandersen"},"date":"2024-12-16 11:45:50.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"707ad39bc66e0dbdc04d77eac28fbe828490e4ad","author":{"_account_id":1002340,"name":"Nicolas Derumigny","display_name":"Nicolas Derumigny","email":"nicolas.derumigny@inria.fr","username":"NicolasDerumigny","status":"Post Doc - Inria"},"real_author":{"_account_id":1002340,"name":"Nicolas Derumigny","display_name":"Nicolas Derumigny","email":"nicolas.derumigny@inria.fr","username":"NicolasDerumigny","status":"Post Doc - Inria"},"date":"2024-12-16 15:03:34.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"76a04a2183f216b99d9da323010cc80ff2224b22","author":{"_account_id":1002346,"name":"Henrik Brix Andersen","email":"henrik@brixandersen.dk","username":"henrikbrixandersen"},"real_author":{"_account_id":1002346,"name":"Henrik Brix Andersen","email":"henrik@brixandersen.dk","username":"henrikbrixandersen"},"date":"2024-12-16 15:51:48.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"a8ec4c1f964d48fd836ab9ffb64e3eae6dfc1e84","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-06-21 09:36:45.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"f01bee2f59643a7c66f6d117e1ee165a1ae4274f","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-06-29 07:38:23.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"0457d3a298f54769e8d0010a44ed7c4844b5ec1d","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-06-29 07:38:27.000000000","message":"Change has been successfully cherry-picked as 6631419beba62893075eae5e1e13ddba9062d4f5","accounts_in_message":[],"_revision_number":3}],"current_revision":"6631419beba62893075eae5e1e13ddba9062d4f5","revisions":{"6631419beba62893075eae5e1e13ddba9062d4f5":{"kind":"REWORK","_number":3,"created":"2025-06-29 07:38:27.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/13/8613/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/13/8613/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/13/8613/3 \u0026\u0026 git checkout -b change-8613 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/13/8613/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/13/8613/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/13/8613/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/13/8613/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/13/8613/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8194fc48bd3f06071a9068e385a122499447340a","subject":"tcl/board: Add config for TMS570LS12x development kit"}],"author":{"name":"Henrik Brix Andersen","email":"hebad@vestas.com","date":"2024-12-11 08:34:57.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-06-29 07:38:27.000000000","tz":0},"subject":"jtag: drivers: xlnx-pcie-xvc: use correct TMS polarity during pathmove","message":"jtag: drivers: xlnx-pcie-xvc: use correct TMS polarity during pathmove\n\nThe xlnx_pcie_xvc_execute_pathmove() function checks whether TMS\nshould be high or low for transitioning from the current state to the\nnext state, but then calls xlnx_pcie_xvc_transact() with the opposite\nlevel, leading to invalid state transitions.\n\nFix the polarity of TMS in the calls to xlnx_pcie_xvc_transact() to\nmatch the required TMS level.\n\nChange-Id: I2383e41fb70063e26aa69fabcf728df597607934\nSigned-off-by: Henrik Brix Andersen \u003chebad@vestas.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8613\nReviewed-by: Moritz Fischer \u003cmoritzf@google.com\u003e\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-by: Nicolas Derumigny \u003cnicolas.derumigny@inria.fr\u003e\n"}},"d652a017ca38ade1ee1c61c79d1ddf4c82806956":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2024-12-11 08:43:22.000000000","uploader":{"_account_id":1002346,"name":"Henrik Brix Andersen","email":"henrik@brixandersen.dk","username":"henrikbrixandersen"},"ref":"refs/changes/13/8613/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/13/8613/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/13/8613/2 \u0026\u0026 git checkout -b change-8613 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/13/8613/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/13/8613/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/13/8613/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/13/8613/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/13/8613/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"133dd9d669e5b8beb7c7787b0be677621808e72d","subject":"target/xtensa: add maskisr command support for NX"}],"author":{"name":"Henrik Brix Andersen","email":"hebad@vestas.com","date":"2024-12-11 08:34:57.000000000","tz":60},"committer":{"name":"Henrik Brix Andersen","email":"hebad@vestas.com","date":"2024-12-11 08:42:27.000000000","tz":60},"subject":"jtag: drivers: xlnx-pcie-xvc: use correct TMS polarity during pathmove","message":"jtag: drivers: xlnx-pcie-xvc: use correct TMS polarity during pathmove\n\nThe xlnx_pcie_xvc_execute_pathmove() function checks whether TMS\nshould be high or low for transitioning from the current state to the\nnext state, but then calls xlnx_pcie_xvc_transact() with the opposite\nlevel, leading to invalid state transitions.\n\nFix the polarity of TMS in the calls to xlnx_pcie_xvc_transact() to\nmatch the required TMS level.\n\nChange-Id: I2383e41fb70063e26aa69fabcf728df597607934\nSigned-off-by: Henrik Brix Andersen \u003chebad@vestas.com\u003e\n"}},"be4c51c4278a7c3fa8da72761871182c532a2fff":{"kind":"REWORK","_number":1,"created":"2024-12-11 08:40:30.000000000","uploader":{"_account_id":1002346,"name":"Henrik Brix Andersen","email":"henrik@brixandersen.dk","username":"henrikbrixandersen"},"ref":"refs/changes/13/8613/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/13/8613/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/13/8613/1 \u0026\u0026 git checkout -b change-8613 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/13/8613/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/13/8613/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/13/8613/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/13/8613/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/13/8613/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"133dd9d669e5b8beb7c7787b0be677621808e72d","subject":"target/xtensa: add maskisr command support for NX"}],"author":{"name":"Henrik Brix Andersen","email":"hebad@vestas.com","date":"2024-12-11 08:34:57.000000000","tz":60},"committer":{"name":"Henrik Brix Andersen","email":"hebad@vestas.com","date":"2024-12-11 08:34:57.000000000","tz":60},"subject":"jtag/drivers/xlnx_pcie_xvc: use correct TMS polarity during pathmove","message":"jtag/drivers/xlnx_pcie_xvc: use correct TMS polarity during pathmove\n\nThe xlnx_pcie_xvc_execute_pathmove() function checks whether TMS\nshould be high or low for transitioning from the current state to the\nnext state, but then calls xlnx_pcie_xvc_transact() with the opposite\nlevel, leading to invalid state transitions.\n\nFix the polarity of TMS in the calls to xlnx_pcie_xvc_transact() to\nmatch the required TMS level.\n\nChange-Id: I2383e41fb70063e26aa69fabcf728df597607934\nSigned-off-by: Henrik Brix Andersen \u003chebad@vestas.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}