)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"8153abc225441aa15e962696cfa739fa37d24a81","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b8d018f2_a6bbd0c6","updated":"2025-08-09 20:08:43.000000000","message":"Sorry for not reviewing it earlier, missed in my inbox!\n\nI read in web page that QCS6490 has \"up to\" 8 cores.\nIt would be nice to have, in the future, the possibility to address all of them.\nIn mean time, apart for some cosmetic changes, I think we can proceed with this single core version","commit_id":"6a0a84303dfbb24ac9a631953ceb30b671328a34"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"fa3267068921c41cc401fd323848979dc38b660a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6a70c9b7_64860461","updated":"2025-08-17 09:43:50.000000000","message":"Thanks!","commit_id":"ce8f3bf455c05cf47f2b4e1f139667557b6b01f6"}],"tcl/target/qualcomm/qcs6490.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"8153abc225441aa15e962696cfa739fa37d24a81","unresolved":true,"context_lines":[{"line_number":7,"context_line":"# https://www.qualcomm.com/products/internet-of-things/industrial/building-enterprise/qcs6490"},{"line_number":8,"context_line":"# https://www.qualcomm.com/products/internet-of-things/industrial/building-enterprise/qcm6490"},{"line_number":9,"context_line":"#"},{"line_number":10,"context_line":"# Notes:"},{"line_number":11,"context_line":"# QCS6490/QCM6490 devices support both JTAG and SWD protocols."},{"line_number":12,"context_line":"# Debug has been tested with the following debug adapters/dongles"},{"line_number":13,"context_line":"#    1. Olimex FTDI ARM-USB-OCD-H (supports only JTAG)"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"7255cb4a_1dc47148","line":10,"updated":"2025-08-09 20:08:43.000000000","message":"I think you can drop the notes and the example.\nThe notes are already in the commit message, the examples are straightforward.","commit_id":"6a0a84303dfbb24ac9a631953ceb30b671328a34"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"fa3267068921c41cc401fd323848979dc38b660a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# https://www.qualcomm.com/products/internet-of-things/industrial/building-enterprise/qcs6490"},{"line_number":8,"context_line":"# https://www.qualcomm.com/products/internet-of-things/industrial/building-enterprise/qcm6490"},{"line_number":9,"context_line":"#"},{"line_number":10,"context_line":"# Notes:"},{"line_number":11,"context_line":"# QCS6490/QCM6490 devices support both JTAG and SWD protocols."},{"line_number":12,"context_line":"# Debug has been tested with the following debug adapters/dongles"},{"line_number":13,"context_line":"#    1. Olimex FTDI ARM-USB-OCD-H (supports only JTAG)"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"4020a11f_5e504b1c","line":10,"in_reply_to":"7255cb4a_1dc47148","updated":"2025-08-17 09:43:50.000000000","message":"Done","commit_id":"6a0a84303dfbb24ac9a631953ceb30b671328a34"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"8153abc225441aa15e962696cfa739fa37d24a81","unresolved":true,"context_lines":[{"line_number":36,"context_line":"# For Segger -JLink Plus, _PROTOCOL can be set to either jtag or swd"},{"line_number":37,"context_line":"set _PROTOCOL jtag"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"transport select $_PROTOCOL"},{"line_number":40,"context_line":"adapter speed 500"},{"line_number":41,"context_line":"reset_config trst_and_srst"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"0de63439_4868eab1","line":39,"updated":"2025-08-09 20:08:43.000000000","message":"I know it\u0027s annoying, but we put the transport selection command only:\n- on target files that only accept one transport (e.g. jtag only);\n- on board files where only one adapter is implemented.\n\nHere the SoC accepts either swd or jtag, so the selection should be left outside, using the command:\n`openocd -f \u003cinterface\u003e -c \u0027transport select swd\u0027 -f \u003ctarget\u003e`\n\nIf you don\u0027t put the transport command, OpenOCD will issue a warning that a default transport gets selected. But this will also soon disappear! So explicit transport selection is required on the command line.","commit_id":"6a0a84303dfbb24ac9a631953ceb30b671328a34"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"fa3267068921c41cc401fd323848979dc38b660a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"# For Segger -JLink Plus, _PROTOCOL can be set to either jtag or swd"},{"line_number":37,"context_line":"set _PROTOCOL jtag"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"transport select $_PROTOCOL"},{"line_number":40,"context_line":"adapter speed 500"},{"line_number":41,"context_line":"reset_config trst_and_srst"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"8deaa3c6_8cf3e668","line":39,"in_reply_to":"0de63439_4868eab1","updated":"2025-08-17 09:43:50.000000000","message":"Done","commit_id":"6a0a84303dfbb24ac9a631953ceb30b671328a34"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"8153abc225441aa15e962696cfa739fa37d24a81","unresolved":true,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# Create DAP/TAP based on Protocol selection"},{"line_number":44,"context_line":"if {$_PROTOCOL \u003d\u003d \"swd\"} {"},{"line_number":45,"context_line":"   swd newdap $_CHIPNAME cpu -irlen 15 -expected-id 0x5ba02477"},{"line_number":46,"context_line":"} elseif {$_PROTOCOL \u003d\u003d \"jtag\"} {"},{"line_number":47,"context_line":"   jtag newtap $_CHIPNAME cpu -irlen 4 -ircapture 1 -expected-id 0x5ba00477"},{"line_number":48,"context_line":"}"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"ecdfa8e4_be6f6516","line":45,"updated":"2025-08-09 20:08:43.000000000","message":"The option `-irlen` is not required for swd.\nI prefer you replace this part with:\n```\nsource [find target/swj-dp.tcl]\n\nif { [using_jtag] } {\n        set _CPUTAPID 0x5ba00477\n} else {\n        set _CPUTAPID 0x5ba02477\n}\nswj_newdap $_CHIPNAME cpu -expected-id $_CPUTAPID -irlen 4\n```\nOf course, put each line in the proper part in the file.","commit_id":"6a0a84303dfbb24ac9a631953ceb30b671328a34"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"fa3267068921c41cc401fd323848979dc38b660a","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# Create DAP/TAP based on Protocol selection"},{"line_number":44,"context_line":"if {$_PROTOCOL \u003d\u003d \"swd\"} {"},{"line_number":45,"context_line":"   swd newdap $_CHIPNAME cpu -irlen 15 -expected-id 0x5ba02477"},{"line_number":46,"context_line":"} elseif {$_PROTOCOL \u003d\u003d \"jtag\"} {"},{"line_number":47,"context_line":"   jtag newtap $_CHIPNAME cpu -irlen 4 -ircapture 1 -expected-id 0x5ba00477"},{"line_number":48,"context_line":"}"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"4f33569f_a3bc2c73","line":45,"in_reply_to":"ecdfa8e4_be6f6516","updated":"2025-08-17 09:43:50.000000000","message":"Done","commit_id":"6a0a84303dfbb24ac9a631953ceb30b671328a34"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"8153abc225441aa15e962696cfa739fa37d24a81","unresolved":true,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"dap create $_CHIPNAME.dap -chain-position $_CHIPNAME.cpu -ignore-syspwrupack"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"cti create CTI_APSS -dap $_CHIPNAME.dap -baseaddr 0x87020000 -ap-num 1"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"target create $_CHIPNAME.cpu0 aarch64 -endian $_ENDIAN -dap $_CHIPNAME.dap -coreid 0 \\"},{"line_number":55,"context_line":"   -dbgbase 0x87010000 -cti CTI_APSS -event reset-assert-post { dap init }"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"6061b720_b02efba8","line":52,"updated":"2025-08-09 20:08:43.000000000","message":"We create targets, dap and so on using the variable `_CHIPNAME` because we want to be ready to put two SoC on the same board, and having independent name helps OpenOCD to discriminate between them.\nHere you have a constant name `CTI_APSS` that breaks this setup.\nUse a name like `$_CHIPNAME.cti`, or similar","commit_id":"6a0a84303dfbb24ac9a631953ceb30b671328a34"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"fa3267068921c41cc401fd323848979dc38b660a","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"dap create $_CHIPNAME.dap -chain-position $_CHIPNAME.cpu -ignore-syspwrupack"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"cti create CTI_APSS -dap $_CHIPNAME.dap -baseaddr 0x87020000 -ap-num 1"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"target create $_CHIPNAME.cpu0 aarch64 -endian $_ENDIAN -dap $_CHIPNAME.dap -coreid 0 \\"},{"line_number":55,"context_line":"   -dbgbase 0x87010000 -cti CTI_APSS -event reset-assert-post { dap init }"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"9e8b3c17_9ad331df","line":52,"in_reply_to":"6061b720_b02efba8","updated":"2025-08-17 09:43:50.000000000","message":"Done","commit_id":"6a0a84303dfbb24ac9a631953ceb30b671328a34"}]}