)]}'
{"id":"openocd~master~Ia755f17dc72bb9ce8e02065fee6a064f8eec6661","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2025-01-02 21:08:45.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"Ia755f17dc72bb9ce8e02065fee6a064f8eec6661","subject":"drivers/cmsis_dap: use blocking flag instead of wait timeout","status":"MERGED","created":"2024-12-10 08:55:22.000000000","updated":"2025-01-09 20:15:33.000000000","submitted":"2025-01-09 20:15:33.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8639","meta_rev_id":"c411bf37dfbd0fbd5b14dadec302833efab7d085","_number":8639,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-01-09 20:15:33.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-01-09 20:15:33.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-01-09 20:15:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-12-10 09:34:23.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-12-11 10:22:06.000000000","updated_by":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"reviewer":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"state":"REVIEWER"}],"messages":[{"id":"e62f6c2b65abb3d2349a4462c57e56eb3da1cde2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-12-10 08:55:22.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ba85b95cafaecd499b6858651d59127265f8b196","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-12-10 09:34:23.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20328/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19482/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"6108bb809ceeecdc6c29d42796766cdcb7a40498","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2024-12-11 10:22:06.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"ae4a92dbdd8d5bc6ea2d73b3ac4a52a99f46466e","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-01-02 21:08:45.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"c411bf37dfbd0fbd5b14dadec302833efab7d085","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-01-09 20:15:33.000000000","message":"Change has been successfully cherry-picked as 23796efa38019515e6338bb4beaa793a537a00e0","accounts_in_message":[],"_revision_number":2}],"current_revision":"23796efa38019515e6338bb4beaa793a537a00e0","revisions":{"8e14f1747137b2f488a3f8b41c4f4ff41856514c":{"kind":"REWORK","_number":1,"created":"2024-12-10 08:55:22.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/39/8639/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/39/8639/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/39/8639/1 \u0026\u0026 git checkout -b change-8639 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/39/8639/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/39/8639/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/39/8639/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/39/8639/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/39/8639/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"133dd9d669e5b8beb7c7787b0be677621808e72d","subject":"target/xtensa: add maskisr command support for NX"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-12-10 07:26:48.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-12-10 07:47:16.000000000","tz":60},"subject":"drivers/cmsis_dap: use blocking flag instead of wait timeout","message":"drivers/cmsis_dap: use blocking flag instead of wait timeout\n\nCMSIS-DAP bulk backend read op used two timeouts: transfer timeout\nused in libusb_fill_bulk_transfer() and wait timeout used optionally\nin libusb_handle_events_timeout_completed().\n\nThe real usage is limited to two cases only:\n1) blocking read: the same timeout is used for both transfer\nand wait\n2) non-blocking read: transfer timeout is used in\nlibusb_fill_bulk_transfer(),\nlibusb_handle_events_timeout_completed() is called with zero timeout.\n\nUse blocking flag as read op parameter to distinguish between\nthese two cases.\n\nSee also [1]\n\nLink: [1] 8596: jtag: cmsis_dap: include helper/time_support.h | https://review.openocd.org/c/openocd/+/8596\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: Ia755f17dc72bb9ce8e02065fee6a064f8eec6661\n"}},"23796efa38019515e6338bb4beaa793a537a00e0":{"kind":"REWORK","_number":2,"created":"2025-01-09 20:15:33.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/39/8639/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/39/8639/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/39/8639/2 \u0026\u0026 git checkout -b change-8639 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/39/8639/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/39/8639/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/39/8639/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/39/8639/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/39/8639/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"250ab1008b4d5f9520066df28170c42fc8b40af4","subject":"flash/stm32l4x: add STM32C071xx support"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-12-10 07:26:48.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-01-09 20:15:33.000000000","tz":0},"subject":"drivers/cmsis_dap: use blocking flag instead of wait timeout","message":"drivers/cmsis_dap: use blocking flag instead of wait timeout\n\nCMSIS-DAP bulk backend read op used two timeouts: transfer timeout\nused in libusb_fill_bulk_transfer() and wait timeout used optionally\nin libusb_handle_events_timeout_completed().\n\nThe real usage is limited to two cases only:\n1) blocking read: the same timeout is used for both transfer\nand wait\n2) non-blocking read: transfer timeout is used in\nlibusb_fill_bulk_transfer(),\nlibusb_handle_events_timeout_completed() is called with zero timeout.\n\nUse blocking flag as read op parameter to distinguish between\nthese two cases.\n\nSee also [1]\n\nLink: [1] 8596: jtag: cmsis_dap: include helper/time_support.h | https://review.openocd.org/c/openocd/+/8596\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: Ia755f17dc72bb9ce8e02065fee6a064f8eec6661\nReviewed-on: https://review.openocd.org/c/openocd/+/8639\nTested-by: jenkins\nReviewed-by: Paul Fertser \u003cfercerpav@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}