)]}'
{"id":"openocd~master~Iedf2c96d851f22e694efaf13a2d6a2a408cee1ad","project":"openocd","branch":"master","hashtags":[],"change_id":"Iedf2c96d851f22e694efaf13a2d6a2a408cee1ad","subject":"drivers/cmsis_dap_usb_bulk: allow waiting for bulk write","status":"MERGED","created":"2024-12-10 08:55:22.000000000","updated":"2025-01-09 20:15:59.000000000","submitted":"2025-01-09 20:15:59.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8640","meta_rev_id":"e63a43d423bba0c5ea713cc4790b44b4ab67136c","_number":8640,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-01-09 20:15:59.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-01-09 20:15:59.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-12-10 09:23:42.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"ed77effc6ef7073e6843f0349d3d5dace1cacbd9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-12-10 08:55:22.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"07ec3ec75b6ab805329536d002af4d59cef0368e","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-12-10 09:23:42.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20327/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19481/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"53e4b31e58d27931daf1e555601aae9eeaf97866","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-01-02 21:18:10.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e63a43d423bba0c5ea713cc4790b44b4ab67136c","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-01-09 20:15:59.000000000","message":"Change has been successfully cherry-picked as cf115c1e2b670ea8b4606cde0c9b5db735a08742","accounts_in_message":[],"_revision_number":2}],"current_revision":"cf115c1e2b670ea8b4606cde0c9b5db735a08742","revisions":{"bd37a7ac4983ec41d319df3da0aa3cba45599d7f":{"kind":"REWORK","_number":1,"created":"2024-12-10 08:55:22.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/40/8640/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/40/8640/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/40/8640/1 \u0026\u0026 git checkout -b change-8640 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/40/8640/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/40/8640/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/40/8640/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/40/8640/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/40/8640/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8e14f1747137b2f488a3f8b41c4f4ff41856514c","subject":"drivers/cmsis_dap: use blocking flag instead of wait timeout"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-12-10 07:53:49.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-12-10 07:53:49.000000000","tz":60},"subject":"drivers/cmsis_dap_usb_bulk: allow waiting for bulk write","message":"drivers/cmsis_dap_usb_bulk: allow waiting for bulk write\n\nNo driver directly working with the USB hardware needs additional\ntime to complete the write op, they always return transfer complete\nstatus immediately after submitting the transfer.\n\nAlthough there is implemented correct waiting path in cmsis_dap_usb_write()\nit was marked by error logs to catch any suspicious behaviour during\ndebugging of asynchronous libusb transfers.\n\nHowever there are drivers which need waiting to finish write op:\nat least usbipd-win, IP tunnelled USB driver, was reported\nto flood the log with the related errors.\n\nChange LOG_ERROR to LOG_DEBUG_IO in the code waiting to finish write op.\n\nReported-by: Quentis Ghyll \u003cquentisgh@gmail.com\u003e\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: Iedf2c96d851f22e694efaf13a2d6a2a408cee1ad\n"}},"cf115c1e2b670ea8b4606cde0c9b5db735a08742":{"kind":"REWORK","_number":2,"created":"2025-01-09 20:15:59.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/40/8640/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/40/8640/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/40/8640/2 \u0026\u0026 git checkout -b change-8640 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/40/8640/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/40/8640/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/40/8640/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/40/8640/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/40/8640/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"23796efa38019515e6338bb4beaa793a537a00e0","subject":"drivers/cmsis_dap: use blocking flag instead of wait timeout"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-12-10 07:53:49.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-01-09 20:15:59.000000000","tz":0},"subject":"drivers/cmsis_dap_usb_bulk: allow waiting for bulk write","message":"drivers/cmsis_dap_usb_bulk: allow waiting for bulk write\n\nNo driver directly working with the USB hardware needs additional\ntime to complete the write op, they always return transfer complete\nstatus immediately after submitting the transfer.\n\nAlthough there is implemented correct waiting path in cmsis_dap_usb_write()\nit was marked by error logs to catch any suspicious behaviour during\ndebugging of asynchronous libusb transfers.\n\nHowever there are drivers which need waiting to finish write op:\nat least usbipd-win, IP tunnelled USB driver, was reported\nto flood the log with the related errors.\n\nChange LOG_ERROR to LOG_DEBUG_IO in the code waiting to finish write op.\n\nReported-by: Quentis Ghyll \u003cquentisgh@gmail.com\u003e\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: Iedf2c96d851f22e694efaf13a2d6a2a408cee1ad\nReviewed-on: https://review.openocd.org/c/openocd/+/8640\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}