)]}'
{"id":"openocd~master~I0b53ec09b35ccf66660e00490f41aaed1bd0f91f","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2025-08-04 09:10:44.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2025-08-04 09:10:44.000000000","reason":"Change was submitted"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2025-08-04 09:10:36.000000000","reason":"\u003cGERRIT_ACCOUNT_1000687\u003e replied on the change","reason_account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}},"hashtags":[],"change_id":"I0b53ec09b35ccf66660e00490f41aaed1bd0f91f","subject":"drivers/cmsis_dap: fix segfault in quirk mode setting","status":"MERGED","created":"2024-12-10 08:55:22.000000000","updated":"2025-08-04 09:10:44.000000000","submitted":"2025-08-04 09:10:44.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8641","meta_rev_id":"9832dc7385563f5f2a8da064e4c60e0bdf8730ca","_number":8641,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-08-04 09:10:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-08-04 09:10:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-12-10 09:11:24.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-02-03 20:29:53.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2025-08-02 10:30:41.000000000","updated_by":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"reviewer":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"REVIEWER"}],"messages":[{"id":"db46927e01e933eb269a26baa3feebf6fc136500","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-12-10 08:55:22.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0d8cdcadd30b137b69d15e2073869fb7cbbdd358","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-12-10 09:11:24.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20326/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19480/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"8dc804fb71b83e05ce94d7127d7711b5a1b6cd4a","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-01-02 21:19:30.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"29cffdeac504b1eb7743365b8e98c41ba8c28c67","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2025-08-02 10:30:09.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nOutdated Votes:\n* Code-Review+1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"0cb2e5315a9c5ae1f78aad111b8952e52fa66805","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2025-08-02 10:30:41.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"182d7800a7c521143cad2a9f9acf5867dbbaeff3","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-08-02 11:02:18.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20684/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/21551/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"0a6e750066665db604a3d8947c09c869b9054974","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-08-04 09:10:36.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"9832dc7385563f5f2a8da064e4c60e0bdf8730ca","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-08-04 09:10:44.000000000","message":"Change has been successfully cherry-picked as 66ea461846a3a4a96687c9287c3f61ae8ce0b775","accounts_in_message":[],"_revision_number":3}],"current_revision":"66ea461846a3a4a96687c9287c3f61ae8ce0b775","revisions":{"dd21d8d60ddba2bfaf8a3586e1aae2c87890fe6e":{"kind":"REWORK","_number":1,"created":"2024-12-10 08:55:22.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/41/8641/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/41/8641/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/41/8641/1 \u0026\u0026 git checkout -b change-8641 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/41/8641/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/41/8641/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/41/8641/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/41/8641/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/41/8641/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bd37a7ac4983ec41d319df3da0aa3cba45599d7f","subject":"drivers/cmsis_dap_usb_bulk: allow waiting for bulk write"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-12-10 08:47:21.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-12-10 08:52:47.000000000","tz":60},"subject":"drivers/cmsis_dap: fix segfault in quirk mode setting","message":"drivers/cmsis_dap: fix segfault in quirk mode setting\n\nCMSIS-DAP quirk mode had to be set after init otherwise\nopenocd failed due to NULL cmsis_dap_handle\n\nMove quirk_mode from struct cmsis_dap to\na standalone static variable to allow setting from Tcl config\nbefore calling cmsis_dap_open()\n\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nFixes: 7966: drivers/cmsis_dap: use quirk workarounds optionally | https://review.openocd.org/c/openocd/+/7966\nFixes: https://sourceforge.net/p/openocd/tickets/420/\nChange-Id: I0b53ec09b35ccf66660e00490f41aaed1bd0f91f\n"}},"cd8f0ee8a33245a0655f0ae5ce0f7b05ec37404c":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2025-08-02 10:30:09.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/41/8641/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/41/8641/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/41/8641/2 \u0026\u0026 git checkout -b change-8641 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/41/8641/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/41/8641/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/41/8641/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/41/8641/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/41/8641/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6872f7e406ad74f366f55947d23becd5a5faca15","subject":"adapter/xds110: Hide \u0027(dis)connected\u0027 message"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-12-10 08:47:21.000000000","tz":60},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2025-08-02 10:27:33.000000000","tz":120},"subject":"drivers/cmsis_dap: fix segfault in quirk mode setting","message":"drivers/cmsis_dap: fix segfault in quirk mode setting\n\nCMSIS-DAP quirk mode had to be set after init otherwise\nopenocd failed due to NULL cmsis_dap_handle\n\nMove quirk_mode from struct cmsis_dap to\na standalone static variable to allow setting from Tcl config\nbefore calling cmsis_dap_open()\n\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nFixes: 7966: drivers/cmsis_dap: use quirk workarounds optionally | https://review.openocd.org/c/openocd/+/7966\nFixes: https://sourceforge.net/p/openocd/tickets/420/\nChange-Id: I0b53ec09b35ccf66660e00490f41aaed1bd0f91f\n"}},"66ea461846a3a4a96687c9287c3f61ae8ce0b775":{"kind":"REWORK","_number":3,"created":"2025-08-04 09:10:44.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/41/8641/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/41/8641/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/41/8641/3 \u0026\u0026 git checkout -b change-8641 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/41/8641/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/41/8641/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/41/8641/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/41/8641/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/41/8641/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6bc2c585960d57c40792d072b38da0834d1e72f9","subject":"configure.ac: Remove useless --enable-verbose-usb-io"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-12-10 08:47:21.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-08-04 09:10:44.000000000","tz":0},"subject":"drivers/cmsis_dap: fix segfault in quirk mode setting","message":"drivers/cmsis_dap: fix segfault in quirk mode setting\n\nCMSIS-DAP quirk mode had to be set after init otherwise\nopenocd failed due to NULL cmsis_dap_handle\n\nMove quirk_mode from struct cmsis_dap to\na standalone static variable to allow setting from Tcl config\nbefore calling cmsis_dap_open()\n\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nFixes: 7966: drivers/cmsis_dap: use quirk workarounds optionally | https://review.openocd.org/c/openocd/+/7966\nFixes: https://sourceforge.net/p/openocd/tickets/420/\nChange-Id: I0b53ec09b35ccf66660e00490f41aaed1bd0f91f\nReviewed-on: https://review.openocd.org/c/openocd/+/8641\nReviewed-by: zapb \u003cdev@zapb.de\u003e\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}