)]}'
{"id":"openocd~master~Ifb72e4df9a1da7f5da7945498ca4d9d139aa9562","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001667":{"account":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"last_update":"2025-04-28 17:37:10.000000000","reason":"Change was abandoned"},"1002047":{"account":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"last_update":"2025-04-28 17:37:10.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"Ifb72e4df9a1da7f5da7945498ca4d9d139aa9562","subject":"target: clean-up target configuration argument handling","status":"ABANDONED","created":"2024-12-10 20:56:34.000000000","updated":"2025-04-28 17:37:25.000000000","total_comment_count":8,"unresolved_comment_count":4,"has_review_started":true,"meta_rev_id":"1756d22e7f18b7b884c0a7a6486adbc320303a5e","_number":8643,"owner":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:jenkins-gerrit-trigger","value":1,"date":"2024-12-15 14:00:15.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"CC":[{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-12-10 20:58:07.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-12-12 12:51:35.000000000","updated_by":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"reviewer":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"state":"CC"},{"updated":"2025-04-06 09:46:04.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"}],"messages":[{"id":"1b717eff93650afa2c2b6a29b125c6ef2b436fbf","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2024-12-10 20:56:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ca7a260d4e133d7aaaa3ad975a947b87482b9200","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-12-10 20:58:07.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/20331/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19485/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"20180bd5c9377890b0517b93db51ece5408c6d5e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2024-12-11 12:26:22.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"781d9bbbd8a7dd186f37864c5a91bca55c5d2d46","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-12-11 13:11:20.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20339/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19493/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"7d6263a03f77e69461e9173ce11b38ae77b8fb57","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2024-12-12 12:51:35.000000000","message":"Patch Set 2:\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"cb7d38555ce67e332752ddddd5d88be24fa364c2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2024-12-15 13:14:16.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"051075c81d09fcd79b5b67589a40878b40861a37","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2024-12-15 13:15:25.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"a8a0b76314de1adc71cb1ef451c9e5dd85746201","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-12-15 13:15:31.000000000","message":"Patch Set 3: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/20364/ : ABORTED\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19517/ : ABORTED","accounts_in_message":[],"_revision_number":3},{"id":"43e2339bcd9330d245f2f417bffd0b5e90c17ae4","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2024-12-15 13:16:05.000000000","message":"Patch Set 2:\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"d7d845d6e983e0303179e6678ab2d8a5db4f8e23","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-12-15 14:00:15.000000000","message":"Patch Set 4: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20365/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19518/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"ae6c9cc848752bb3a979560cbda17a0857aa8b44","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-04-06 09:46:04.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"f9f15c960dc9d76ac4e8ef6020afdc5fe1504af7","tag":"autogenerated:gerrit:abandon","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2025-04-28 17:37:10.000000000","message":"Abandoned\n\nObsoleted by https://review.openocd.org/c/openocd/+/8830","accounts_in_message":[],"_revision_number":4},{"id":"1756d22e7f18b7b884c0a7a6486adbc320303a5e","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2025-04-28 17:37:25.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4}],"current_revision":"0dce5aaf7409031f9de4947030423da687f7100e","revisions":{"522c6f7cfbe6f378482b906193648a21ee3795ee":{"kind":"REWORK","_number":3,"created":"2024-12-15 13:14:16.000000000","uploader":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"ref":"refs/changes/43/8643/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/43/8643/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/43/8643/3 \u0026\u0026 git checkout -b change-8643 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/43/8643/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/43/8643/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/43/8643/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/43/8643/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/43/8643/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"133dd9d669e5b8beb7c7787b0be677621808e72d","subject":"target/xtensa: add maskisr command support for NX"}],"author":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2024-11-29 14:44:50.000000000","tz":180},"committer":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2024-12-15 13:14:04.000000000","tz":180},"subject":"target: clean-up target configuration argument handling","message":"target: clean-up target configuration argument handling\n\nThere were multiple issues with how `target create` and `\u003ctarget_name\u003e\nconfigure/cget` used to handle arguments:\n\n* `Jim_WrongNumArgs()` called with `argc \u003d\u003d 0`, which causes a\n  `JimPanic` if `JIM_DEBUG_PANIC` is defined\nLink: https://github.com/msteveb/jimtcl/blob/3a2cfdf696daa0d92c0f2e8d8fc1ff337ba99c62/jim.c#L11934\n\n* In some cases `Jim_WrongNumArgs()` reported unhelpfull arguments\n  making the message incorrect, e.g:\n```\n\u003e openocd -c \u0027target create my\u0027\n...\nwrong # args: should be \"my \u003cname\u003e \u003ctarget_type\u003e [\u003ctarget_options\u003e ...]\"\n```\nHere the error message mentions both: the name of the target passed to\n`target create` (`my`) and `\u003cname\u003e`.\n\nTo combat these issues a new function is introduced:\n`jim_getopt_wrong_num_args()`. The function wraps the call to\n`Jim_WrongNumArgs()` making these kinds of errors less likely.\n\nChange-Id: Ifb72e4df9a1da7f5da7945498ca4d9d139aa9562\nSigned-off-by: Evgeniy Naydanov \u003cevgeniy.naydanov@syntacore.com\u003e\n"}},"dfec79bae99913e16b072b531c85e3c27256d93e":{"kind":"REWORK","_number":2,"created":"2024-12-11 12:26:22.000000000","uploader":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"ref":"refs/changes/43/8643/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/43/8643/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/43/8643/2 \u0026\u0026 git checkout -b change-8643 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/43/8643/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/43/8643/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/43/8643/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/43/8643/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/43/8643/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"133dd9d669e5b8beb7c7787b0be677621808e72d","subject":"target/xtensa: add maskisr command support for NX"}],"author":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2024-11-29 14:44:50.000000000","tz":180},"committer":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2024-12-11 12:26:16.000000000","tz":180},"subject":"target: clean-up target configuration argument handling","message":"target: clean-up target configuration argument handling\n\nThere were multiple issues with how `target create` and `\u003ctarget_name\u003e\nconfigure/cget` used to handle arguments:\n\n* `Jim_WrongNumArgs()` called with `argc \u003d\u003d 0`, which causes a\n  `JimPanic` if `JIM_DEBUG_PANIC` is defined\nLink: https://github.com/msteveb/jimtcl/blob/3a2cfdf696daa0d92c0f2e8d8fc1ff337ba99c62/jim.c#L11934\n\n* In some cases `Jim_WrongNumArgs()` reported unhelpfull arguments\n  making the message incorrect, e.g:\n```\n\u003e openocd -c \u0027target create my\u0027\n...\nwrong # args: should be \"my \u003cname\u003e \u003ctarget_type\u003e [\u003ctarget_options\u003e ...]\"\n```\nHere the error message mentions both: the name of the target passed to\n`target create` (`my`) and `\u003cname\u003e`.\n\nTo combat these issues a new function is introduced:\n`jim_getopt_wrong_num_args()`. The function wraps the call to\n`Jim_WrongNumArgs()` making these kinds of errors less likely.\n\nChange-Id: Ifb72e4df9a1da7f5da7945498ca4d9d139aa9562\nSigned-off-by: Evgeniy Naydanov \u003cevgeniy.naydanov@syntacore.com\u003e\n"}},"ea77280ec5c1681c65601030e0bab09126c10c3c":{"kind":"REWORK","_number":1,"created":"2024-12-10 20:56:34.000000000","uploader":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"ref":"refs/changes/43/8643/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/43/8643/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/43/8643/1 \u0026\u0026 git checkout -b change-8643 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/43/8643/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/43/8643/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/43/8643/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/43/8643/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/43/8643/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"133dd9d669e5b8beb7c7787b0be677621808e72d","subject":"target/xtensa: add maskisr command support for NX"}],"author":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2024-11-29 14:44:50.000000000","tz":180},"committer":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2024-12-10 20:39:55.000000000","tz":180},"subject":"target: clean-up target configuration argument handling","message":"target: clean-up target configuration argument handling\n\nThere were multiple issues with how `target create` and `\u003ctarget_name\u003e\nconfigure/cget` used to handle arguments:\n\n* `Jim_WrongNumArgs()` called with `argc \u003d\u003d 0`, which causes a\n  `JimPanic` if `JIM_DEBUG_PANIC` is defined\nLink: https://github.com/msteveb/jimtcl/blob/3a2cfdf696daa0d92c0f2e8d8fc1ff337ba99c62/jim.c#L11934\n\n* In some cases `Jim_WrongNumArgs()` reported unhelpfull arguments\n  making the message incorrect, e.g:\n```\n\u003e openocd -c \u0027target create a_name\u0027\n...\nwrong # args: should be \"a_name \u003cname\u003e \u003ctarget_type\u003e [\u003ctarget_options\u003e ...]\"\n```\nHere the error message mentions both: the name of the target passed to\n`target create` (`a_name`) and `\u003cname\u003e`.\n\nTo combat these issues a new function is introduced:\n`jim_getopt_wrong_num_args()`. The function wraps the call to\n`Jim_WrongNumArgs()` making these kinds of errors less likely.\n\nChange-Id: Ifb72e4df9a1da7f5da7945498ca4d9d139aa9562\nSigned-off-by: Evgeniy Naydanov \u003cevgeniy.naydanov@syntacore.com\u003e\n"}},"0dce5aaf7409031f9de4947030423da687f7100e":{"kind":"REWORK","_number":4,"created":"2024-12-15 13:15:25.000000000","uploader":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"ref":"refs/changes/43/8643/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/43/8643/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/43/8643/4 \u0026\u0026 git checkout -b change-8643 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/43/8643/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/43/8643/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/43/8643/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/43/8643/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/43/8643/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"133dd9d669e5b8beb7c7787b0be677621808e72d","subject":"target/xtensa: add maskisr command support for NX"}],"author":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2024-11-29 14:44:50.000000000","tz":180},"committer":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2024-12-15 13:15:06.000000000","tz":180},"subject":"target: clean-up target configuration argument handling","message":"target: clean-up target configuration argument handling\n\nThere were multiple issues with how `target create` and `\u003ctarget_name\u003e\nconfigure/cget` used to handle arguments:\n\n* `Jim_WrongNumArgs()` called with `argc \u003d\u003d 0`, which causes a\n  `JimPanic` if `JIM_DEBUG_PANIC` is defined\nLink: https://github.com/msteveb/jimtcl/blob/3a2cfdf696daa0d92c0f2e8d8fc1ff337ba99c62/jim.c#L11934\n\n* In some cases `Jim_WrongNumArgs()` reported unhelpfull arguments\n  making the message incorrect, e.g:\n```\n\u003e openocd -c \u0027target create my\u0027\n...\nwrong # args: should be \"my \u003cname\u003e \u003ctarget_type\u003e [\u003ctarget_options\u003e ...]\"\n```\nHere the error message mentions both: the name of the target passed to\n`target create` (`my`) and `\u003cname\u003e`.\n\nTo combat these issues a new function is introduced:\n`jim_getopt_wrong_num_args()`. The function wraps the call to\n`Jim_WrongNumArgs()` making these kinds of errors less likely.\n\nChange-Id: Ifb72e4df9a1da7f5da7945498ca4d9d139aa9562\nSigned-off-by: Evgeniy Naydanov \u003cevgeniy.naydanov@syntacore.com\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}