)]}'
{"id":"openocd~master~I9efbba662599a61bbe1fc56a33dc1ee7ad58826c","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000005":{"account":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"last_update":"2024-12-21 12:31:43.000000000","reason":"\u003cGERRIT_ACCOUNT_1000005\u003e replied on the change","reason_account":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"}},"1002351":{"account":{"_account_id":1002351,"name":"Pete Moore","email":"pmoore@mozilla.com","username":"petemoore"},"last_update":"2024-12-21 17:06:57.000000000","reason":"\u003cGERRIT_ACCOUNT_1002351\u003e replied on the change","reason_account":{"_account_id":1002351,"name":"Pete Moore","email":"pmoore@mozilla.com","username":"petemoore"}}},"hashtags":[],"change_id":"I9efbba662599a61bbe1fc56a33dc1ee7ad58826c","subject":"jimtcl: Fix command not found","status":"MERGED","created":"2024-12-16 12:09:46.000000000","updated":"2024-12-22 00:40:33.000000000","submitted":"2024-12-22 00:40:33.000000000","submitter":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8653","meta_rev_id":"9e2be2741f37a1df59e5a8f084cb79d353e8df33","_number":8653,"owner":{"_account_id":1002351,"name":"Pete Moore","email":"pmoore@mozilla.com","username":"petemoore"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-12-22 00:40:33.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-12-22 00:40:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-12-22 00:40:33.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-12-16 12:22:58.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-12-16 14:19:23.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2024-12-16 14:19:23.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"state":"REVIEWER"}],"messages":[{"id":"5e9a604b7e37f8755511d2bba902565e07feda20","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002351,"name":"Pete Moore","email":"pmoore@mozilla.com","username":"petemoore"},"real_author":{"_account_id":1002351,"name":"Pete Moore","email":"pmoore@mozilla.com","username":"petemoore"},"date":"2024-12-16 12:09:46.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c2e91500f55c292f3579a7c827bbe9268310ba48","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-12-16 12:22:58.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20372/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19525/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"7060979a6e853dbbcf49c7f82dd6b7f69a3226a6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002351,"name":"Pete Moore","email":"pmoore@mozilla.com","username":"petemoore"},"real_author":{"_account_id":1002351,"name":"Pete Moore","email":"pmoore@mozilla.com","username":"petemoore"},"date":"2024-12-16 13:02:57.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"b4ce2e0ebc0956c438d9fd4ecbc0eed34338310f","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-12-16 13:16:07.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20373/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19526/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"8e958a7d54f763076ee01a5406e02f4a89b27a41","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-12-16 14:19:23.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"f7652f94abc5ec61d5034fe299313033a43d80b1","author":{"_account_id":1002351,"name":"Pete Moore","email":"pmoore@mozilla.com","username":"petemoore"},"real_author":{"_account_id":1002351,"name":"Pete Moore","email":"pmoore@mozilla.com","username":"petemoore"},"date":"2024-12-21 12:05:03.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"1d06fac29026f087f1cc9a1a915bbe47eadd9015","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2024-12-21 12:31:43.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"d16f7ec1eea9ae6c8a59bd074daee2a7d7cb4c11","author":{"_account_id":1002351,"name":"Pete Moore","email":"pmoore@mozilla.com","username":"petemoore"},"real_author":{"_account_id":1002351,"name":"Pete Moore","email":"pmoore@mozilla.com","username":"petemoore"},"date":"2024-12-21 17:06:57.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"9e2be2741f37a1df59e5a8f084cb79d353e8df33","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2024-12-22 00:40:33.000000000","message":"Change has been successfully cherry-picked as cb3b8afe47ef791b2671f1af9415bd28dedffb6d","accounts_in_message":[],"_revision_number":3}],"current_revision":"cb3b8afe47ef791b2671f1af9415bd28dedffb6d","revisions":{"0f57a830897b45b97d3991f2efa27a59b56edbfd":{"kind":"REWORK","_number":1,"created":"2024-12-16 12:09:46.000000000","uploader":{"_account_id":1002351,"name":"Pete Moore","email":"pmoore@mozilla.com","username":"petemoore"},"ref":"refs/changes/53/8653/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/53/8653/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/53/8653/1 \u0026\u0026 git checkout -b change-8653 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/53/8653/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/53/8653/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/53/8653/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/53/8653/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/53/8653/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"133dd9d669e5b8beb7c7787b0be677621808e72d","subject":"target/xtensa: add maskisr command support for NX"}],"author":{"name":"Pete Moore","email":"pmoore@mozilla.com","date":"2024-12-16 11:22:45.000000000","tz":60},"committer":{"name":"Pete Moore","email":"pmoore@mozilla.com","date":"2024-12-16 11:52:07.000000000","tz":60},"subject":"jimtcl: Fix command not found","message":"jimtcl: Fix command not found\n\nDuring the ./configure build stage, error \u0027./configure.gnu: line 1: -e:\ncommand not found\u0027 can occur.\n\nProblem: the -e flag with echo is not portable. While some shells support\nit (e.g., Bash), others (e.g., POSIX /bin/sh on some systems) do not.\n\nSolution: replacing echo -e with printf, since printf is POSIX-compliant\nand works consistently across different shells.\n\nChange-Id: I9efbba662599a61bbe1fc56a33dc1ee7ad58826c\nSigned-off-by: Pete Moore \u003cpmoore@mozilla.com\u003e\n"}},"cb3b8afe47ef791b2671f1af9415bd28dedffb6d":{"kind":"REWORK","_number":3,"created":"2024-12-22 00:40:33.000000000","uploader":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"ref":"refs/changes/53/8653/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/53/8653/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/53/8653/3 \u0026\u0026 git checkout -b change-8653 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/53/8653/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/53/8653/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/53/8653/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/53/8653/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/53/8653/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d60e1f6693e52800603eac7c8de3ade14eb6a514","subject":"flash/nor/sfdp: Fix broken DEBUG log line on macOS"}],"author":{"name":"Pete Moore","email":"pmoore@mozilla.com","date":"2024-12-16 13:02:14.000000000","tz":60},"committer":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2024-12-22 00:40:33.000000000","tz":0},"subject":"jimtcl: Fix command not found","message":"jimtcl: Fix command not found\n\nDuring the ./configure build stage, error \u0027./configure.gnu: line 1: -e:\ncommand not found\u0027 can occur.\n\nProblem: the -e flag with echo is not portable. While some shells support\nit (e.g., Bash), others (e.g., POSIX /bin/sh on some systems) do not.\n\nSolution: replacing echo -e with printf, since printf is POSIX-compliant\nand works consistently across different shells.\n\nChange-Id: I9efbba662599a61bbe1fc56a33dc1ee7ad58826c\nSigned-off-by: Pete Moore \u003cpmoore@mozilla.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8653\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-by: Andreas Fritiofson \u003candreas.fritiofson@gmail.com\u003e\n"}},"e8aaa767fc919ff0d54f2eae96bafe1ac5d93f4b":{"kind":"REWORK","_number":2,"created":"2024-12-16 13:02:57.000000000","uploader":{"_account_id":1002351,"name":"Pete Moore","email":"pmoore@mozilla.com","username":"petemoore"},"ref":"refs/changes/53/8653/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/53/8653/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/53/8653/2 \u0026\u0026 git checkout -b change-8653 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/53/8653/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/53/8653/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/53/8653/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/53/8653/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/53/8653/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"133dd9d669e5b8beb7c7787b0be677621808e72d","subject":"target/xtensa: add maskisr command support for NX"}],"author":{"name":"Pete Moore","email":"pmoore@mozilla.com","date":"2024-12-16 13:02:14.000000000","tz":60},"committer":{"name":"Pete Moore","email":"pmoore@mozilla.com","date":"2024-12-16 13:02:14.000000000","tz":60},"subject":"jimtcl: Fix command not found","message":"jimtcl: Fix command not found\n\nDuring the ./configure build stage, error \u0027./configure.gnu: line 1: -e:\ncommand not found\u0027 can occur.\n\nProblem: the -e flag with echo is not portable. While some shells support\nit (e.g., Bash), others (e.g., POSIX /bin/sh on some systems) do not.\n\nSolution: replacing echo -e with printf, since printf is POSIX-compliant\nand works consistently across different shells.\n\nChange-Id: I9efbba662599a61bbe1fc56a33dc1ee7ad58826c\nSigned-off-by: Pete Moore \u003cpmoore@mozilla.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}