)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"bb097c6ad5bbfd3055755a1566487f4ae2db945d","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Adrien Charruel \u003cacharruel@nanoxplore.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-12-06 10:06:58 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"target/armv8: Handle instruction cache flush"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some armv8 target have separate i-cache and d-cache."},{"line_number":10,"context_line":"The actual code only handles the flush of the d-cache."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"cead8117_dcf565b1","line":7,"updated":"2025-03-09 18:01:41.000000000","message":"invalidate, not flush","commit_id":"d13faec9c595e7c99ac4bae22c998a1c583d5163"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d0105d6fbaa3748d4cc3090613c4f5b8530a77ca","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Adrien Charruel \u003cacharruel@nanoxplore.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-12-06 10:06:58 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"target/armv8: Handle instruction cache flush"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some armv8 target have separate i-cache and d-cache."},{"line_number":10,"context_line":"The actual code only handles the flush of the d-cache."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"913980ee_13030389","line":7,"in_reply_to":"cead8117_dcf565b1","updated":"2025-03-15 16:57:47.000000000","message":"Done","commit_id":"d13faec9c595e7c99ac4bae22c998a1c583d5163"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"bb097c6ad5bbfd3055755a1566487f4ae2db945d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6a7385c1_f8519a40","updated":"2025-03-09 18:01:41.000000000","message":"Thanks, in general looks good. Just few comments inside","commit_id":"d13faec9c595e7c99ac4bae22c998a1c583d5163"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d0105d6fbaa3748d4cc3090613c4f5b8530a77ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1f4f3016_779bc00d","updated":"2025-03-15 16:57:47.000000000","message":"Thanks","commit_id":"076f3b6f306e9b9141bd969451e5c047243eddb8"}],"src/target/armv8.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"bb097c6ad5bbfd3055755a1566487f4ae2db945d","unresolved":true,"context_lines":[{"line_number":162,"context_line":"\t/* l2 external unified cache if some */"},{"line_number":163,"context_line":"\tvoid *l2_cache;"},{"line_number":164,"context_line":"\tint (*flush_all_data_cache)(struct target *target);"},{"line_number":165,"context_line":"\tint (*flush_all_instruction_cache)(struct target *target);"},{"line_number":166,"context_line":"\tint (*display_cache_info)(struct command_invocation *cmd,"},{"line_number":167,"context_line":"\t\t\tstruct armv8_cache_common *armv8_cache);"},{"line_number":168,"context_line":"};"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"c58e55bb_91542486","line":165,"updated":"2025-03-09 18:01:41.000000000","message":"invalidate, not flush","commit_id":"d13faec9c595e7c99ac4bae22c998a1c583d5163"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d0105d6fbaa3748d4cc3090613c4f5b8530a77ca","unresolved":false,"context_lines":[{"line_number":162,"context_line":"\t/* l2 external unified cache if some */"},{"line_number":163,"context_line":"\tvoid *l2_cache;"},{"line_number":164,"context_line":"\tint (*flush_all_data_cache)(struct target *target);"},{"line_number":165,"context_line":"\tint (*flush_all_instruction_cache)(struct target *target);"},{"line_number":166,"context_line":"\tint (*display_cache_info)(struct command_invocation *cmd,"},{"line_number":167,"context_line":"\t\t\tstruct armv8_cache_common *armv8_cache);"},{"line_number":168,"context_line":"};"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"2cc12e47_040ee3fc","line":165,"in_reply_to":"c58e55bb_91542486","updated":"2025-03-15 16:57:47.000000000","message":"Done","commit_id":"d13faec9c595e7c99ac4bae22c998a1c583d5163"}],"src/target/armv8_cache.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"bb097c6ad5bbfd3055755a1566487f4ae2db945d","unresolved":true,"context_lines":[{"line_number":282,"context_line":"\treturn retval;"},{"line_number":283,"context_line":"}"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"static int _armv8_flush_all_instruction(struct target *target)"},{"line_number":286,"context_line":"{"},{"line_number":287,"context_line":"\treturn armv8_cache_i_inner_clean_inval_all(target_to_armv8(target));"},{"line_number":288,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"2d4de18e_08e31209","line":285,"updated":"2025-03-09 18:01:41.000000000","message":"you don\u0027t need this extra function, plus please do not use function names that start with `_`\ndirectly call `armv8_cache_i_inner_clean_inval_all()` in next function below","commit_id":"d13faec9c595e7c99ac4bae22c998a1c583d5163"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d0105d6fbaa3748d4cc3090613c4f5b8530a77ca","unresolved":false,"context_lines":[{"line_number":282,"context_line":"\treturn retval;"},{"line_number":283,"context_line":"}"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"static int _armv8_flush_all_instruction(struct target *target)"},{"line_number":286,"context_line":"{"},{"line_number":287,"context_line":"\treturn armv8_cache_i_inner_clean_inval_all(target_to_armv8(target));"},{"line_number":288,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"43e28843_5fa18aca","line":285,"in_reply_to":"2d4de18e_08e31209","updated":"2025-03-15 16:57:47.000000000","message":"Done","commit_id":"d13faec9c595e7c99ac4bae22c998a1c583d5163"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"bb097c6ad5bbfd3055755a1566487f4ae2db945d","unresolved":true,"context_lines":[{"line_number":298,"context_line":"\t}"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"\tif (target-\u003esmp) {"},{"line_number":301,"context_line":"\t\t/*  look if all the other target have been flushed in order to flush level"},{"line_number":302,"context_line":"\t\t *  2 */"},{"line_number":303,"context_line":"\t\tstruct target_list *head;"},{"line_number":304,"context_line":"\t\tforeach_smp_target(head, target-\u003esmp_targets) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"2a535992_0f71ce04","line":301,"updated":"2025-03-09 18:01:41.000000000","message":"please review this command. We are not flushing L2","commit_id":"d13faec9c595e7c99ac4bae22c998a1c583d5163"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d0105d6fbaa3748d4cc3090613c4f5b8530a77ca","unresolved":false,"context_lines":[{"line_number":298,"context_line":"\t}"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"\tif (target-\u003esmp) {"},{"line_number":301,"context_line":"\t\t/*  look if all the other target have been flushed in order to flush level"},{"line_number":302,"context_line":"\t\t *  2 */"},{"line_number":303,"context_line":"\t\tstruct target_list *head;"},{"line_number":304,"context_line":"\t\tforeach_smp_target(head, target-\u003esmp_targets) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"9568e6b3_b16b0d2e","line":301,"in_reply_to":"2a535992_0f71ce04","updated":"2025-03-15 16:57:47.000000000","message":"Done","commit_id":"d13faec9c595e7c99ac4bae22c998a1c583d5163"}],"src/target/armv8_opcodes.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"bb097c6ad5bbfd3055755a1566487f4ae2db945d","unresolved":true,"context_lines":[{"line_number":41,"context_line":"\t\t[ARMV8_OPC_STRH_IP]\t\u003d ARMV8_STRH_IP(1, 0),"},{"line_number":42,"context_line":"\t\t[ARMV8_OPC_STRW_IP]\t\u003d ARMV8_STRW_IP(1, 0),"},{"line_number":43,"context_line":"\t\t[ARMV8_OPC_STRD_IP]\t\u003d ARMV8_STRD_IP(1, 0),"},{"line_number":44,"context_line":"\t\t[ARMV8_OPC_ICIALLU]     \u003d SYSTEM_ICIALLU,"},{"line_number":45,"context_line":"};"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"static const uint32_t t32_opcodes[ARMV8_OPC_NUM] \u003d {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"3c61dc86_ed465cc2","line":44,"updated":"2025-03-09 18:01:41.000000000","message":"here:\n```\n[ARMV8_OPC_ICIALLU] \u003d ARMV8_SYS(SYSTEM_ICIALLU, 0x1F),\n```","commit_id":"d13faec9c595e7c99ac4bae22c998a1c583d5163"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d0105d6fbaa3748d4cc3090613c4f5b8530a77ca","unresolved":false,"context_lines":[{"line_number":41,"context_line":"\t\t[ARMV8_OPC_STRH_IP]\t\u003d ARMV8_STRH_IP(1, 0),"},{"line_number":42,"context_line":"\t\t[ARMV8_OPC_STRW_IP]\t\u003d ARMV8_STRW_IP(1, 0),"},{"line_number":43,"context_line":"\t\t[ARMV8_OPC_STRD_IP]\t\u003d ARMV8_STRD_IP(1, 0),"},{"line_number":44,"context_line":"\t\t[ARMV8_OPC_ICIALLU]     \u003d SYSTEM_ICIALLU,"},{"line_number":45,"context_line":"};"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"static const uint32_t t32_opcodes[ARMV8_OPC_NUM] \u003d {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"2a95d69c_73ed2116","line":44,"in_reply_to":"3c61dc86_ed465cc2","updated":"2025-03-15 16:57:47.000000000","message":"Done","commit_id":"d13faec9c595e7c99ac4bae22c998a1c583d5163"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"bb097c6ad5bbfd3055755a1566487f4ae2db945d","unresolved":true,"context_lines":[{"line_number":69,"context_line":"\t\t[ARMV8_OPC_STRB_IP]\t\u003d ARMV8_STRB_IP_T3(1, 0),"},{"line_number":70,"context_line":"\t\t[ARMV8_OPC_STRH_IP]\t\u003d ARMV8_STRH_IP_T3(1, 0),"},{"line_number":71,"context_line":"\t\t[ARMV8_OPC_STRW_IP]\t\u003d ARMV8_STRW_IP_T3(1, 0),"},{"line_number":72,"context_line":"\t\t[ARMV8_OPC_ICIALLU]     \u003d ARMV4_5_MCR(15, 0, 0, 7, 5, 0),"},{"line_number":73,"context_line":"};"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"void armv8_select_opcodes(struct armv8_common *armv8, bool state_is_aarch64)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"5d3704c5_a7364532","line":72,"updated":"2025-03-09 18:01:41.000000000","message":"pay attention to the character used for indentation.\nThe lines above have a TAB before `\u003d`, you added spaces here.\nThe coding style of OpenOCD requires TAB of 4 white spaces, which apparently is not the default used by your editor.\nIn review.openocd.org you can set the TAB width when you display a patch diff by clicking on the icon with the \u0027gear\u0027 on top-right of the screen.","commit_id":"d13faec9c595e7c99ac4bae22c998a1c583d5163"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d0105d6fbaa3748d4cc3090613c4f5b8530a77ca","unresolved":false,"context_lines":[{"line_number":69,"context_line":"\t\t[ARMV8_OPC_STRB_IP]\t\u003d ARMV8_STRB_IP_T3(1, 0),"},{"line_number":70,"context_line":"\t\t[ARMV8_OPC_STRH_IP]\t\u003d ARMV8_STRH_IP_T3(1, 0),"},{"line_number":71,"context_line":"\t\t[ARMV8_OPC_STRW_IP]\t\u003d ARMV8_STRW_IP_T3(1, 0),"},{"line_number":72,"context_line":"\t\t[ARMV8_OPC_ICIALLU]     \u003d ARMV4_5_MCR(15, 0, 0, 7, 5, 0),"},{"line_number":73,"context_line":"};"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"void armv8_select_opcodes(struct armv8_common *armv8, bool state_is_aarch64)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"d32bee32_2398d34e","line":72,"in_reply_to":"5d3704c5_a7364532","updated":"2025-03-15 16:57:47.000000000","message":"Done","commit_id":"d13faec9c595e7c99ac4bae22c998a1c583d5163"}],"src/target/armv8_opcodes.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"bb097c6ad5bbfd3055755a1566487f4ae2db945d","unresolved":true,"context_lines":[{"line_number":73,"context_line":"#define SYSTEM_DCCSW\t\t\t0x43D2"},{"line_number":74,"context_line":"#define SYSTEM_ICIVAU\t\t\t0x5BA9"},{"line_number":75,"context_line":"/* SYSTEM_ICIALLU can\u0027t be encoded as other cache operation */"},{"line_number":76,"context_line":"#define SYSTEM_ICIALLU          0xd508751f"},{"line_number":77,"context_line":"#define SYSTEM_DCCVAU\t\t\t0x5BD9"},{"line_number":78,"context_line":"#define SYSTEM_DCCIVAC\t\t\t0x5BF1"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"1a6857ff_5884fa87","line":76,"updated":"2025-03-09 18:01:41.000000000","message":"The arm document DDI0487 reports that `Rt field should be set to 0b11111`\nSo it can be encoded as the other operations, but with `rt\u003d0x1f`\nuse here:\n```\n/* Attention, SYSTEM_ICIALLU requires rt\u003d0x1f */\n#define SYSTEM_ICIALLU 0x03A8\n```\n\nActually I\u0027m not fully happy with the macro `ARMV8_SYS()` but, since it\u0027s there, let\u0027s use it!","commit_id":"d13faec9c595e7c99ac4bae22c998a1c583d5163"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d0105d6fbaa3748d4cc3090613c4f5b8530a77ca","unresolved":false,"context_lines":[{"line_number":73,"context_line":"#define SYSTEM_DCCSW\t\t\t0x43D2"},{"line_number":74,"context_line":"#define SYSTEM_ICIVAU\t\t\t0x5BA9"},{"line_number":75,"context_line":"/* SYSTEM_ICIALLU can\u0027t be encoded as other cache operation */"},{"line_number":76,"context_line":"#define SYSTEM_ICIALLU          0xd508751f"},{"line_number":77,"context_line":"#define SYSTEM_DCCVAU\t\t\t0x5BD9"},{"line_number":78,"context_line":"#define SYSTEM_DCCIVAC\t\t\t0x5BF1"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"d240e28d_62994570","line":76,"in_reply_to":"1a6857ff_5884fa87","updated":"2025-03-15 16:57:47.000000000","message":"Done","commit_id":"d13faec9c595e7c99ac4bae22c998a1c583d5163"}]}