)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"change_message_id":"a7521e4ed68c46f3be2b6d1b6e0fef07cd9e80fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f2c00b78_55fe9121","updated":"2024-12-16 14:53:37.000000000","message":"Hello,\n\nThank you for the patch. Have you considered changing the format specifier from PRIx8 to %u instead?","commit_id":"38dd0e2949aee37ec950738638503d454f7da108"},{"author":{"_account_id":1002351,"name":"Pete Moore","email":"pmoore@mozilla.com","username":"petemoore"},"change_message_id":"d174019e19eec0929f9b3b3e39275c98015c5d1c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5d473173_1ce28a2c","updated":"2024-12-16 15:03:28.000000000","message":"Many thanks Paul for taking a look so quickly.","commit_id":"38dd0e2949aee37ec950738638503d454f7da108"},{"author":{"_account_id":1002351,"name":"Pete Moore","email":"pmoore@mozilla.com","username":"petemoore"},"change_message_id":"87da0e0ade19bb1df21f679f381bcad81c4c5596","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8e27e684_4fd81598","in_reply_to":"41344b7d_3822def5","updated":"2024-12-16 16:10:04.000000000","message":"Thanks Paul! I\u0027ve changed the fix to adapt the log message rather than the underlying type, as you suggested. Rather than use %u I\u0027ve used 0x%02x to retain the original formatting, to keep output consistent with previous releases. Many thanks!","commit_id":"38dd0e2949aee37ec950738638503d454f7da108"},{"author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"change_message_id":"205fa7eabb8b3848215dc5badabbbd9f7fc6b39a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"41344b7d_3822def5","in_reply_to":"5ffcb728_ea9cc785","updated":"2024-12-16 15:38:37.000000000","message":"It\u0027s customary to use types semantically. A developer using high-level language shouldn\u0027t be normally concerned with thinking about how big any variable can potentially be and other low-level stuff like that. Moreover in many cases the compilers generate faster and shorter code for \"int\" compared to any smaller type.\nBecause of that the stdint.h types are normally used only when strictly needed for interaction with hardware or binary data formats.","commit_id":"38dd0e2949aee37ec950738638503d454f7da108"},{"author":{"_account_id":1002351,"name":"Pete Moore","email":"pmoore@mozilla.com","username":"petemoore"},"change_message_id":"d174019e19eec0929f9b3b3e39275c98015c5d1c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5ffcb728_ea9cc785","in_reply_to":"f2c00b78_55fe9121","updated":"2024-12-16 15:03:28.000000000","message":"I think either approach works, but since the value is only 8 bits, is it not better to store it in an 8 bit type, like the original implementation did? What would be the advantage of unsigned int?","commit_id":"38dd0e2949aee37ec950738638503d454f7da108"},{"author":{"_account_id":1002351,"name":"Pete Moore","email":"pmoore@mozilla.com","username":"petemoore"},"change_message_id":"575b81555ee8962881f04e43295971cefc2b6b26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"20a5e76e_78c7c03f","updated":"2024-12-21 09:26:36.000000000","message":"Hi folks. What are the next steps for getting this landed? Is that something I have to request, or does it happen automatically?","commit_id":"5452d52f397fd2c2df67c11abfc5b15a70222be4"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9b925fff9ea2a6749dc2efb112d3692dec4f0845","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"faf47753_e1857725","updated":"2024-12-16 17:22:11.000000000","message":"Thanks!","commit_id":"5452d52f397fd2c2df67c11abfc5b15a70222be4"},{"author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"change_message_id":"0348d1de11aca15d5d569991ab7e8db036d3bad5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cc982d50_ff22ce6d","in_reply_to":"20a5e76e_78c7c03f","updated":"2024-12-21 10:16:07.000000000","message":"\u003e Hi folks. What are the next steps for getting this landed? Is that something I have to request, or does it happen automatically?\n\nThank you for the patch, now that it has +2 review it means it\u0027ll be merged soon, nothing to do on your side.","commit_id":"5452d52f397fd2c2df67c11abfc5b15a70222be4"}]}