)]}'
{"id":"openocd~master~Ifc7ddb1279ab2603901c969d9c09af847f3a3caf","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000160":{"account":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"last_update":"2024-12-21 10:16:07.000000000","reason":"\u003cGERRIT_ACCOUNT_1000160\u003e replied on the change","reason_account":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"}},"1002351":{"account":{"_account_id":1002351,"name":"Pete Moore","email":"pmoore@mozilla.com","username":"petemoore"},"last_update":"2024-12-21 10:25:58.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ifc7ddb1279ab2603901c969d9c09af847f3a3caf","subject":"flash/nor/sfdp: Fix broken DEBUG log line on macOS","status":"MERGED","created":"2024-12-16 14:42:04.000000000","updated":"2024-12-21 10:25:58.000000000","submitted":"2024-12-21 10:25:58.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8660","meta_rev_id":"12e47b67c714f30df12ae56334b5d41eee4b04a1","_number":8660,"owner":{"_account_id":1002351,"name":"Pete Moore","email":"pmoore@mozilla.com","username":"petemoore"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-12-21 10:25:58.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"value":0,"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-12-21 10:25:58.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-12-21 10:25:58.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-12-16 14:53:37.000000000","updated_by":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"reviewer":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"state":"REVIEWER"},{"updated":"2024-12-16 15:01:36.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-12-16 17:22:11.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2024-12-16 17:37:28.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"8a2d185477359fc5eaa58dd6d6841bce04248b8f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002351,"name":"Pete Moore","email":"pmoore@mozilla.com","username":"petemoore"},"real_author":{"_account_id":1002351,"name":"Pete Moore","email":"pmoore@mozilla.com","username":"petemoore"},"date":"2024-12-16 14:42:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a7521e4ed68c46f3be2b6d1b6e0fef07cd9e80fe","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2024-12-16 14:53:37.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"2a82c354ba16c9eb6df83575bf8e4718f0450574","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-12-16 15:01:36.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20380/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19533/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"d174019e19eec0929f9b3b3e39275c98015c5d1c","author":{"_account_id":1002351,"name":"Pete Moore","email":"pmoore@mozilla.com","username":"petemoore"},"real_author":{"_account_id":1002351,"name":"Pete Moore","email":"pmoore@mozilla.com","username":"petemoore"},"date":"2024-12-16 15:03:28.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"205fa7eabb8b3848215dc5badabbbd9f7fc6b39a","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2024-12-16 15:38:37.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0640c765c80c1bf566b0cb3a9b348faacc7a108b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002351,"name":"Pete Moore","email":"pmoore@mozilla.com","username":"petemoore"},"real_author":{"_account_id":1002351,"name":"Pete Moore","email":"pmoore@mozilla.com","username":"petemoore"},"date":"2024-12-16 15:56:23.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"87da0e0ade19bb1df21f679f381bcad81c4c5596","author":{"_account_id":1002351,"name":"Pete Moore","email":"pmoore@mozilla.com","username":"petemoore"},"real_author":{"_account_id":1002351,"name":"Pete Moore","email":"pmoore@mozilla.com","username":"petemoore"},"date":"2024-12-16 16:10:04.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"3f4334e2f4bf0e5cf6fa5588ac5a66870c7b527b","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-12-16 16:14:09.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20384/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19537/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"9b925fff9ea2a6749dc2efb112d3692dec4f0845","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-12-16 17:22:11.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"aa57da37bf99d1ec6b050796972d300f301c36cd","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-12-16 17:37:28.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"575b81555ee8962881f04e43295971cefc2b6b26","author":{"_account_id":1002351,"name":"Pete Moore","email":"pmoore@mozilla.com","username":"petemoore"},"real_author":{"_account_id":1002351,"name":"Pete Moore","email":"pmoore@mozilla.com","username":"petemoore"},"date":"2024-12-21 09:26:36.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"0348d1de11aca15d5d569991ab7e8db036d3bad5","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2024-12-21 10:16:07.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"12e47b67c714f30df12ae56334b5d41eee4b04a1","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-12-21 10:25:58.000000000","message":"Change has been successfully cherry-picked as d60e1f6693e52800603eac7c8de3ade14eb6a514","accounts_in_message":[],"_revision_number":3}],"current_revision":"d60e1f6693e52800603eac7c8de3ade14eb6a514","revisions":{"38dd0e2949aee37ec950738638503d454f7da108":{"kind":"REWORK","_number":1,"created":"2024-12-16 14:42:04.000000000","uploader":{"_account_id":1002351,"name":"Pete Moore","email":"pmoore@mozilla.com","username":"petemoore"},"ref":"refs/changes/60/8660/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/60/8660/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/60/8660/1 \u0026\u0026 git checkout -b change-8660 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/60/8660/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/60/8660/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/60/8660/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/60/8660/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/60/8660/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"133dd9d669e5b8beb7c7787b0be677621808e72d","subject":"target/xtensa: add maskisr command support for NX"}],"author":{"name":"Pete Moore","email":"pmoore@mozilla.com","date":"2024-12-16 14:28:52.000000000","tz":60},"committer":{"name":"Pete Moore","email":"pmoore@mozilla.com","date":"2024-12-16 14:28:52.000000000","tz":60},"subject":"flash/nor/sfdp: Fix broken DEBUG log line on macOS","message":"flash/nor/sfdp: Fix broken DEBUG log line on macOS\n\nhttps://review.openocd.org/c/openocd/+/8439 changed variable `words`\nfrom uint8_t to unsigned int in sfdp.c. This broke the LOG_DEBUG\nformatting on macOS, causing:\n\nsrc/flash/nor/sfdp.c:107:28: error: format specifies type \u0027unsigned\nchar\u0027 but the argument has type \u0027unsigned int\u0027 [-Werror,-Wformat]\n\nThis reverts the change in type of variable `words`.\n\nChange-Id: Ifc7ddb1279ab2603901c969d9c09af847f3a3caf\nSigned-off-by: Pete Moore \u003cpmoore@mozilla.com\u003e\n"}},"d60e1f6693e52800603eac7c8de3ade14eb6a514":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2024-12-21 10:25:58.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/60/8660/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/60/8660/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/60/8660/3 \u0026\u0026 git checkout -b change-8660 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/60/8660/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/60/8660/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/60/8660/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/60/8660/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/60/8660/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"133dd9d669e5b8beb7c7787b0be677621808e72d","subject":"target/xtensa: add maskisr command support for NX"}],"author":{"name":"Pete Moore","email":"pmoore@mozilla.com","date":"2024-12-16 15:55:06.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-12-21 10:25:58.000000000","tz":0},"subject":"flash/nor/sfdp: Fix broken DEBUG log line on macOS","message":"flash/nor/sfdp: Fix broken DEBUG log line on macOS\n\nhttps://review.openocd.org/c/openocd/+/8439 changed variable `words`\nfrom uint8_t to unsigned int in sfdp.c but failed to update the\nLOG_DEBUG line to reflect the new type. On macOS this caused:\n\nsrc/flash/nor/sfdp.c:107:28: error: format specifies type \u0027unsigned\nchar\u0027 but the argument has type \u0027unsigned int\u0027 [-Werror,-Wformat]\n\nThe formatting of the debug line has been updated to reflect the updated\ntype.\n\nChange-Id: Ifc7ddb1279ab2603901c969d9c09af847f3a3caf\nSigned-off-by: Pete Moore \u003cpmoore@mozilla.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8660\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"5452d52f397fd2c2df67c11abfc5b15a70222be4":{"kind":"REWORK","_number":2,"created":"2024-12-16 15:56:23.000000000","uploader":{"_account_id":1002351,"name":"Pete Moore","email":"pmoore@mozilla.com","username":"petemoore"},"ref":"refs/changes/60/8660/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/60/8660/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/60/8660/2 \u0026\u0026 git checkout -b change-8660 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/60/8660/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/60/8660/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/60/8660/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/60/8660/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/60/8660/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"133dd9d669e5b8beb7c7787b0be677621808e72d","subject":"target/xtensa: add maskisr command support for NX"}],"author":{"name":"Pete Moore","email":"pmoore@mozilla.com","date":"2024-12-16 15:55:06.000000000","tz":60},"committer":{"name":"Pete Moore","email":"pmoore@mozilla.com","date":"2024-12-16 15:55:06.000000000","tz":60},"subject":"flash/nor/sfdp: Fix broken DEBUG log line on macOS","message":"flash/nor/sfdp: Fix broken DEBUG log line on macOS\n\nhttps://review.openocd.org/c/openocd/+/8439 changed variable `words`\nfrom uint8_t to unsigned int in sfdp.c but failed to update the\nLOG_DEBUG line to reflect the new type. On macOS this caused:\n\nsrc/flash/nor/sfdp.c:107:28: error: format specifies type \u0027unsigned\nchar\u0027 but the argument has type \u0027unsigned int\u0027 [-Werror,-Wformat]\n\nThe formatting of the debug line has been updated to reflect the updated\ntype.\n\nChange-Id: Ifc7ddb1279ab2603901c969d9c09af847f3a3caf\nSigned-off-by: Pete Moore \u003cpmoore@mozilla.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}