)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e2a4e68824c5c50d011f7d00256cd236c0c5069f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ced68703_d299ea95","updated":"2024-12-19 09:48:32.000000000","message":"Thanks. What\u0027s your opinion on the two comments below?","commit_id":"70b714e50737670763e633e08420869ffd3f9677"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e457239a48bd981b79a270fa06191a1891c8e09e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b508b6b9_bf14c4ce","updated":"2024-12-19 11:08:43.000000000","message":"Marc, thanks for the update. Please check better in the two functions in `#if 0` as there are other LOG_ to be converted","commit_id":"51abf10c0c02064f6c2a5c194a7e4bdb91179283"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"ad2ae8597adcf64393bf14a68ec09367088f3265","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b11294c7_c8b05bc2","in_reply_to":"b508b6b9_bf14c4ce","updated":"2024-12-19 11:18:41.000000000","message":"Ups, sorry my bad. Fixed.","commit_id":"51abf10c0c02064f6c2a5c194a7e4bdb91179283"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"51472004ff33c0d3b78d5ef341e881b581309450","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2b7df86b_43015276","updated":"2024-12-19 11:17:44.000000000","message":"Thanks","commit_id":"7339d1a3133cfd092d6c0c5d8b68b721e4ff1d6d"}],"src/target/esirisc.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e2a4e68824c5c50d011f7d00256cd236c0c5069f","unresolved":true,"context_lines":[{"line_number":187,"context_line":"\tuint32_t etc;"},{"line_number":188,"context_line":"\tint retval;"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"\tLOG_DEBUG(\"-\");"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"\tretval \u003d esirisc_jtag_read_csr(jtag_info, CSR_THREAD, CSR_THREAD_ETC, \u0026etc);"},{"line_number":193,"context_line":"\tif (retval !\u003d ERROR_OK) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"0aaf6232_e05ab9f2","line":190,"updated":"2024-12-19 09:48:32.000000000","message":"missing, with the next two in this function\nActually I would like to drop every `#if 0`. Who is going to test this? But in mean time, let\u0027s try to keep this aligned","commit_id":"70b714e50737670763e633e08420869ffd3f9677"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"51472004ff33c0d3b78d5ef341e881b581309450","unresolved":false,"context_lines":[{"line_number":187,"context_line":"\tuint32_t etc;"},{"line_number":188,"context_line":"\tint retval;"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"\tLOG_DEBUG(\"-\");"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"\tretval \u003d esirisc_jtag_read_csr(jtag_info, CSR_THREAD, CSR_THREAD_ETC, \u0026etc);"},{"line_number":193,"context_line":"\tif (retval !\u003d ERROR_OK) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"19067c21_0b7c5c13","line":190,"in_reply_to":"0aaf6232_e05ab9f2","updated":"2024-12-19 11:17:44.000000000","message":"Done","commit_id":"70b714e50737670763e633e08420869ffd3f9677"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"ad2ae8597adcf64393bf14a68ec09367088f3265","unresolved":false,"context_lines":[{"line_number":187,"context_line":"\tuint32_t etc;"},{"line_number":188,"context_line":"\tint retval;"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"\tLOG_DEBUG(\"-\");"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"\tretval \u003d esirisc_jtag_read_csr(jtag_info, CSR_THREAD, CSR_THREAD_ETC, \u0026etc);"},{"line_number":193,"context_line":"\tif (retval !\u003d ERROR_OK) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"29560311_958dd9a6","line":190,"in_reply_to":"0aaf6232_e05ab9f2","updated":"2024-12-19 11:18:41.000000000","message":"Yes, unfortunately I don\u0027t have any device to test this target. Let\u0027s keep it as it is for now.","commit_id":"70b714e50737670763e633e08420869ffd3f9677"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e2a4e68824c5c50d011f7d00256cd236c0c5069f","unresolved":true,"context_lines":[{"line_number":247,"context_line":"\tstruct esirisc_common *esirisc \u003d target_to_esirisc(target);"},{"line_number":248,"context_line":"\tstruct esirisc_jtag *jtag_info \u003d \u0026esirisc-\u003ejtag_info;"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"\tLOG_DEBUG(\"-\");"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"\tint retval \u003d esirisc_jtag_read_csr(jtag_info, CSR_DEBUG, CSR_DEBUG_HWDC,"},{"line_number":253,"context_line":"\t\t\t\u0026esirisc-\u003ehwdc_save);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"23a7ae2d_2ace3ca5","line":250,"updated":"2024-12-19 09:48:32.000000000","message":"Same here and in the next","commit_id":"70b714e50737670763e633e08420869ffd3f9677"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"51472004ff33c0d3b78d5ef341e881b581309450","unresolved":false,"context_lines":[{"line_number":247,"context_line":"\tstruct esirisc_common *esirisc \u003d target_to_esirisc(target);"},{"line_number":248,"context_line":"\tstruct esirisc_jtag *jtag_info \u003d \u0026esirisc-\u003ejtag_info;"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"\tLOG_DEBUG(\"-\");"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"\tint retval \u003d esirisc_jtag_read_csr(jtag_info, CSR_DEBUG, CSR_DEBUG_HWDC,"},{"line_number":253,"context_line":"\t\t\t\u0026esirisc-\u003ehwdc_save);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"03011c9d_15b22f59","line":250,"in_reply_to":"23a7ae2d_2ace3ca5","updated":"2024-12-19 11:17:44.000000000","message":"Done","commit_id":"70b714e50737670763e633e08420869ffd3f9677"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"ad2ae8597adcf64393bf14a68ec09367088f3265","unresolved":false,"context_lines":[{"line_number":247,"context_line":"\tstruct esirisc_common *esirisc \u003d target_to_esirisc(target);"},{"line_number":248,"context_line":"\tstruct esirisc_jtag *jtag_info \u003d \u0026esirisc-\u003ejtag_info;"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"\tLOG_DEBUG(\"-\");"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"\tint retval \u003d esirisc_jtag_read_csr(jtag_info, CSR_DEBUG, CSR_DEBUG_HWDC,"},{"line_number":253,"context_line":"\t\t\t\u0026esirisc-\u003ehwdc_save);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"f3eed7f8_ffd14260","line":250,"in_reply_to":"23a7ae2d_2ace3ca5","updated":"2024-12-19 11:18:41.000000000","message":"Done","commit_id":"70b714e50737670763e633e08420869ffd3f9677"}]}
