)]}'
{"id":"openocd~master~Ibab45f580dc46a499bf967c4afad071f9c2972a2","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2025-01-20 13:09:23.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1002047":{"account":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"last_update":"2025-01-25 10:34:15.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ibab45f580dc46a499bf967c4afad071f9c2972a2","subject":"helper/options: handle errors in `-l`","status":"MERGED","created":"2024-12-20 10:45:34.000000000","updated":"2025-01-25 10:34:15.000000000","submitted":"2025-01-25 10:34:15.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":10,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8666","meta_rev_id":"9836cbac390f2f1aa45c6e8af6039646d63d308f","_number":8666,"owner":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-01-25 10:34:15.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-01-25 10:34:15.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-12-20 10:59:04.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-12-21 15:40:36.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2025-01-20 13:09:23.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"774cd889df49e443438060a727b2249c6eb1f012","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2024-12-20 10:45:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a7469d19929976fb64c9837342a0c9172ea112fd","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-12-20 10:59:04.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20413/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19565/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"cc1264c84bad966f904d47d210eeda198a518aad","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-12-21 15:40:36.000000000","message":"Patch Set 1:\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"ef2518c20f55f7daffefbf22808598c1289bcc46","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2025-01-17 15:48:48.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"cf34cbdb9a717660529fc711f4ab5aa55852a868","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2025-01-17 15:52:25.000000000","message":"Patch Set 2:\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"874132461c4f3c113eb4851acfcd13dc912a5e5c","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-01-17 16:03:44.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20582/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19733/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"516266fba255cde8c98ba151c6a93e2f8da1e8bd","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2025-01-20 12:21:59.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"a88c3c5dabbcbbc53754e98337cd71fa456a9219","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-01-20 12:45:30.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20590/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19741/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"1bd2f76716b0e4162b9aaf5bd7385ed78395b2c1","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-01-20 13:09:23.000000000","message":"Patch Set 3: Code-Review+1\n\n(4 comments)","accounts_in_message":[],"_revision_number":3},{"id":"bf4475c149932671cc7323b327ff8d63691d6cfb","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-01-25 10:34:07.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"9836cbac390f2f1aa45c6e8af6039646d63d308f","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-01-25 10:34:15.000000000","message":"Change has been successfully cherry-picked as 345473f3ceaf6a1241f62354e31eeababfc56588","accounts_in_message":[],"_revision_number":4}],"current_revision":"345473f3ceaf6a1241f62354e31eeababfc56588","revisions":{"345473f3ceaf6a1241f62354e31eeababfc56588":{"kind":"REWORK","_number":4,"created":"2025-01-25 10:34:15.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/66/8666/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/66/8666/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/66/8666/4 \u0026\u0026 git checkout -b change-8666 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/66/8666/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/66/8666/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/66/8666/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/66/8666/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/66/8666/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"778d2dc4bb982ffa00f5fbd343346555fcbf9113","subject":"helper/options: drop redundant argument checks"}],"author":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2024-12-17 15:13:00.000000000","tz":180},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-01-25 10:34:15.000000000","tz":0},"subject":"helper/options: handle errors in `-l`","message":"helper/options: handle errors in `-l`\n\nBefore the patch an error in opening the log file (e.g. can\u0027t write a\nfile) was ignored when specified via `-l`.\nE.g.:\n```\n\u003e touch log\n\u003e chmod -w log\n\u003e openocd -l log -c shutdown\n...\nfailed to open output log \"log\"\nshutdown command invoked\n\u003e echo $?\n0\n```\n\nAfter the patch:\n```\n...\n\u003e openocd -l log -c shutdown\n...\nfailed to open output log \"log\"\n\u003e echo $?\n1\n```\n\nChange-Id: Ibab45f580dc46a499bf967c4afad071f9c2972a2\nSigned-off-by: Evgeniy Naydanov \u003cevgeniy.naydanov@syntacore.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8666\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"4b00600d843313ced8b760d6a7c848e1bae2ac3c":{"kind":"REWORK","_number":3,"created":"2025-01-20 12:21:59.000000000","uploader":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"ref":"refs/changes/66/8666/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/66/8666/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/66/8666/3 \u0026\u0026 git checkout -b change-8666 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/66/8666/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/66/8666/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/66/8666/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/66/8666/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/66/8666/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"876e1beeec8d09be9aa568c9dfb58a56f7cc72cc","subject":"helper/options: drop redundant argument checks"}],"author":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2024-12-17 15:13:00.000000000","tz":180},"committer":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2025-01-20 12:21:33.000000000","tz":180},"subject":"helper/options: handle errors in `-l`","message":"helper/options: handle errors in `-l`\n\nBefore the patch an error in opening the log file (e.g. can\u0027t write a\nfile) was ignored when specified via `-l`.\nE.g.:\n```\n\u003e touch log\n\u003e chmod -w log\n\u003e openocd -l log -c shutdown\n...\nfailed to open output log \"log\"\nshutdown command invoked\n\u003e echo $?\n0\n```\n\nAfter the patch:\n```\n...\n\u003e openocd -l log -c shutdown\n...\nfailed to open output log \"log\"\n\u003e echo $?\n1\n```\n\nChange-Id: Ibab45f580dc46a499bf967c4afad071f9c2972a2\nSigned-off-by: Evgeniy Naydanov \u003cevgeniy.naydanov@syntacore.com\u003e\n"}},"c41481bbc51946348c346fc9d42499661f58a308":{"kind":"REWORK","_number":2,"created":"2025-01-17 15:48:48.000000000","uploader":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"ref":"refs/changes/66/8666/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/66/8666/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/66/8666/2 \u0026\u0026 git checkout -b change-8666 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/66/8666/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/66/8666/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/66/8666/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/66/8666/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/66/8666/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1ecb2df0de219e7b49d27af4c756a3f1132d6816","subject":"helper/options: drop redundant argument checks"}],"author":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2024-12-17 15:13:00.000000000","tz":180},"committer":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2025-01-17 15:47:59.000000000","tz":180},"subject":"helper/options: handle errors in `-l`","message":"helper/options: handle errors in `-l`\n\nBefore the patch an error in opening the log file (e.g. can\u0027t write a\nfile) was ignored when specified via `-l`.\nE.g.:\n```\n\u003e touch log\n\u003e chmod -w log\n\u003e openocd -l log -c shutdown\n...\nfailed to open output log \"log\"\nshutdown command invoked\n\u003e echo $?\n0\n```\n\nAfter the patch:\n```\n...\n\u003e openocd -l log -c shutdown\n...\nfailed to open output log \"log\"\n\u003e echo $?\n1\n```\n\nChange-Id: Ibab45f580dc46a499bf967c4afad071f9c2972a2\nSigned-off-by: Evgeniy Naydanov \u003cevgeniy.naydanov@syntacore.com\u003e\n"}},"b40a2a1aeab23c2ac7e3603625295c438835687c":{"kind":"REWORK","_number":1,"created":"2024-12-20 10:45:34.000000000","uploader":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"ref":"refs/changes/66/8666/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/66/8666/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/66/8666/1 \u0026\u0026 git checkout -b change-8666 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/66/8666/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/66/8666/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/66/8666/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/66/8666/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/66/8666/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"133dd9d669e5b8beb7c7787b0be677621808e72d","subject":"target/xtensa: add maskisr command support for NX"}],"author":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2024-12-17 15:13:00.000000000","tz":180},"committer":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2024-12-20 10:45:11.000000000","tz":180},"subject":"helper/options: handle errors in `-l`","message":"helper/options: handle errors in `-l`\n\nBefore the patch an error in opening the log file (e.g. can\u0027t write a\nfile) was ignored when specified via `-l`.\nE.g.:\n```\n\u003e touch log\n\u003e chmod -w log\n\u003e openocd -l log -c shutdown\n...\nfailed to open output log \"log\"\nshutdown command invoked\n\u003e echo $?\n0\n```\n\nAfter the patch:\n```\n...\n\u003e openocd -l log -c shutdown\n...\nfailed to open output log \"log\"\n\u003e echo $?\n1\n```\n\nChange-Id: Ibab45f580dc46a499bf967c4afad071f9c2972a2\nSigned-off-by: Evgeniy Naydanov \u003cevgeniy.naydanov@syntacore.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}