)]}'
{"id":"openocd~master~I17538e86dc4a31a9589d404e49dcc65a29393390","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2025-03-15 10:20:47.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I17538e86dc4a31a9589d404e49dcc65a29393390","subject":"adapter: simplify command \u0027adapter list\u0027","status":"MERGED","created":"2024-12-26 16:59:22.000000000","updated":"2025-03-15 10:20:47.000000000","submitted":"2025-03-15 10:20:47.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8672","meta_rev_id":"43865dfc9b5764e5c2e1feb6623f3392aa8a8ba7","_number":8672,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-03-15 10:20:47.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-03-15 10:20:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-12-26 17:33:45.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-02-12 10:56:05.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"327b6436922e73363020c8651dbf4e8c987ddcd2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-12-26 16:59:22.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"020984f2c55f7afecf6edafc79b5ad1df329ca15","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-12-26 17:33:45.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20437/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19589/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"21d029bca829a605ceb0f67eec5aa7e8fdd1976e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-01-05 15:19:54.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"748082f518b26f14d0e91d64346b5008de21b2b0","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-01-05 15:49:18.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20482/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19634/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"3378a24fbf789b01c4df9676dec2abdd35a07d4e","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-02-12 10:56:05.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"43865dfc9b5764e5c2e1feb6623f3392aa8a8ba7","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-03-15 10:20:47.000000000","message":"Change has been successfully cherry-picked as 427528069806b20c05c78f935529bd62308351a9","accounts_in_message":[],"_revision_number":3}],"current_revision":"427528069806b20c05c78f935529bd62308351a9","revisions":{"6147a0c0574ac502e9b1b1da13a7113c13096671":{"kind":"REWORK","_number":1,"created":"2024-12-26 16:59:22.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/72/8672/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/72/8672/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/72/8672/1 \u0026\u0026 git checkout -b change-8672 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/72/8672/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/72/8672/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/72/8672/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/72/8672/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/72/8672/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c0902250ba89152b5c129131c6501a9348bc91f0","subject":"adapter: drop command \u0027adapter transports\u0027"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-11-30 23:01:00.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-12-23 20:05:30.000000000","tz":60},"subject":"adapter: simplify command \u0027adapter list\u0027","message":"adapter: simplify command \u0027adapter list\u0027\n\nThe code of command \u0027adapter list\u0027 is called by command \u0027adapter\ndriver\u0027 to list the available drivers in case of error.\nThis dual possible entry points require a conditional check on the\nnumber of command line arguments, reducing the code readability.\n\nSplit the command in a simpler code for the command \u0027adapter list\u0027\nthat only checks the command line, and move in a common helper the\ncode that list the drivers.\n\nWhile there, fix the output and the comments to report \u0027adapter\ndriver\u0027 instead of \u0027debug adapters\u0027; we are not parsing the HW to\nknow which adapter is present.\n\nChange-Id: I17538e86dc4a31a9589d404e49dcc65a29393390\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"c913c5e56ad61b5506236b4f4d619659265e221c":{"kind":"REWORK","_number":2,"created":"2025-01-05 15:19:54.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/72/8672/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/72/8672/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/72/8672/2 \u0026\u0026 git checkout -b change-8672 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/72/8672/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/72/8672/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/72/8672/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/72/8672/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/72/8672/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c0902250ba89152b5c129131c6501a9348bc91f0","subject":"adapter: drop command \u0027adapter transports\u0027"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-11-30 23:01:00.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-01-05 11:23:38.000000000","tz":60},"subject":"adapter: simplify command \u0027adapter list\u0027","message":"adapter: simplify command \u0027adapter list\u0027\n\nThe code of command \u0027adapter list\u0027 is called by command \u0027adapter\ndriver\u0027 to list the available drivers in case of error.\nThis dual possible entry points require a conditional check on the\nnumber of command line arguments, reducing the code readability.\n\nSplit the command in a simpler code for the command \u0027adapter list\u0027\nthat only checks the command line, and move in a common helper the\ncode that list the drivers.\n\nWhile there, fix the output and the comments to report \u0027adapter\ndriver\u0027 instead of \u0027debug adapters\u0027; we are not parsing the HW to\nknow which adapter is present.\n\nChange-Id: I17538e86dc4a31a9589d404e49dcc65a29393390\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"427528069806b20c05c78f935529bd62308351a9":{"kind":"REWORK","_number":3,"created":"2025-03-15 10:20:47.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/72/8672/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/72/8672/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/72/8672/3 \u0026\u0026 git checkout -b change-8672 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/72/8672/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/72/8672/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/72/8672/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/72/8672/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/72/8672/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6beb6280af985e79094501af5cb66d1a33019544","subject":"adapter: drop command \u0027adapter transports\u0027"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-11-30 23:01:00.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-03-15 10:20:47.000000000","tz":0},"subject":"adapter: simplify command \u0027adapter list\u0027","message":"adapter: simplify command \u0027adapter list\u0027\n\nThe code of command \u0027adapter list\u0027 is called by command \u0027adapter\ndriver\u0027 to list the available drivers in case of error.\nThis dual possible entry points require a conditional check on the\nnumber of command line arguments, reducing the code readability.\n\nSplit the command in a simpler code for the command \u0027adapter list\u0027\nthat only checks the command line, and move in a common helper the\ncode that list the drivers.\n\nWhile there, fix the output and the comments to report \u0027adapter\ndriver\u0027 instead of \u0027debug adapters\u0027; we are not parsing the HW to\nknow which adapter is present.\n\nChange-Id: I17538e86dc4a31a9589d404e49dcc65a29393390\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8672\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}
