)]}'
{"src/transport/transport.c":[{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"4b675bee8ac0b67b90b1ab6c3b5af3adcb0d19c5","unresolved":true,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"static const char *transport_name(unsigned int id)"},{"line_number":80,"context_line":"{"},{"line_number":81,"context_line":"\tfor (unsigned int i \u003d 0; i \u003c ARRAY_SIZE(transport_names); i++)"},{"line_number":82,"context_line":"\t\tif (id \u003d\u003d transport_names[i].id)"},{"line_number":83,"context_line":"\t\t\treturn transport_names[i].name;"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"616394a8_d3a3f1cd","line":81,"updated":"2025-04-20 08:10:48.000000000","message":"Should be `size_t`, but I\u0027m fine if this is fixed in a follow-up patch.","commit_id":"befa399932bcab01ce9a0d5f373fc5685836ea6a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"cbb31fee73ac02bc265ff626bac44982028facd4","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"static const char *transport_name(unsigned int id)"},{"line_number":80,"context_line":"{"},{"line_number":81,"context_line":"\tfor (unsigned int i \u003d 0; i \u003c ARRAY_SIZE(transport_names); i++)"},{"line_number":82,"context_line":"\t\tif (id \u003d\u003d transport_names[i].id)"},{"line_number":83,"context_line":"\t\t\treturn transport_names[i].name;"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"cf714219_66df79d0","line":81,"in_reply_to":"616394a8_d3a3f1cd","updated":"2025-04-29 08:02:49.000000000","message":"Yes I agree with you, `size_t` should be used here.\nAnd next patch 8677 introduces other 2 cases.\nLooking for loops on `ARRAY_SIZE` in existing code there are:\n- 26 `size_t`\n- 46 `unsigned int`\n- 2 `uint32_t`\n- 1 `uint16_t`\n- 2 `int` with cast around `ARRAY_SIZE`\n- 27 more cases that need further investigation\n\nI would prefer merging this and then fix all together","commit_id":"befa399932bcab01ce9a0d5f373fc5685836ea6a"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"69294079cad7ab40378443c39b9055c2d026b198","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"static const char *transport_name(unsigned int id)"},{"line_number":80,"context_line":"{"},{"line_number":81,"context_line":"\tfor (unsigned int i \u003d 0; i \u003c ARRAY_SIZE(transport_names); i++)"},{"line_number":82,"context_line":"\t\tif (id \u003d\u003d transport_names[i].id)"},{"line_number":83,"context_line":"\t\t\treturn transport_names[i].name;"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"b7fa82d3_f27e1f1e","line":81,"in_reply_to":"cf714219_66df79d0","updated":"2025-04-29 09:10:08.000000000","message":"Yep, makes sense.","commit_id":"befa399932bcab01ce9a0d5f373fc5685836ea6a"}],"src/transport/transport.h":[{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"4b675bee8ac0b67b90b1ab6c3b5af3adcb0d19c5","unresolved":true,"context_lines":[{"line_number":15,"context_line":"#include \"helper/bits.h\""},{"line_number":16,"context_line":"#include \"helper/command.h\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"#define TRANSPORT_JTAG                  BIT(0)"},{"line_number":19,"context_line":"#define TRANSPORT_SWD                   BIT(1)"},{"line_number":20,"context_line":"#define TRANSPORT_HLA_JTAG              BIT(2)"},{"line_number":21,"context_line":"#define TRANSPORT_HLA_SWD               BIT(3)"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"04af6770_27a8f968","line":18,"updated":"2025-04-20 08:10:48.000000000","message":"Would it be cleaner to use an `enum` here?","commit_id":"befa399932bcab01ce9a0d5f373fc5685836ea6a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"cbb31fee73ac02bc265ff626bac44982028facd4","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#include \"helper/bits.h\""},{"line_number":16,"context_line":"#include \"helper/command.h\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"#define TRANSPORT_JTAG                  BIT(0)"},{"line_number":19,"context_line":"#define TRANSPORT_SWD                   BIT(1)"},{"line_number":20,"context_line":"#define TRANSPORT_HLA_JTAG              BIT(2)"},{"line_number":21,"context_line":"#define TRANSPORT_HLA_SWD               BIT(3)"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"629ea72e_82efdf64","line":18,"in_reply_to":"04af6770_27a8f968","updated":"2025-04-29 08:02:49.000000000","message":"I disagree.\nAn enum is something you use to assign a symbol to an enumeration where probably the value itself is not relevant.\nHere instead it\u0027s a real bitmask. And in the code we use bitwise operations like `TRANSPORT_JTAG | TRANSPORT_SWD` or masking that are not suitable for enumerations.","commit_id":"befa399932bcab01ce9a0d5f373fc5685836ea6a"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"69294079cad7ab40378443c39b9055c2d026b198","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#include \"helper/bits.h\""},{"line_number":16,"context_line":"#include \"helper/command.h\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"#define TRANSPORT_JTAG                  BIT(0)"},{"line_number":19,"context_line":"#define TRANSPORT_SWD                   BIT(1)"},{"line_number":20,"context_line":"#define TRANSPORT_HLA_JTAG              BIT(2)"},{"line_number":21,"context_line":"#define TRANSPORT_HLA_SWD               BIT(3)"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"622de60c_d59ce389","line":18,"in_reply_to":"629ea72e_82efdf64","updated":"2025-04-29 09:10:08.000000000","message":"Hm, I see your point. Other languages have a more relaxed understanding of an `enum`.","commit_id":"befa399932bcab01ce9a0d5f373fc5685836ea6a"}]}