)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"32b212fd7c7b1f2a8d6256321ec5eec7ca4869ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"06449c07_d8ad71af","updated":"2025-02-12 15:51:11.000000000","message":"Thanks, I will send the fix in the v2","commit_id":"565ad186e70a3ba29361bbf98db20793232adc6d"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"5e3d654b742760c1016e3d6d463c3820da718295","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5185d38e_2c462a28","updated":"2025-03-25 16:56:59.000000000","message":"Checked visually and LGTM.","commit_id":"167d01e7c4cc83c556631827439d43ec83e0b980"}],"src/transport/transport.c":[{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"5930716f82516fe7b106908f9d03c87edbc77798","unresolved":true,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"\t/* validate the values in transport_ids and transport_preferred_id */"},{"line_number":134,"context_line":"\tif (transport_ids \u003d\u003d 0 || (transport_ids \u0026 ~TRANSPORT_VALID_MASK) !\u003d 0) {"},{"line_number":135,"context_line":"\t\tLOG_ERROR(\"Unknown transport IDs %lu\", transport_ids \u0026 ~TRANSPORT_VALID_MASK);"},{"line_number":136,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":137,"context_line":"\t}"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"e090fe87_b2492aee","line":135,"updated":"2025-01-14 17:19:41.000000000","message":"Detail: These checks are in fact self-checks for the OpenOCD\u0027s code itself (code of the drivers). So you can prefix all the error messages by `BUG: `, as it is done elsewhere for similar self-checks.","commit_id":"565ad186e70a3ba29361bbf98db20793232adc6d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"32b212fd7c7b1f2a8d6256321ec5eec7ca4869ac","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"\t/* validate the values in transport_ids and transport_preferred_id */"},{"line_number":134,"context_line":"\tif (transport_ids \u003d\u003d 0 || (transport_ids \u0026 ~TRANSPORT_VALID_MASK) !\u003d 0) {"},{"line_number":135,"context_line":"\t\tLOG_ERROR(\"Unknown transport IDs %lu\", transport_ids \u0026 ~TRANSPORT_VALID_MASK);"},{"line_number":136,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":137,"context_line":"\t}"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"b9dc37ff_5bdf98a1","line":135,"in_reply_to":"e090fe87_b2492aee","updated":"2025-02-12 15:51:11.000000000","message":"Ack","commit_id":"565ad186e70a3ba29361bbf98db20793232adc6d"}]}